Re: RFR: 8304674: AttachCurrentThread 's argument is JavaVMAttachArgs

2025-04-05 Thread Jaikiran Pai
On Mon, 31 Mar 2025 01:28:47 GMT, tison wrote: >> Try to add clear type annotations. >> >> Please let me know how this patch can be properly reviewed >_< > > retest? Hello @tisonkun, is there an issue created for this? https://bugs.openjdk.org/browse/JDK-8304674 against which this PR is linked

Re: RFR: 8304674: AttachCurrentThread 's argument is JavaVMAttachArgs

2025-04-03 Thread tison
On Tue, 1 Apr 2025 05:38:17 GMT, Jaikiran Pai wrote: >> @jaikiran not yet. How can I create an issue for this PR? I don't find some >> instructions :/ > > Hello @tisonkun, > >> How can I create an issue for this PR? I don't find some instructions :/ > > In general, the OpenJDK contribution gui

Re: RFR: 8304674: AttachCurrentThread 's argument is JavaVMAttachArgs

2025-04-03 Thread tison
On Wed, 23 Oct 2024 06:06:43 GMT, tison wrote: > Try to add clear type annotations. > > Please let me know how this patch can be properly reviewed >_< > _Mailing list message from [David Holmes](mailto:david.hol...@oracle.com) on > [core-libs-dev](mailto:core-libs-...@mail.openjdk.org):_ > >

Re: RFR: 8304674: AttachCurrentThread 's argument is JavaVMAttachArgs

2025-03-31 Thread Jaikiran Pai
On Mon, 31 Mar 2025 02:43:45 GMT, tison wrote: >> Hello @tisonkun, is there an issue created for this? >> https://bugs.openjdk.org/browse/JDK-8304674 against which this PR is linked >> is for something else. The PR description too isn't clear what this change >> is about. > > @jaikiran not yet

RFR: 8304674: AttachCurrentThread 's argument is JavaVMAttachArgs

2025-03-30 Thread tison
Try to add clear type annotations. Please let me know how this patch can be properly reviewed >_< - Commit messages: - chore: AttachCurrentThread 's argument is JavaVMAttachArgs Changes: https://git.openjdk.org/jdk/pull/21658/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr

Re: RFR: 8304674: AttachCurrentThread 's argument is JavaVMAttachArgs

2025-03-30 Thread David Holmes
Hi, This change was already proposed (by myself): https://bugs.openjdk.org/browse/JDK-8289253 but it cannot be done as it will break source compatibility. We will just have to live with this historical oddity. Cheers, David On 31/03/2025 12:46 pm, tison wrote: On Mon, 31 Mar 2025 02:08:02 G

Re: RFR: 8304674: AttachCurrentThread 's argument is JavaVMAttachArgs

2025-03-30 Thread tison
On Mon, 31 Mar 2025 02:08:02 GMT, Jaikiran Pai wrote: >> retest? > > Hello @tisonkun, is there an issue created for this? > https://bugs.openjdk.org/browse/JDK-8304674 against which this PR is linked > is for something else. The PR description too isn't clear what this change is > about. @jai

Re: RFR: 8304674: AttachCurrentThread 's argument is JavaVMAttachArgs

2025-03-30 Thread tison
On Wed, 23 Oct 2024 06:06:43 GMT, tison wrote: > Try to add clear type annotations. > > Please let me know how this patch can be properly reviewed >_< Let me see how to sign an OCA .. Wait a bit :P Wait a bit :P Wait a bit :P retest? - PR Comment: https://git.openjdk.org/jdk/p