Re: RFR: 8304360: Test to ensure ConstantDescs fields work [v2]

2023-03-16 Thread Chen Liang
On Thu, 16 Mar 2023 18:40:12 GMT, Chen Liang wrote: >> https://github.com/openjdk/jdk/pull/13033#issuecomment-1470857327 >> >> Add a test to validate that all constants in ConstantDescs can be resolved >> with a minimally-trusted lookup, and select constants represent the objects >> they claim

Re: RFR: 8304360: Test to ensure ConstantDescs fields work [v2]

2023-03-16 Thread ExE Boss
On Thu, 16 Mar 2023 18:40:12 GMT, Chen Liang wrote: >> https://github.com/openjdk/jdk/pull/13033#issuecomment-1470857327 >> >> Add a test to validate that all constants in ConstantDescs can be resolved >> with a minimally-trusted lookup, and select constants represent the objects >> they claim

Re: RFR: 8304360: Test to ensure ConstantDescs fields work [v2]

2023-03-16 Thread Jorn Vernee
On Thu, 16 Mar 2023 18:40:12 GMT, Chen Liang wrote: >> https://github.com/openjdk/jdk/pull/13033#issuecomment-1470857327 >> >> Add a test to validate that all constants in ConstantDescs can be resolved >> with a minimally-trusted lookup, and select constants represent the objects >> they claim

Re: RFR: 8304360: Test to ensure ConstantDescs fields work [v2]

2023-03-16 Thread Mandy Chung
On Thu, 16 Mar 2023 18:40:12 GMT, Chen Liang wrote: >> https://github.com/openjdk/jdk/pull/13033#issuecomment-1470857327 >> >> Add a test to validate that all constants in ConstantDescs can be resolved >> with a minimally-trusted lookup, and select constants represent the objects >> they claim

Re: RFR: 8304360: Test to ensure ConstantDescs fields work [v2]

2023-03-16 Thread Chen Liang
On Thu, 16 Mar 2023 18:12:23 GMT, Jorn Vernee wrote: >> Chen Liang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Switch to DataProvider > > test/jdk/java/lang/constant/ConstantDescsTest.java line 65: > >> 63: */ >> 64: @Test

Re: RFR: 8304360: Test to ensure ConstantDescs fields work [v2]

2023-03-16 Thread Chen Liang
> https://github.com/openjdk/jdk/pull/13033#issuecomment-1470857327 > > Add a test to validate that all constants in ConstantDescs can be resolved > with a minimally-trusted lookup, and select constants represent the objects > they claim to be. Chen Liang has updated the pull request incrementa

Re: RFR: 8304360: Test to ensure ConstantDescs fields work

2023-03-16 Thread Jorn Vernee
On Thu, 16 Mar 2023 16:58:53 GMT, Chen Liang wrote: > https://github.com/openjdk/jdk/pull/13033#issuecomment-1470857327 > > Add a test to validate that all constants in ConstantDescs can be resolved > with a minimally-trusted lookup, and select constants represent the objects > they claim to b

RFR: 8304360: Test to ensure ConstantDescs fields work

2023-03-16 Thread Chen Liang
https://github.com/openjdk/jdk/pull/13033#issuecomment-1470857327 Add a test to validate that all constants in ConstantDescs can be resolved with a minimally-trusted lookup, and select constants represent the objects they claim to be. - Commit messages: - Whitespace - constantdes