> This PR proposes changing old-type switch statements to newer forms of switch.
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Pretty case statements
-
Changes:
- all: https://git.openjdk.org/jdk/pull/13047/files
-
> This PR proposes changing old-type switch statements to newer forms of switch.
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Update after comments
-
Changes:
- all: https://git.openjdk.org/jdk/pull/13047/files
- n
On Wed, 15 Mar 2023 18:34:50 GMT, Maurizio Cimadamore
wrote:
>> Per Minborg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Reintroduce missing comment
>
> src/java.base/share/classes/jdk/internal/foreign/abi/riscv64/linux/TypeClass.jav
On Thu, 16 Mar 2023 09:40:30 GMT, Maurizio Cimadamore
wrote:
>> src/java.base/share/classes/jdk/internal/foreign/abi/CallingSequenceBuilder.java
>> line 219:
>>
>>> 217: case Binding.Cast unused-> true;
>>> 218: };
>>> 219: }
>>
>> I'd go a bit further here and visuall
On Wed, 15 Mar 2023 19:38:53 GMT, Jorn Vernee wrote:
>> Per Minborg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Reintroduce missing comment
>
> src/java.base/share/classes/jdk/internal/foreign/abi/CallingSequenceBuilder.java
> line
> This PR proposes changing old-type switch statements to newer forms of switch.
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Reintroduce missing comment
-
Changes:
- all: https://git.openjdk.org/jdk/pull/13047/files
On Wed, 15 Mar 2023 18:10:29 GMT, Per Minborg wrote:
> This PR proposes changing old-type switch statements to newer forms of switch.
src/java.base/share/classes/jdk/internal/foreign/abi/CallingSequenceBuilder.java
line 219:
> 217: case Binding.Cast unused-> true;
> 218: };
On Wed, 15 Mar 2023 19:33:19 GMT, Jorn Vernee wrote:
>> src/java.base/share/classes/jdk/internal/foreign/abi/CallingSequenceBuilder.java
>> line 208:
>>
>>> 206: static boolean isUnbox(Binding binding) {
>>> 207: return switch (binding) {
>>> 208: case Binding.VMStore un
On Wed, 15 Mar 2023 18:33:34 GMT, Maurizio Cimadamore
wrote:
>> This PR proposes changing old-type switch statements to newer forms of
>> switch.
>
> src/java.base/share/classes/jdk/internal/foreign/abi/CallingSequenceBuilder.java
> line 208:
>
>> 206: static boolean isUnbox(Binding bindi
On Wed, 15 Mar 2023 18:10:29 GMT, Per Minborg wrote:
> This PR proposes changing old-type switch statements to newer forms of switch.
Overall looks good. I've added a couple of optional comments for your
consideration.
src/java.base/share/classes/jdk/internal/foreign/abi/CallingSequenceBuilder
This PR proposes changing old-type switch statements to newer forms of switch.
-
Commit messages:
- Update copyright years
- Modernize the switch statements in jdk.internal.foreign
Changes: https://git.openjdk.org/jdk/pull/13047/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&
11 matches
Mail list logo
