On Mon, 30 Oct 2023 17:57:23 GMT, Eirik Bjorsnos wrote:
>> This way of updating the copyright was suggested by @jaikiran in the March
>> 10th comment above. Would be nice to get this clarified, yes.
>
> There is actually very little left of Martin's code after my rewrite, besides
> whitespace,
On Mon, 30 Oct 2023 17:45:28 GMT, Eirik Bjorsnos wrote:
>> test/jdk/java/util/zip/DataDescriptorSignatureMissing.java line 3:
>>
>>> 1: /*
>>> 2: * Copyright 2012 Google, Inc. All Rights Reserved.
>>> 3: * Copyright (c) 2023, Oracle and/or its affiliates. All rights reserved.
>>
>> I am not
On Mon, 30 Oct 2023 15:02:57 GMT, Lance Andersen wrote:
> Another question, is the zip that is generated by this test readable by other
> zip tools such as info-zip, Apache Common-compress, winzip?
- info-zip: Does not support unzipping from a zip, so uses the CEN instead of
the data descript
On Sat, 28 Oct 2023 20:01:56 GMT, Eirik Bjorsnos wrote:
>> Please review this PR which brings the DataDescriptorSignatureMissing test
>> back to life.
>>
>> This test currently calls out to Python to create a test vector ZIP with a
>> Data Descriptor without the recommended but optional signa
On Sat, 28 Oct 2023 20:01:56 GMT, Eirik Bjorsnos wrote:
>> Please review this PR which brings the DataDescriptorSignatureMissing test
>> back to life.
>>
>> This test currently calls out to Python to create a test vector ZIP with a
>> Data Descriptor without the recommended but optional signa
> Please review this PR which brings the DataDescriptorSignatureMissing test
> back to life.
>
> This test currently calls out to Python to create a test vector ZIP with a
> Data Descriptor without the recommended but optional signature. The Python
> dependency has turned out to be very brittl
