Re: RFR: 8303920: Avoid calling out to python in DataDescriptorSignatureMissing test [v5]

2023-03-10 Thread Eirik Bjorsnos
On Fri, 10 Mar 2023 09:15:30 GMT, Jaikiran Pai wrote: > This now looks good to me. Thanks for taking time to do this thorough review and especially for running the regressing case. Much appreciated! I'll wait for a second review before integrating. - PR: https://git.openjdk.org/j

Re: RFR: 8303920: Avoid calling out to python in DataDescriptorSignatureMissing test [v5]

2023-03-10 Thread Jaikiran Pai
On Fri, 10 Mar 2023 08:48:00 GMT, Eirik Bjorsnos wrote: >> Please review this PR which brings the DataDescriptorSignatureMissing test >> back to life. >> >> This test currently calls out to Python to create a test vector ZIP with a >> Data Descriptor without the recommended but optional signa

Re: RFR: 8303920: Avoid calling out to python in DataDescriptorSignatureMissing test [v5]

2023-03-10 Thread Eirik Bjorsnos
> Please review this PR which brings the DataDescriptorSignatureMissing test > back to life. > > This test currently calls out to Python to create a test vector ZIP with a > Data Descriptor without the recommended but optional signature. The Python > dependency has turned out to be very brittl