Re: RFR: 8303920: Avoid calling out to python in DataDescriptorSignatureMissing test [v3]

2023-03-10 Thread Eirik Bjorsnos
On Fri, 10 Mar 2023 08:14:56 GMT, Jaikiran Pai wrote: >> Eirik Bjorsnos has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Use "Signatureless" consistently > > test/jdk/java/util/zip/DataDescriptorSignatureMissing.java line 2: > >> 1: /* >

Re: RFR: 8303920: Avoid calling out to python in DataDescriptorSignatureMissing test [v3]

2023-03-10 Thread Jaikiran Pai
On Fri, 10 Mar 2023 08:06:58 GMT, Eirik Bjorsnos wrote: >> Please review this PR which brings the DataDescriptorSignatureMissing test >> back to life. >> >> This test currently calls out to Python to create a test vector ZIP with a >> Data Descriptor without the recommended but optional signa

Re: RFR: 8303920: Avoid calling out to python in DataDescriptorSignatureMissing test [v3]

2023-03-10 Thread Eirik Bjorsnos
> Please review this PR which brings the DataDescriptorSignatureMissing test > back to life. > > This test currently calls out to Python to create a test vector ZIP with a > Data Descriptor without the recommended but optional signature. The Python > dependency has turned out to be very brittl