Re: RFR: 8303530: Add system property for custom JAXP configuration file [v11]

2023-05-09 Thread Alan Bateman
On Tue, 2 May 2023 20:16:15 GMT, Joe Wang wrote: >> Add a system property, jdk.xml.config.file, to return the path to a custom >> JAXP configuration file. The current configuration file, jaxp.properties, >> that the JDK supports will become the default configuration file. >> >> CSR: https://bu

Re: RFR: 8303530: Add system property for custom JAXP configuration file [v9]

2023-05-05 Thread Alan Bateman
On Tue, 2 May 2023 19:26:38 GMT, Joe Wang wrote: >> One other thing to say on this is that jaxp.properties has "XML Library >> (java.xml) Configuration File" at the top of the file, maybe that could be >> used in the module description instead of "JAXP Configuration File". > > Changed the openi

Re: RFR: 8303530: Add system property for custom JAXP configuration file [v9]

2023-05-02 Thread Joe Wang
On Sun, 30 Apr 2023 07:37:07 GMT, Alan Bateman wrote: >> Joe Wang has updated the pull request with a new target base due to a merge >> or a rebase. The incremental webrev excludes the unrelated changes brought >> in by the merge/rebase. The pull request contains ten additional commits >> sinc

Re: RFR: 8303530: Add system property for custom JAXP configuration file [v11]

2023-05-02 Thread Joe Wang
> Add a system property, jdk.xml.config.file, to return the path to a custom > JAXP configuration file. The current configuration file, jaxp.properties, > that the JDK supports will become the default configuration file. > > CSR: https://bugs.openjdk.org/browse/JDK-8303531 > > Tests: XML SQE an

Re: RFR: 8303530: Add system property for custom JAXP configuration file [v9]

2023-05-02 Thread Joe Wang
On Sun, 30 Apr 2023 07:40:22 GMT, Alan Bateman wrote: >> Joe Wang has updated the pull request with a new target base due to a merge >> or a rebase. The incremental webrev excludes the unrelated changes brought >> in by the merge/rebase. The pull request contains ten additional commits >> sinc

Re: RFR: 8303530: Add system property for custom JAXP configuration file [v9]

2023-05-02 Thread Joe Wang
On Mon, 1 May 2023 18:25:13 GMT, Naoto Sato wrote: > Regarding the new unit tests, it looks like there are a lot of boilerplate > codes. Can they be shared? Multiple tests per a processor, and separate test per each processor, if that's what you meant, they unfortunately can not be run within

Re: RFR: 8303530: Add system property for custom JAXP configuration file [v9]

2023-05-02 Thread Joe Wang
On Sun, 30 Apr 2023 07:27:12 GMT, Alan Bateman wrote: >> Joe Wang has updated the pull request with a new target base due to a merge >> or a rebase. The incremental webrev excludes the unrelated changes brought >> in by the merge/rebase. The pull request contains ten additional commits >> sinc

Re: RFR: 8303530: Add system property for custom JAXP configuration file [v9]

2023-05-02 Thread Joe Wang
On Sun, 30 Apr 2023 07:53:06 GMT, Alan Bateman wrote: >> src/java.xml/share/classes/module-info.java line 33: >> >>> 31: * JAXP supports the use of a configuration file for the >>> 32: * Factory Lookup Mechanism and >>> 33: * setting properties that have defined corresponding system propertie

Re: RFR: 8303530: Add system property for custom JAXP configuration file [v10]

2023-05-02 Thread Joe Wang
> Add a system property, jdk.xml.config.file, to return the path to a custom > JAXP configuration file. The current configuration file, jaxp.properties, > that the JDK supports will become the default configuration file. > > CSR: https://bugs.openjdk.org/browse/JDK-8303531 > > Tests: XML SQE an

Re: RFR: 8303530: Add system property for custom JAXP configuration file [v9]

2023-05-01 Thread Naoto Sato
On Fri, 28 Apr 2023 05:47:24 GMT, Joe Wang wrote: >> Add a system property, jdk.xml.config.file, to return the path to a custom >> JAXP configuration file. The current configuration file, jaxp.properties, >> that the JDK supports will become the default configuration file. >> >> CSR: https://b

Re: RFR: 8303530: Add system property for custom JAXP configuration file [v9]

2023-04-30 Thread Alan Bateman
On Sun, 30 Apr 2023 07:23:16 GMT, Alan Bateman wrote: >> Joe Wang has updated the pull request with a new target base due to a merge >> or a rebase. The incremental webrev excludes the unrelated changes brought >> in by the merge/rebase. The pull request contains ten additional commits >> sinc

Re: RFR: 8303530: Add system property for custom JAXP configuration file [v9]

2023-04-30 Thread Alan Bateman
On Fri, 28 Apr 2023 05:47:24 GMT, Joe Wang wrote: >> Add a system property, jdk.xml.config.file, to return the path to a custom >> JAXP configuration file. The current configuration file, jaxp.properties, >> that the JDK supports will become the default configuration file. >> >> CSR: https://b

Re: RFR: 8303530: Add system property for custom JAXP configuration file [v9]

2023-04-27 Thread Joe Wang
> Add a system property, jdk.xml.config.file, to return the path to a custom > JAXP configuration file. The current configuration file, jaxp.properties, > that the JDK supports will become the default configuration file. > > CSR: https://bugs.openjdk.org/browse/JDK-8303531 > > Tests: XML SQE an

Re: RFR: 8303530: Add system property for custom JAXP configuration file [v8]

2023-04-06 Thread Joe Wang
> Add a system property, jdk.xml.config.file, to return the path to a custom > JAXP configuration file. The current configuration file, jaxp.properties, > that the JDK supports will become the default configuration file. > > CSR: https://bugs.openjdk.org/browse/JDK-8303531 > > Tests: XML SQE an

Re: RFR: 8303530: Add system property for custom JAXP configuration file [v7]

2023-04-04 Thread Joe Wang
> Add a system property, jdk.xml.config.file, to return the path to a custom > JAXP configuration file. The current configuration file, jaxp.properties, > that the JDK supports will become the default configuration file. > > CSR: https://bugs.openjdk.org/browse/JDK-8303531 > > Tests: XML SQE an

Re: RFR: 8303530: Add system property for custom JAXP configuration file [v6]

2023-03-31 Thread Joe Wang
> Add a system property, jdk.xml.config.file, to return the path to a custom > JAXP configuration file. The current configuration file, jaxp.properties, > that the JDK supports will become the default configuration file. > > CSR: https://bugs.openjdk.org/browse/JDK-8303531 > > Tests: XML SQE an

Re: RFR: 8303530: Add system property for custom JAXP configuration file [v5]

2023-03-29 Thread Joe Wang
> Add a system property, jdk.xml.config.file, to return the path to a custom > JAXP configuration file. The current configuration file, jaxp.properties, > that the JDK supports will become the default configuration file. > > CSR: https://bugs.openjdk.org/browse/JDK-8303531 > > Tests: XML SQE an

Re: RFR: 8303530: Add system property for custom JAXP configuration file [v4]

2023-03-29 Thread Joe Wang
> Add a system property, jdk.xml.config.file, to return the path to a custom > JAXP configuration file. The current configuration file, jaxp.properties, > that the JDK supports will become the default configuration file. > > CSR: https://bugs.openjdk.org/browse/JDK-8303531 > > Tests: XML SQE an

Re: RFR: 8303530: Add system property for custom JAXP configuration file [v3]

2023-03-14 Thread Joe Wang
> Add a system property, jdk.xml.config.file, to return the path to a custom > JAXP configuration file. The current configuration file, jaxp.properties, > that the JDK supports will become the default configuration file. > > CSR: https://bugs.openjdk.org/browse/JDK-8303531 > > Tests: XML SQE an

Re: RFR: 8303530: Add system property for custom JAXP configuration file [v2]

2023-03-13 Thread Joe Wang
On Mon, 13 Mar 2023 11:34:50 GMT, Alan Bateman wrote: >> Joe Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> clean up tests; fix copy&paste error. > > src/java.xml/share/classes/module-info.java line 89: > >> 87: * the StAX factor

Re: RFR: 8303530: Add system property for custom JAXP configuration file [v2]

2023-03-13 Thread Joe Wang
On Mon, 13 Mar 2023 11:28:15 GMT, Alan Bateman wrote: >> Joe Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> clean up tests; fix copy&paste error. > > src/java.xml/share/classes/javax/xml/stream/XMLEventFactory.java line 139: > >>

Re: RFR: 8303530: Add system property for custom JAXP configuration file [v2]

2023-03-13 Thread Joe Wang
On Mon, 13 Mar 2023 10:03:52 GMT, Alan Bateman wrote: >> Joe Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> clean up tests; fix copy&paste error. > > src/java.xml/share/classes/javax/xml/catalog/CatalogFeatures.java line 183: > >>

Re: RFR: 8303530: Add system property for custom JAXP configuration file [v2]

2023-03-13 Thread Joe Wang
On Mon, 13 Mar 2023 10:01:21 GMT, Alan Bateman wrote: >> Joe Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> clean up tests; fix copy&paste error. > > src/java.xml/share/classes/javax/xml/catalog/CatalogFeatures.java line 171: > >>

Re: RFR: 8303530: Add system property for custom JAXP configuration file [v2]

2023-03-13 Thread Joe Wang
On Mon, 13 Mar 2023 09:58:51 GMT, Alan Bateman wrote: >> Joe Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> clean up tests; fix copy&paste error. > > src/java.xml/share/classes/javax/xml/XMLConstants.java line 247: > >> 245:

Re: RFR: 8303530: Add system property for custom JAXP configuration file [v2]

2023-03-13 Thread Alan Bateman
On Sat, 11 Mar 2023 05:34:39 GMT, Joe Wang wrote: >> Add a system property, jdk.xml.config.file, to return the path to a custom >> JAXP configuration file. The current configuration file, jaxp.properties, >> that the JDK supports will become the default configuration file. >> >> CSR: https://b

Re: RFR: 8303530: Add system property for custom JAXP configuration file [v2]

2023-03-13 Thread Alan Bateman
On Sat, 11 Mar 2023 05:34:39 GMT, Joe Wang wrote: >> Add a system property, jdk.xml.config.file, to return the path to a custom >> JAXP configuration file. The current configuration file, jaxp.properties, >> that the JDK supports will become the default configuration file. >> >> CSR: https://b

Re: RFR: 8303530: Add system property for custom JAXP configuration file [v2]

2023-03-13 Thread Alan Bateman
On Sat, 11 Mar 2023 05:34:39 GMT, Joe Wang wrote: >> Add a system property, jdk.xml.config.file, to return the path to a custom >> JAXP configuration file. The current configuration file, jaxp.properties, >> that the JDK supports will become the default configuration file. >> >> CSR: https://b

Re: RFR: 8303530: Add system property for custom JAXP configuration file [v2]

2023-03-13 Thread Alan Bateman
On Sat, 11 Mar 2023 05:34:39 GMT, Joe Wang wrote: >> Add a system property, jdk.xml.config.file, to return the path to a custom >> JAXP configuration file. The current configuration file, jaxp.properties, >> that the JDK supports will become the default configuration file. >> >> CSR: https://b

Re: RFR: 8303530: Add system property for custom JAXP configuration file [v2]

2023-03-10 Thread Joe Wang
> Add a system property, jdk.xml.config.file, to return the path to a custom > JAXP configuration file. The current configuration file, jaxp.properties, > that the JDK supports will become the default configuration file. > > CSR: https://bugs.openjdk.org/browse/JDK-8303531 > > Tests: XML SQE an

RFR: 8303530: Add system property for custom JAXP configuration file

2023-03-10 Thread Joe Wang
Add a system property, jdk.xml.config.file, to return the path to a custom JAXP configuration file. The current configuration file, jaxp.properties, that the JDK supports will become the default configuration file. CSR: https://bugs.openjdk.org/browse/JDK-8303531 Tests: XML SQE and JCK tests pa