> This patch adds checks in AbstractLinker to reject packed structs and structs
> with excess padding (e.g. unnamed bitfields), since both of those are
> currently not supported, and the ABI/spec seems too vague to base support on.
Jorn Vernee has updated the pull request with a new target base
On Thu, 20 Apr 2023 09:27:40 GMT, Maurizio Cimadamore
wrote:
>> Jorn Vernee has updated the pull request incrementally with four additional
>> commits since the last revision:
>>
>> - restrictions -> characteristics
>> - polish pt. 2
>> - polish wording
>> - review comments
>
> Looks good.
On Thu, 20 Apr 2023 01:12:44 GMT, Jorn Vernee wrote:
>> This patch adds checks in AbstractLinker to reject packed structs and
>> structs with excess padding (e.g. unnamed bitfields), since both of those
>> are currently not supported, and the ABI/spec seems too vague to base
>> support on.
>
>
On Thu, 20 Apr 2023 00:40:44 GMT, Jorn Vernee wrote:
>> Also, isn't it the case that, for structs, we want the size of the layout to
>> be a multiple of its alignment constraint?
>
> The third item in the list is for group size needing to be a multiple of the
> alignment constraint, the forth i
> This patch adds checks in AbstractLinker to reject packed structs and structs
> with excess padding (e.g. unnamed bitfields), since both of those are
> currently not supported, and the ABI/spec seems too vague to base support on.
Jorn Vernee has updated the pull request incrementally with four
On Tue, 18 Apr 2023 22:32:17 GMT, Maurizio Cimadamore
wrote:
>> Jorn Vernee has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains seven additional
>>
On Tue, 18 Apr 2023 22:26:03 GMT, Maurizio Cimadamore
wrote:
>> src/java.base/share/classes/java/lang/foreign/Linker.java line 202:
>>
>>> 200: * Due to limited ABI specification coverage, all the native linker
>>> implementations limit the function
>>> 201: * descriptors that they support t
On Tue, 18 Apr 2023 22:17:02 GMT, Maurizio Cimadamore
wrote:
>> Jorn Vernee has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains seven additional
>>
On Tue, 18 Apr 2023 13:45:57 GMT, Jorn Vernee wrote:
>> This patch adds checks in AbstractLinker to reject packed structs and
>> structs with excess padding (e.g. unnamed bitfields), since both of those
>> are currently not supported, and the ABI/spec seems too vague to base
>> support on.
>
>
On Tue, 18 Apr 2023 22:25:09 GMT, Maurizio Cimadamore
wrote:
>> Jorn Vernee has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains seven additional
>>
On Tue, 18 Apr 2023 13:45:57 GMT, Jorn Vernee wrote:
>> This patch adds checks in AbstractLinker to reject packed structs and
>> structs with excess padding (e.g. unnamed bitfields), since both of those
>> are currently not supported, and the ABI/spec seems too vague to base
>> support on.
>
>
On Tue, 18 Apr 2023 13:45:57 GMT, Jorn Vernee wrote:
>> This patch adds checks in AbstractLinker to reject packed structs and
>> structs with excess padding (e.g. unnamed bitfields), since both of those
>> are currently not supported, and the ABI/spec seems too vague to base
>> support on.
>
>
> This patch adds checks in AbstractLinker to reject packed structs and structs
> with excess padding (e.g. unnamed bitfields), since both of those are
> currently not supported, and the ABI/spec seems too vague to base support on.
Jorn Vernee has updated the pull request with a new target base
> This patch adds checks in AbstractLinker to reject packed structs and structs
> with excess padding (e.g. unnamed bitfields), since both of those are
> currently not supported, and the ABI/spec seems too vague to base support on.
Jorn Vernee has updated the pull request with a new target base
On Mon, 27 Mar 2023 14:51:28 GMT, Maurizio Cimadamore
wrote:
>> Jorn Vernee has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase.
>
> src/java.base/share/classes/java/lang/fore
On Tue, 28 Mar 2023 17:59:33 GMT, Jorn Vernee wrote:
>> This patch adds checks in AbstractLinker to reject packed structs and
>> structs with excess padding (e.g. unnamed bitfields), since both of those
>> are currently not supported, and the ABI/spec seems too vague to base
>> support on.
>
>
> This patch adds checks in AbstractLinker to reject packed structs and structs
> with excess padding (e.g. unnamed bitfields), since both of those are
> currently not supported, and the ABI/spec seems too vague to base support on.
Jorn Vernee has updated the pull request incrementally with one
> This patch adds checks in AbstractLinker to reject packed structs and structs
> with excess padding (e.g. unnamed bitfields), since both of those are
> currently not supported, and the ABI/spec seems too vague to base support on.
Jorn Vernee has updated the pull request with a new target base
On Thu, 23 Mar 2023 18:11:18 GMT, Jorn Vernee wrote:
> This patch adds checks in AbstractLinker to reject packed structs and structs
> with excess padding (e.g. unnamed bitfields), since both of those are
> currently not supported, and the ABI/spec seems too vague to base support on.
src/java.
This patch adds checks in AbstractLinker to reject packed structs and structs
with excess padding (e.g. unnamed bitfields), since both of those are currently
not supported, and the ABI/spec seems too vague to base support on.
-
Depends on: https://git.openjdk.org/jdk/pull/13161
Com
20 matches
Mail list logo