Re: RFR: 8301875: java.util.TimeZone.getSystemTimeZoneID uses C library default file mode

2025-01-31 Thread Naoto Sato
On Wed, 29 Jan 2025 20:42:30 GMT, Naoto Sato wrote: > Force opening "tzmappings" file in text mode. Confirmed the fix with customer > provided test case. Also replaced the file open function with the safer one. Thanks for the reviews! - PR Comment: https://git.openjdk.org/jdk/pull

Re: RFR: 8301875: java.util.TimeZone.getSystemTimeZoneID uses C library default file mode

2025-01-29 Thread Joe Wang
On Wed, 29 Jan 2025 20:42:30 GMT, Naoto Sato wrote: > Force opening "tzmappings" file in text mode. Confirmed the fix with customer > provided test case. Also replaced the file open function with the safer one. Marked as reviewed by joehw (Reviewer). - PR Review: https://git.openj

Re: RFR: 8301875: java.util.TimeZone.getSystemTimeZoneID uses C library default file mode

2025-01-29 Thread Justin Lu
On Wed, 29 Jan 2025 20:42:30 GMT, Naoto Sato wrote: > Force opening "tzmappings" file in text mode. Confirmed the fix with customer > provided test case. Also replaced the file open function with the safer one. Fix looks correct to force "text mode". Switch to `fopen_s` also looks good. --

RFR: 8301875: java.util.TimeZone.getSystemTimeZoneID uses C library default file mode

2025-01-29 Thread Naoto Sato
Force opening "tzmappings" file in text mode. Confirmed the fix with customer provided test case. Also replaced the file open function with the safer one. - Commit messages: - initial commit Changes: https://git.openjdk.org/jdk/pull/23356/files Webrev: https://webrevs.openjdk.org