Re: RFR: 8301627: System.exit and Runtime.exit debug logging [v4]

2023-02-16 Thread Roger Riggs
On Tue, 14 Feb 2023 19:02:52 GMT, Stuart Marks wrote: >> Roger Riggs has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Correct System.getLogger link > > src/java.base/share/classes/java/lang/Shutdown.java line 168: > >> 166:

Re: RFR: 8301627: System.exit and Runtime.exit debug logging [v4]

2023-02-16 Thread Roger Riggs
On Thu, 16 Feb 2023 16:52:14 GMT, Sean Mullan wrote: >> Roger Riggs has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Correct System.getLogger link > > src/java.base/share/classes/java/lang/Runtime.java line 160: > >> 158: * >> 159:

Re: RFR: 8301627: System.exit and Runtime.exit debug logging [v4]

2023-02-16 Thread Roger Riggs
On Tue, 14 Feb 2023 13:10:41 GMT, Daniel Fuchs wrote: >> Roger has updated this but it's still a comment on a non-public class. I >> think the main question here is whether there should be a note in the >> System.exit and Runtime.exit to document that these methods log? If not, >> will it be d

Re: RFR: 8301627: System.exit and Runtime.exit debug logging [v4]

2023-02-16 Thread Roger Riggs
On Mon, 13 Feb 2023 11:02:14 GMT, Daniel Fuchs wrote: >> test/jdk/java/lang/runtime/RuntimeExitLogTest.java line 89: >> >>> 87: } >>> 88: cmd.add(this.getClass().getName()); >>> 89: cmd.add(Integer.toString(status)); >> >> Another possibility for testing this is to launc

Re: RFR: 8301627: System.exit and Runtime.exit debug logging [v4]

2023-02-16 Thread Sean Mullan
On Tue, 14 Feb 2023 18:56:29 GMT, Roger Riggs wrote: >> It can be difficult to find the cause of calls to >> `java.lang.System.exit(status)` and `Runtime.exit(status)` because the Java >> runtime exits. >> The status value and stack trace are logged using the System Logger named >> `java.lang.

Re: RFR: 8301627: System.exit and Runtime.exit debug logging [v4]

2023-02-14 Thread Stuart Marks
On Tue, 14 Feb 2023 18:56:29 GMT, Roger Riggs wrote: >> It can be difficult to find the cause of calls to >> `java.lang.System.exit(status)` and `Runtime.exit(status)` because the Java >> runtime exits. >> The status value and stack trace are logged using the System Logger named >> `java.lang.

Re: RFR: 8301627: System.exit and Runtime.exit debug logging [v4]

2023-02-14 Thread Roger Riggs
> It can be difficult to find the cause of calls to > `java.lang.System.exit(status)` and `Runtime.exit(status)` because the Java > runtime exits. > The status value and stack trace are logged using the System Logger named > `java.lang.Runtime` with message level `System.Logger.Level.DEBUG`. Ro