Re: RFR: 8301578: Perform output outside synchronization in Module.class [v7]

2023-02-10 Thread Alan Bateman
On Fri, 10 Feb 2023 09:11:22 GMT, Per Minborg wrote: >> This PR proposed to reduce contention in synchronized methods mainly by >> doing I/O operations outside synch blocks. > > Per Minborg has updated the pull request incrementally with one additional > commit since the last revision: > > R

Re: RFR: 8301578: Perform output outside synchronization in Module.class [v7]

2023-02-10 Thread Per Minborg
> This PR proposed to reduce contention in synchronized methods mainly by doing > I/O operations outside synch blocks. Per Minborg has updated the pull request incrementally with one additional commit since the last revision: Remove comment and rename class - Changes: - all: h

Re: RFR: 8301578: Perform output outside synchronization in Module.class [v4]

2023-02-10 Thread Alan Bateman
On Thu, 9 Feb 2023 16:27:34 GMT, Per Minborg wrote: >> src/java.base/share/classes/java/lang/Module.java line 120: >> >>> 118: // memory semantics that preserves ordering and visibility across >>> threads. >>> 119: // >>> 120: // Used reflectively via Unsafe >> >> I assume L119-120

Re: RFR: 8301578: Perform output outside synchronization in Module.class [v6]

2023-02-10 Thread Alan Bateman
On Thu, 9 Feb 2023 16:46:08 GMT, Per Minborg wrote: >> This PR proposed to reduce contention in synchronized methods mainly by >> doing I/O operations outside synch blocks. > > Per Minborg has updated the pull request incrementally with one additional > commit since the last revision: > > Un

Re: RFR: 8301578: Perform output outside synchronization in Module.class [v6]

2023-02-09 Thread Per Minborg
> This PR proposed to reduce contention in synchronized methods mainly by doing > I/O operations outside synch blocks. Per Minborg has updated the pull request incrementally with one additional commit since the last revision: Undo more unintended edits - Changes: - all: https:

Re: RFR: 8301578: Perform output outside synchronization in Module.class [v5]

2023-02-09 Thread Per Minborg
> This PR proposed to reduce contention in synchronized methods mainly by doing > I/O operations outside synch blocks. Per Minborg has updated the pull request incrementally with two additional commits since the last revision: - Fix things from PR comments - Undo unintended changes -

Re: RFR: 8301578: Perform output outside synchronization in Module.class [v4]

2023-02-09 Thread Per Minborg
On Thu, 9 Feb 2023 15:19:38 GMT, Alan Bateman wrote: >> Per Minborg has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Use Unsafe instead of synchronized > > src/java.base/share/classes/java/lang/Module.java line 120: > >> 118: // memo

Re: RFR: 8301578: Perform output outside synchronization in Module.class [v4]

2023-02-09 Thread Alan Bateman
On Thu, 9 Feb 2023 15:05:13 GMT, Per Minborg wrote: >> This PR proposed to reduce contention in synchronized methods mainly by >> doing I/O operations outside synch blocks. > > Per Minborg has updated the pull request incrementally with one additional > commit since the last revision: > > Us

Re: RFR: 8301578: Perform output outside synchronization in Module.class [v3]

2023-02-09 Thread Per Minborg
On Wed, 1 Feb 2023 08:51:16 GMT, Per Minborg wrote: >> This PR proposed to reduce contention in synchronized methods mainly by >> doing I/O operations outside synch blocks. > > Per Minborg has updated the pull request incrementally with three additional > commits since the last revision: > >

Re: RFR: 8301578: Perform output outside synchronization in Module.class [v4]

2023-02-09 Thread Per Minborg
> This PR proposed to reduce contention in synchronized methods mainly by doing > I/O operations outside synch blocks. Per Minborg has updated the pull request incrementally with one additional commit since the last revision: Use Unsafe instead of synchronized - Changes: - all

Re: RFR: 8301578: Perform output outside synchronization in Module.class [v3]

2023-02-05 Thread ExE Boss
On Wed, 1 Feb 2023 08:51:16 GMT, Per Minborg wrote: >> This PR proposed to reduce contention in synchronized methods mainly by >> doing I/O operations outside synch blocks. > > Per Minborg has updated the pull request incrementally with three additional > commits since the last revision: > >

Re: RFR: 8301578: Perform output outside synchronization in Module.class [v3]

2023-02-05 Thread ExE Boss
On Wed, 1 Feb 2023 07:52:25 GMT, Per Minborg wrote: >> src/java.base/share/classes/java/lang/Module.java line 281: >> >>> 279: >>> 280: private static boolean isNativeAccessEnabled(Module target) { >>> 281: if (target.enableNativeAccess) >> >> @minborg It'd seem a bit easier to imp

Re: RFR: 8301578: Perform output outside synchronization in Module.class [v3]

2023-02-01 Thread Per Minborg
> This PR proposed to reduce contention in synchronized methods mainly by doing > I/O operations outside synch blocks. Per Minborg has updated the pull request incrementally with three additional commits since the last revision: - Revert benchmark change - Fix typo - Use another type of comm

Re: RFR: 8301578: Perform output outside synchronization in Module.class [v2]

2023-02-01 Thread Per Minborg
> This PR proposed to reduce contention in synchronized methods mainly by doing > I/O operations outside synch blocks. Per Minborg has updated the pull request incrementally with two additional commits since the last revision: - Update after comments - Remove warning - Changes:

Re: RFR: 8301578: Perform output outside synchronization in Module.class

2023-02-01 Thread Per Minborg
On Wed, 25 Jan 2023 12:26:26 GMT, Per Minborg wrote: > This PR proposed to reduce contention in synchronized methods mainly by doing > I/O operations outside synch blocks. Let me take a step back here and explain the reason why I think this PR is worth looking at. Firstly, I think the argument