On Tue, 7 Feb 2023 09:38:13 GMT, Daniel Jeliński wrote:
>> Please review this patch that reduces the socket timeout used in
>> HandshakeTimeout test to its minimum value of 1 millisecond.
>>
>> This change makes the test complete 10 seconds faster; before this change it
>> took 5 seconds for t
On Tue, 7 Feb 2023 09:38:13 GMT, Daniel Jeliński wrote:
>> Please review this patch that reduces the socket timeout used in
>> HandshakeTimeout test to its minimum value of 1 millisecond.
>>
>> This change makes the test complete 10 seconds faster; before this change it
>> took 5 seconds for t
On Tue, 7 Feb 2023 09:38:13 GMT, Daniel Jeliński wrote:
>> Please review this patch that reduces the socket timeout used in
>> HandshakeTimeout test to its minimum value of 1 millisecond.
>>
>> This change makes the test complete 10 seconds faster; before this change it
>> took 5 seconds for t
> Please review this patch that reduces the socket timeout used in
> HandshakeTimeout test to its minimum value of 1 millisecond.
>
> This change makes the test complete 10 seconds faster; before this change it
> took 5 seconds for the handshake to timeout, and the test attempts 2
> handshakes.
On Mon, 30 Jan 2023 11:06:05 GMT, Daniel Jeliński wrote:
> Please review this patch that reduces the socket timeout used in
> HandshakeTimeout test to its minimum value of 1 millisecond.
>
> This change makes the test complete 10 seconds faster; before this change it
> took 5 seconds for the h
On Mon, 30 Jan 2023 14:08:49 GMT, Daniel Jeliński wrote:
>> test/jdk/java/rmi/transport/handshakeTimeout/HandshakeTimeout.java line 59:
>>
>>> 57: public static void main(String[] args) throws Exception {
>>> 58:
>>> 59: System.setProperty("sun.rmi.transport.tcp.handshakeTimeout",
On Mon, 30 Jan 2023 12:54:34 GMT, Vyom Tewari wrote:
> I can see that this test uses "TIMEOUT" down in test
Right, this is why I didn't remove the TIMEOUT constant
> i will suggest you to reduce the "TIMEOUT" constant instead of hard coding it
> to "1" second.
I can't; this would make the test
On Mon, 30 Jan 2023 11:06:05 GMT, Daniel Jeliński wrote:
> Please review this patch that reduces the socket timeout used in
> HandshakeTimeout test to its minimum value of 1 millisecond.
>
> This change makes the test complete 10 seconds faster; before this change it
> took 5 seconds for the h
Please review this patch that reduces the socket timeout used in
HandshakeTimeout test to its minimum value of 1 millisecond.
This change makes the test complete 10 seconds faster; before this change it
took 5 seconds for the handshake to timeout, and the test attempts 2 handshakes.
The change
