Re: RFR: 8300236: Use VarHandle access in Data(Input | Output)Stream classes [v8]

2023-01-25 Thread altrisi
On Tue, 24 Jan 2023 12:44:17 GMT, Per Minborg wrote: >> This PR proposes using a performance optimization using a new supported API >> for operations similar to those found in `java.io.Bits` > > Per Minborg has updated the pull request incrementally with one additional > commit since the last r

Re: RFR: 8300236: Use VarHandle access in Data(Input | Output)Stream classes [v8]

2023-01-24 Thread Roger Riggs
On Tue, 24 Jan 2023 12:44:17 GMT, Per Minborg wrote: >> This PR proposes using a performance optimization using a new supported API >> for operations similar to those found in `java.io.Bits` > > Per Minborg has updated the pull request incrementally with one additional > commit since the last r

Re: RFR: 8300236: Use VarHandle access in Data(Input | Output)Stream classes [v8]

2023-01-24 Thread Alan Bateman
On Tue, 24 Jan 2023 12:44:17 GMT, Per Minborg wrote: >> This PR proposes using a performance optimization using a new supported API >> for operations similar to those found in `java.io.Bits` > > Per Minborg has updated the pull request incrementally with one additional > commit since the last r

Re: RFR: 8300236: Use VarHandle access in Data(Input | Output)Stream classes [v8]

2023-01-24 Thread Per Minborg
> This PR proposes using a performance optimization using a new supported API > for operations similar to those found in `java.io.Bits` Per Minborg has updated the pull request incrementally with one additional commit since the last revision: Update RAF - Changes: - all: https

Re: RFR: 8300236: Use VarHandle access in Data(Input | Output)Stream classes [v7]

2023-01-24 Thread Per Minborg
> This PR proposes using a performance optimization using a new supported API > for operations similar to those found in `java.io.Bits` Per Minborg has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 18 commits: - Merge master and fix R

Re: RFR: 8300236: Use VarHandle access in Data(Input | Output)Stream classes [v6]

2023-01-24 Thread Per Minborg
> This PR proposes using a performance optimization using a new supported API > for operations similar to those found in `java.io.Bits` Per Minborg has updated the pull request incrementally with one additional commit since the last revision: Remove redundant @throws documentation --

Re: RFR: 8300236: Use VarHandle access in Data(Input | Output)Stream classes [v5]

2023-01-24 Thread Per Minborg
On Tue, 24 Jan 2023 10:28:42 GMT, Alan Bateman wrote: >> Per Minborg has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove methods with implicit zero offset > > src/java.base/share/classes/java/io/DataInputStream.java line 59: > >> 57:

Re: RFR: 8300236: Use VarHandle access in Data(Input | Output)Stream classes [v5]

2023-01-24 Thread Alan Bateman
On Mon, 23 Jan 2023 12:38:24 GMT, Per Minborg wrote: >> This PR proposes using a performance optimization using a new supported API >> for operations similar to those found in `java.io.Bits` > > Per Minborg has updated the pull request incrementally with one additional > commit since the last r

Re: RFR: 8300236: Use VarHandle access in Data(Input | Output)Stream classes [v5]

2023-01-23 Thread Per Minborg
> This PR proposes using a performance optimization using a new supported API > for operations similar to those found in `java.io.Bits` Per Minborg has updated the pull request incrementally with one additional commit since the last revision: Remove methods with implicit zero offset

Re: RFR: 8300236: Use VarHandle access in Data(Input | Output)Stream classes [v4]

2023-01-23 Thread Per Minborg
On Mon, 23 Jan 2023 10:15:55 GMT, Per Minborg wrote: >> Very good question. I will take a look at it. A fixed value is inserted in >> the original var handle so potentially it might improve performance that way >> too. > > No significant performance increase: > > > 2-parameters > Benchmark

Re: RFR: 8300236: Use VarHandle access in Data(Input | Output)Stream classes [v4]

2023-01-23 Thread Per Minborg
On Mon, 23 Jan 2023 08:11:15 GMT, Per Minborg wrote: >> src/java.base/share/classes/jdk/internal/util/access/ByteArrayAccess.java >> line 614: >> >>> 612: /* >>> 613: * Methods for packing primitive values into byte arrays starting >>> at offset zero. >>> 614: */ >> >> Is the on

Re: RFR: 8300236: Use VarHandle access in Data(Input | Output)Stream classes [v4]

2023-01-23 Thread Per Minborg
> This PR proposes using a performance optimization using a new supported API > for operations similar to those found in `java.io.Bits` Per Minborg has updated the pull request incrementally with one additional commit since the last revision: Add benchmark - Changes: - all: ht

Re: RFR: 8300236: Use VarHandle access in Data(Input | Output)Stream classes [v3]

2023-01-23 Thread Per Minborg
> This PR proposes using a performance optimization using a new supported API > for operations similar to those found in `java.io.Bits` Per Minborg has updated the pull request incrementally with one additional commit since the last revision: Rename and move - Changes: - all:

Re: RFR: 8300236: Use VarHandle access in Data(Input | Output)Stream classes [v2]

2023-01-23 Thread Per Minborg
> This PR proposes using a performance optimization using a new supported API > for operations similar to those found in `java.io.Bits` Per Minborg has updated the pull request incrementally with one additional commit since the last revision: Improve doc and fix typo - Changes:

Re: RFR: 8300236: Use VarHandle access in Data(Input | Output)Stream classes [v2]

2023-01-23 Thread Per Minborg
On Fri, 20 Jan 2023 18:21:59 GMT, Roger Riggs wrote: >> Per Minborg has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Improve doc and fix typo > > src/java.base/share/classes/jdk/internal/util/access/ByteArrayAccess.java > line 614: > >>

Re: RFR: 8300236: Use VarHandle access in Data(Input | Output)Stream classes

2023-01-23 Thread Alan Bateman
On Mon, 23 Jan 2023 07:56:08 GMT, Per Minborg wrote: >> src/java.base/share/classes/jdk/internal/util/access/ByteArrayAccess.java >> line 26: >> >>> 24: */ >>> 25: >>> 26: package jdk.internal.util.access; >> >> This is pretty deep; I'd drop the final "access". The package name >> `jdk.inte

Re: RFR: 8300236: Use VarHandle access in Data(Input | Output)Stream classes

2023-01-23 Thread Per Minborg
On Fri, 20 Jan 2023 16:36:23 GMT, Roger Riggs wrote: >> This PR proposes using a performance optimization using a new supported API >> for operations similar to those found in `java.io.Bits` > > src/java.base/share/classes/jdk/internal/util/access/ByteArrayAccess.java > line 26: > >> 24: */ >

Re: RFR: 8300236: Use VarHandle access in Data(Input | Output)Stream classes

2023-01-20 Thread Roger Riggs
On Wed, 18 Jan 2023 16:34:57 GMT, Per Minborg wrote: > This PR proposes using a performance optimization using a new supported API > for operations similar to those found in `java.io.Bits` src/java.base/share/classes/java/io/ObjectStreamClass.java line 2486: > 2484: ); > 2485:

Re: RFR: 8300236: Use VarHandle access in Data(Input | Output)Stream classes

2023-01-19 Thread Per Minborg
On Wed, 18 Jan 2023 16:34:57 GMT, Per Minborg wrote: > This PR proposes using a performance optimization using a new supported API > for operations similar to those found in `java.io.Bits` Performance looks promising for serialization (values in us/operation):   | Java 20 | Java 21 | Improve

Re: RFR: 8300236: Use VarHandle access in Data(Input | Output)Stream classes

2023-01-19 Thread Roger Riggs
On Wed, 18 Jan 2023 16:34:57 GMT, Per Minborg wrote: > This PR proposes using a performance optimization using a new supported API > for operations similar to those found in `java.io.Bits` Some comments: src/java.base/share/classes/jdk/internal/util/Bits.java line 43: > 41: } > 42: > 43:

RFR: 8300236: Use VarHandle access in Data(Input | Output)Stream classes

2023-01-19 Thread Per Minborg
This PR proposes using a performance optimization using a new supported API for operations similar to those found in `java.io.Bits` - Commit messages: - Remove white spaces - Remove white space - Fix jcheck issues - Update copyright years - Reformat javadoc - Prepare for review