Re: RFR: 8300169: Build failure with clang-15

2023-01-17 Thread Jie Fu
On Tue, 17 Jan 2023 18:12:44 GMT, Phil Race wrote: > client changes are OK by me. Thanks @prrace . - PR: https://git.openjdk.org/jdk/pull/12005

Re: RFR: 8300169: Build failure with clang-15

2023-01-17 Thread Jie Fu
On Sat, 14 Jan 2023 14:28:32 GMT, Jie Fu wrote: > Hi all, > > Please review the fix for the build failure with clang-15. > > 1. -Wbitwise-instead-of-logical > >1) src/hotspot/share/oops/generateOopMap.cpp <--- fixed the > warning >2) src/hotspot/share/runtime/notificationThre

Re: RFR: 8300169: Build failure with clang-15

2023-01-17 Thread Phil Race
On Sat, 14 Jan 2023 14:28:32 GMT, Jie Fu wrote: > Hi all, > > Please review the fix for the build failure with clang-15. > > 1. -Wbitwise-instead-of-logical > >1) src/hotspot/share/oops/generateOopMap.cpp <--- fixed the > warning >2) src/hotspot/share/runtime/notificationThre

Re: RFR: 8300169: Build failure with clang-15

2023-01-17 Thread Phil Race
On Tue, 17 Jan 2023 13:35:25 GMT, Kevin Rushforth wrote: >>> Normally, such changes in third-party libraries need to be done upstream, >>> and not locally. @prrace can confirm. >> >> Thanks @kevinrushforth for your review. >> >> Yes, it had been fixed in the upstream and I just follow it. >> P

Re: RFR: 8300169: Build failure with clang-15

2023-01-17 Thread Alan Bateman
On Tue, 17 Jan 2023 13:33:06 GMT, Kevin Rushforth wrote: >> Hi all, >> >> Please review the fix for the build failure with clang-15. >> >> 1. -Wbitwise-instead-of-logical >> >>1) src/hotspot/share/oops/generateOopMap.cpp <--- fixed the >> warning >>2) src/hotspot/share/runtim

Re: RFR: 8300169: Build failure with clang-15

2023-01-17 Thread Kevin Rushforth
On Sun, 15 Jan 2023 01:56:06 GMT, Jie Fu wrote: >> src/java.desktop/share/native/libharfbuzz/hb-meta.hh line 191: >> >>> 189: #define hb_int_max(T) hb_int_max::value >>> 190: >>> 191: #if defined(__GNUC__) && __GNUC__ < 5 && !defined(__clang__) >> >> Normally, such changes in third-party libra

Re: RFR: 8300169: Build failure with clang-15

2023-01-17 Thread Kevin Rushforth
On Sat, 14 Jan 2023 14:28:32 GMT, Jie Fu wrote: > Hi all, > > Please review the fix for the build failure with clang-15. > > 1. -Wbitwise-instead-of-logical > >1) src/hotspot/share/oops/generateOopMap.cpp <--- fixed the > warning >2) src/hotspot/share/runtime/notificationThre

Re: RFR: 8300169: Build failure with clang-15

2023-01-17 Thread Jie Fu
On Sat, 14 Jan 2023 14:28:32 GMT, Jie Fu wrote: > Hi all, > > Please review the fix for the build failure with clang-15. > > 1. -Wbitwise-instead-of-logical > >1) src/hotspot/share/oops/generateOopMap.cpp <--- fixed the > warning >2) src/hotspot/share/runtime/notificationThre

Re: RFR: 8300169: Build failure with clang-15

2023-01-16 Thread Jie Fu
On Tue, 17 Jan 2023 04:29:31 GMT, David Holmes wrote: > Hotspot changes are good. Thanks @dholmes-ora . - PR: https://git.openjdk.org/jdk/pull/12005

Re: RFR: 8300169: Build failure with clang-15

2023-01-16 Thread David Holmes
On Sat, 14 Jan 2023 14:28:32 GMT, Jie Fu wrote: > Hi all, > > Please review the fix for the build failure with clang-15. > > 1. -Wbitwise-instead-of-logical > >1) src/hotspot/share/oops/generateOopMap.cpp <--- fixed the > warning >2) src/hotspot/share/runtime/notificationThre

Re: RFR: 8300169: Build failure with clang-15

2023-01-16 Thread Alan Bateman
On Mon, 16 Jan 2023 08:56:13 GMT, Jie Fu wrote: > Mainly caused by files under `src/java.base/share/native/libzip/zlib/`. I'm > not sure if there is already a bug report to the upstream. Maybe this one: https://github.com/madler/zlib/issues/633 - PR: https://git.openjdk.org/jdk/pu

Re: RFR: 8300169: Build failure with clang-15

2023-01-16 Thread Jie Fu
On Mon, 16 Jan 2023 08:51:34 GMT, Jie Fu wrote: > For the libzip issues, are these in the native methods or when compiling the > zlib code, just wondering if there are bug reports for upstream there too. Mainly caused by files under `src/java.base/share/native/libzip/zlib/`. I'm not sure if the

Re: RFR: 8300169: Build failure with clang-15

2023-01-16 Thread Jie Fu
On Mon, 16 Jan 2023 08:21:47 GMT, Alan Bateman wrote: > Is there a list of the issues building libjli? I don't see the in the PR or > the JBS issue. For the libzip issues, are these in the native methods or when > compiling the zlib code, just wondering if there are bug reports for upstream >

Re: RFR: 8300169: Build failure with clang-15

2023-01-16 Thread Alan Bateman
On Sat, 14 Jan 2023 14:28:32 GMT, Jie Fu wrote: > It occurred while building LIBJLI, LIBZIP and LIBSPLASHSCREEN. Is there a list of the issues building libjli? I don't see the in the PR or the JBS issue. For the libzip issues, are these in the native methods or when compiling the zlib code, ju

Re: RFR: 8300169: Build failure with clang-15

2023-01-14 Thread Jie Fu
On Sat, 14 Jan 2023 15:03:42 GMT, Kevin Rushforth wrote: > Normally, such changes in third-party libraries need to be done upstream, and > not locally. @prrace can confirm. Thanks @kevinrushforth for your review. Yes, it had been fixed in the upstream and I just follow it. Please see https://g

Re: RFR: 8300169: Build failure with clang-15

2023-01-14 Thread Kevin Rushforth
On Sat, 14 Jan 2023 14:28:32 GMT, Jie Fu wrote: > Hi all, > > Please review the fix for the build failure with clang-15. > > 1. -Wbitwise-instead-of-logical > >1) src/hotspot/share/oops/generateOopMap.cpp <--- fixed the > warning >2) src/hotspot/share/runtime/notificationThre

RFR: 8300169: Build failure with clang-15

2023-01-14 Thread Jie Fu
Hi all, Please review the fix for the build failure with clang-15. 1. -Wbitwise-instead-of-logical 1) src/hotspot/share/oops/generateOopMap.cpp <--- fixed the warning 2) src/hotspot/share/runtime/notificationThread.cpp <--- keep the code and disable warnings 3) src/hotspot/s