Re: RFR: 8299864: ZipFileStore#supportsFileAttributeView(String) doesn't throw NPE [v4]

2023-01-11 Thread Lance Andersen
On Wed, 11 Jan 2023 08:43:36 GMT, Per Minborg wrote: >> This PR proposes to add null-checking for some parameter arguments in >> `ZipFileStore`. > > Per Minborg has updated the pull request incrementally with one additional > commit since the last revision: > > Fix typo and add bug ref Than

Re: RFR: 8299864: ZipFileStore#supportsFileAttributeView(String) doesn't throw NPE [v4]

2023-01-11 Thread Lance Andersen
On Wed, 11 Jan 2023 08:59:53 GMT, Alan Bateman wrote: > This is a implementation class in a non-exported package so it's okay. Fair point - PR: https://git.openjdk.org/jdk/pull/11926

Re: RFR: 8299864: ZipFileStore#supportsFileAttributeView(String) doesn't throw NPE [v4]

2023-01-11 Thread Alan Bateman
On Wed, 11 Jan 2023 08:30:01 GMT, Per Minborg wrote: >> src/jdk.zipfs/share/classes/jdk/nio/zipfs/ZipFileStore.java line 43: >> >>> 41: * @author Xueming Shen, Rajendra Gutupalli, Jaya Hangal >>> 42: */ >>> 43: final class ZipFileStore extends FileStore { >> >> This should be OK but might sug

Re: RFR: 8299864: ZipFileStore#supportsFileAttributeView(String) doesn't throw NPE [v4]

2023-01-11 Thread Per Minborg
> This PR proposes to add null-checking for some parameter arguments in > `ZipFileStore`. Per Minborg has updated the pull request incrementally with one additional commit since the last revision: Fix typo and add bug ref - Changes: - all: https://git.openjdk.org/jdk/pull/1192