On Wed, 11 Jan 2023 08:43:36 GMT, Per Minborg wrote:
>> This PR proposes to add null-checking for some parameter arguments in
>> `ZipFileStore`.
>
> Per Minborg has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fix typo and add bug ref
Than
On Wed, 11 Jan 2023 08:59:53 GMT, Alan Bateman wrote:
> This is a implementation class in a non-exported package so it's okay.
Fair point
-
PR: https://git.openjdk.org/jdk/pull/11926
On Wed, 11 Jan 2023 08:30:01 GMT, Per Minborg wrote:
>> src/jdk.zipfs/share/classes/jdk/nio/zipfs/ZipFileStore.java line 43:
>>
>>> 41: * @author Xueming Shen, Rajendra Gutupalli, Jaya Hangal
>>> 42: */
>>> 43: final class ZipFileStore extends FileStore {
>>
>> This should be OK but might sug
> This PR proposes to add null-checking for some parameter arguments in
> `ZipFileStore`.
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Fix typo and add bug ref
-
Changes:
- all: https://git.openjdk.org/jdk/pull/1192
> This PR proposes to add null-checking for some parameter arguments in
> `ZipFileStore`.
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Add test method comment
-
Changes:
- all: https://git.openjdk.org/jdk/pull/11926
On Tue, 10 Jan 2023 17:29:56 GMT, Lance Andersen wrote:
> This should be OK but might suggest adding a release note
Do we need to do that for a package-private class? Maybe for internal use?
-
PR: https://git.openjdk.org/jdk/pull/11926
> This PR proposes to add null-checking for some parameter arguments in
> `ZipFileStore`.
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Rename and improve NPE testing
-
Changes:
- all: https://git.openjdk.org/jdk/pul
On Tue, 10 Jan 2023 15:26:05 GMT, Per Minborg wrote:
> This PR proposes to add null-checking for some parameter arguments in
> `ZipFileStore`.
Thanks for taking this on Per.
I think we also need to add a test for getAttribute() and
getFileStoreAttributeView() as I do not see it being tested
This PR proposes to add null-checking for some parameter arguments in
`ZipFileStore`.
-
Commit messages:
- Check null invariants
Changes: https://git.openjdk.org/jdk/pull/11926/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=11926&range=00
Issue: https://bugs.openjdk.org/
