On Fri, 28 Apr 2023 11:18:56 GMT, Amit Kumar wrote:
>> DeInflate.java test fails on s390x platform because size for out1 array
>> which is responsible for storing the compressed data is insufficient. And
>> being unable to write whole compressed data on array, on s390 whole data
>> can't be re
On Fri, 28 Apr 2023 11:18:56 GMT, Amit Kumar wrote:
>> DeInflate.java test fails on s390x platform because size for out1 array
>> which is responsible for storing the compressed data is insufficient. And
>> being unable to write whole compressed data on array, on s390 whole data
>> can't be re
On Fri, 28 Apr 2023 11:18:56 GMT, Amit Kumar wrote:
>> DeInflate.java test fails on s390x platform because size for out1 array
>> which is responsible for storing the compressed data is insufficient. And
>> being unable to write whole compressed data on array, on s390 whole data
>> can't be re
> DeInflate.java test fails on s390x platform because size for out1 array which
> is responsible for storing the compressed data is insufficient. And being
> unable to write whole compressed data on array, on s390 whole data can't be
> recovered after compression. This PR updates the check metho
On Fri, 28 Apr 2023 10:42:32 GMT, Amit Kumar wrote:
>> DeInflate.java test fails on s390x platform because size for out1 array
>> which is responsible for storing the compressed data is insufficient. And
>> being unable to write whole compressed data on array, on s390 whole data
>> can't be re
> DeInflate.java test fails on s390x platform because size for out1 array which
> is responsible for storing the compressed data is insufficient. And being
> unable to write whole compressed data on array, on s390 whole data can't be
> recovered after compression. This PR updates the check metho
On Fri, 28 Apr 2023 09:58:59 GMT, Amit Kumar wrote:
>> DeInflate.java test fails on s390x platform because size for out1 array
>> which is responsible for storing the compressed data is insufficient. And
>> being unable to write whole compressed data on array, on s390 whole data
>> can't be re
On Fri, 28 Apr 2023 09:33:03 GMT, Volker Simonis wrote:
>> test/jdk/java/util/zip/DeInflate.java line 164:
>>
>>> 162: out2 = baos.toByteArray();
>>> 163: if (n != len ||
>>> 164: !Arrays.equals(in, 0, len, out2, 0, len)) ||
>>
>> There's a `)` too much.
On Fri, 28 Apr 2023 09:26:52 GMT, Volker Simonis wrote:
>> Amit Kumar has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> suggestion from @simonis
>
> test/jdk/java/util/zip/DeInflate.java line 164:
>
>> 162: out2 = baos.toByteA
On Fri, 28 Apr 2023 09:23:59 GMT, Amit Kumar wrote:
>> DeInflate.java test fails on s390x platform because size for out1 array
>> which is responsible for storing the compressed data is insufficient. And
>> being unable to write whole compressed data on array, on s390 whole data
>> can't be re
> DeInflate.java test fails on s390x platform because size for out1 array which
> is responsible for storing the compressed data is insufficient. And being
> unable to write whole compressed data on array, on s390 whole data can't be
> recovered after compression. This PR updates the check metho
On Fri, 28 Apr 2023 09:08:18 GMT, Amit Kumar wrote:
>> DeInflate.java test fails on s390x platform because size for out1 array
>> which is responsible for storing the compressed data is insufficient. And
>> being unable to write whole compressed data on array, on s390 whole data
>> can't be re
> DeInflate.java test fails on s390x platform because size for out1 array which
> is responsible for storing the compressed data is insufficient. And being
> unable to write whole compressed data on array, on s390 whole data can't be
> recovered after compression. This PR updates the check metho
On Fri, 28 Apr 2023 08:31:05 GMT, Volker Simonis wrote:
>> Amit Kumar has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> changes request by @turbanoff
>
> test/jdk/java/util/zip/DeInflate.java line 164:
>
>> 162: out2 = baos.to
On Thu, 27 Apr 2023 17:05:24 GMT, Amit Kumar wrote:
>> DeInflate.java test fails on s390x platform because size for out1 array
>> which is responsible for storing the compressed data is insufficient. And
>> being unable to write whole compressed data on array, on s390 whole data
>> can't be re
On Thu, 27 Apr 2023 17:05:24 GMT, Amit Kumar wrote:
>> DeInflate.java test fails on s390x platform because size for out1 array
>> which is responsible for storing the compressed data is insufficient. And
>> being unable to write whole compressed data on array, on s390 whole data
>> can't be re
On Thu, 27 Apr 2023 01:04:44 GMT, Jaikiran Pai wrote:
>> Amit Kumar has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> removes out1,out2 parameters
>
> Hello Lance,
>
>> Jai, have you run this acrossed all of our Mach5 platforms?
>
> Yes
> DeInflate.java test fails on s390x platform because size for out1 array which
> is responsible for storing the compressed data is insufficient. And being
> unable to write whole compressed data on array, on s390 whole data can't be
> recovered after compression. This PR updates the check metho
On Thu, 27 Apr 2023 16:08:10 GMT, Andrey Turbanov wrote:
>> Amit Kumar has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> comment suggestion from @jaikiran
>
> test/jdk/java/util/zip/DeInflate.java line 146:
>
>> 144: def.finish();
On Thu, 27 Apr 2023 07:24:24 GMT, Amit Kumar wrote:
>> DeInflate.java test fails on s390x platform because size for out1 array
>> which is responsible for storing the compressed data is insufficient. And
>> being unable to write whole compressed data on array, on s390 whole data
>> can't be re
On Thu, 27 Apr 2023 06:43:00 GMT, Jaikiran Pai wrote:
>> Thanks for pointing it out. Please take a look at the latest modifications.
>
> The latest code changes look OK to me. I've added a comment about the test
> method comment.
Tests continue to pass on mach5 with these latest changes.
-
> DeInflate.java test fails on s390x platform because size for out1 array which
> is responsible for storing the compressed data is insufficient. And being
> unable to write whole compressed data on array, on s390 whole data can't be
> recovered after compression. This PR updates the check metho
On Thu, 27 Apr 2023 06:42:08 GMT, Jaikiran Pai wrote:
>> Amit Kumar has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> comments from Lance
>
> test/jdk/java/util/zip/DeInflate.java line 124:
>
>> 122: * This method checks if a given D
On Thu, 27 Apr 2023 03:25:53 GMT, Amit Kumar wrote:
>> DeInflate.java test fails on s390x platform because size for out1 array
>> which is responsible for storing the compressed data is insufficient. And
>> being unable to write whole compressed data on array, on s390 whole data
>> can't be re
On Thu, 27 Apr 2023 03:25:53 GMT, Amit Kumar wrote:
>> DeInflate.java test fails on s390x platform because size for out1 array
>> which is responsible for storing the compressed data is insufficient. And
>> being unable to write whole compressed data on array, on s390 whole data
>> can't be re
On Thu, 27 Apr 2023 03:17:25 GMT, Amit Kumar wrote:
>> test/jdk/java/util/zip/DeInflate.java line 129:
>>
>>> 127: int m = 0;
>>> 128:
>>> 129: ByteArrayOutputStream baos = new ByteArrayOutputStream(len);
>>
>> Is there a reason a try-with-resources is not being used?
>
> Thank
> DeInflate.java test fails on s390x platform because size for out1 array which
> is responsible for storing the compressed data is insufficient. And being
> unable to write whole compressed data on array, on s390 whole data can't be
> recovered after compression. This PR updates the check metho
On Thu, 27 Apr 2023 01:04:44 GMT, Jaikiran Pai wrote:
>> Amit Kumar has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> removes out1,out2 parameters
>
> Hello Lance,
>
>> Jai, have you run this acrossed all of our Mach5 platforms?
>
> Yes
On Wed, 26 Apr 2023 20:29:41 GMT, Lance Andersen wrote:
>> Amit Kumar has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> removes out1,out2 parameters
>
> test/jdk/java/util/zip/DeInflate.java line 129:
>
>> 127: int m = 0;
>> 128:
On Thu, 30 Mar 2023 03:06:51 GMT, Amit Kumar wrote:
>> DeInflate.java test fails on s390x platform because size for out1 array
>> which is responsible for storing the compressed data is insufficient. And
>> being unable to write whole compressed data on array, on s390 whole data
>> can't be re
On Thu, 30 Mar 2023 03:06:51 GMT, Amit Kumar wrote:
>> DeInflate.java test fails on s390x platform because size for out1 array
>> which is responsible for storing the compressed data is insufficient. And
>> being unable to write whole compressed data on array, on s390 whole data
>> can't be re
On Thu, 30 Mar 2023 03:06:51 GMT, Amit Kumar wrote:
>> DeInflate.java test fails on s390x platform because size for out1 array
>> which is responsible for storing the compressed data is insufficient. And
>> being unable to write whole compressed data on array, on s390 whole data
>> can't be re
On Wed, 26 Apr 2023 10:53:36 GMT, Jaikiran Pai wrote:
> These changes look fine to me.
Thanks @jaikiran for review and explanation. I'll update the PR description 🙃.
BTW these are not hotspot changes, So do we need 2 Reviewer for these as well ?
-
PR Comment: https://git.openjdk.
On Thu, 30 Mar 2023 03:06:51 GMT, Amit Kumar wrote:
>> DeInflate.java test fails on s390x platform because size for out1 array
>> which is responsible for storing the compressed data is insufficient. And
>> being unable to write whole compressed data on array, on s390 whole data
>> can't be re
On Tue, 7 Mar 2023 05:57:34 GMT, Jaikiran Pai wrote:
>>> Finally, are you or someone in your team, in contact with the author(s) of
>>> the custom zlib implementation
>>> [iii-i/zlib@1132034](https://github.com/iii-i/zlib/commit/113203437eda67261848b14b6c80a33ff7e33d34)?
>>> Would you be able
On Mon, 6 Mar 2023 11:07:26 GMT, Jaikiran Pai wrote:
>Now coming to this proposed patch, now that you are using local
>ByteArrayOutputStream(s) for the deflate/inflate part in this check() method,
>I think the out1 and out2 should no longer be needed in this method and thus
>the method signatu
> DeInflate.java test fails on s390x platform because size for out1 array which
> is responsible for storing the compressed data is insufficient. And being
> unable to write whole compressed data on array, on s390 whole data can't be
> recovered after compression. So this fix increase Array size
On Mon, 6 Mar 2023 13:10:57 GMT, Ilya Leoshkevich wrote:
> Here are some benchmarking results:
> https://github.com/iii-i/zlib-ng/wiki/Performance-with-dfltcc-patch-applied-and-dfltcc-support-built-on-dfltcc-enabled-machine.
> The interesting data is in column `compressed_size` where `level` is
On Mon, 6 Mar 2023 13:10:57 GMT, Ilya Leoshkevich wrote:
> P.S. Here we are compressing random data, if I read the testcase correctly
> (rnd.nextBytes(dataIn);),
Yes, you read it right.
-
PR: https://git.openjdk.org/jdk/pull/12283
On Thu, 2 Feb 2023 08:27:55 GMT, Amit Kumar wrote:
>> DeInflate.java test fails on s390x platform because size for out1 array
>> which is responsible for storing the compressed data is insufficient. And
>> being unable to write whole compressed data on array, on s390 whole data
>> can't be rec
On Mon, 6 Mar 2023 13:10:57 GMT, Ilya Leoshkevich wrote:
>> Amit Kumar has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> change acc to Alan comments
>
>> Finally, are you or someone in your team, in contact with the author(s) of
>> the cu
On Thu, 2 Feb 2023 08:27:55 GMT, Amit Kumar wrote:
>> DeInflate.java test fails on s390x platform because size for out1 array
>> which is responsible for storing the compressed data is insufficient. And
>> being unable to write whole compressed data on array, on s390 whole data
>> can't be rec
On Thu, 2 Feb 2023 08:27:55 GMT, Amit Kumar wrote:
>> DeInflate.java test fails on s390x platform because size for out1 array
>> which is responsible for storing the compressed data is insufficient. And
>> being unable to write whole compressed data on array, on s390 whole data
>> can't be rec
On Thu, 2 Feb 2023 08:27:55 GMT, Amit Kumar wrote:
>> DeInflate.java test fails on s390x platform because size for out1 array
>> which is responsible for storing the compressed data is insufficient. And
>> being unable to write whole compressed data on array, on s390 whole data
>> can't be rec
On Thu, 2 Feb 2023 08:27:55 GMT, Amit Kumar wrote:
>> DeInflate.java test fails on s390x platform because size for out1 array
>> which is responsible for storing the compressed data is insufficient. And
>> being unable to write whole compressed data on array, on s390 whole data
>> can't be rec
On Thu, 2 Feb 2023 08:27:55 GMT, Amit Kumar wrote:
>> DeInflate.java test fails on s390x platform because size for out1 array
>> which is responsible for storing the compressed data is insufficient. And
>> being unable to write whole compressed data on array, on s390 whole data
>> can't be rec
On Mon, 6 Mar 2023 06:54:27 GMT, Jaikiran Pai wrote:
>After running the test you can share with us the logs. We could provide more
>suggestions what to debug further, but I think you or someone with access to
>that system will have to do the actual investigation..
Output for above patch, I can
On Thu, 2 Feb 2023 08:27:55 GMT, Amit Kumar wrote:
>> DeInflate.java test fails on s390x platform because size for out1 array
>> which is responsible for storing the compressed data is insufficient. And
>> being unable to write whole compressed data on array, on s390 whole data
>> can't be rec
On Thu, 2 Feb 2023 08:27:55 GMT, Amit Kumar wrote:
>> DeInflate.java test fails on s390x platform because size for out1 array
>> which is responsible for storing the compressed data is insufficient. And
>> being unable to write whole compressed data on array, on s390 whole data
>> can't be rec
On Fri, 17 Feb 2023 09:01:23 GMT, Alan Bateman wrote:
>maybe change the loop to only test levels 0-9 and see if it passes?
`initial size: 525312`
error I'm facing is on level 1 not on -1.
level:1, strategy: 0, dowrap: false
required size: 553018 <- there is an issue
required size: 283432
On Thu, 16 Feb 2023 05:32:26 GMT, Amit Kumar wrote:
> As you can see, the size of out1 is insufficient for the s390x. That's why I
> proposed the fix to increase the buffer size. Because the compressor is not
> deterministic, I don't want to be byte-perfect, so I changed the multiplier
> to `6
On Wed, 15 Feb 2023 08:15:28 GMT, Alan Bateman wrote:
>I assume you can quickly check which loop, I suspect it's the deflate loop
>based of the previous comments/experiments.
Both of loop's are inf-loops with this change. If somehow I terminate the
first loop then second goes into infinite st
On Wed, 15 Feb 2023 02:25:00 GMT, Amit Kumar wrote:
> After reverting all of my changes, I applied your patch and I got time limit
> error, probably because of some inf-loop ?
>
> ```
> result: Error. Agent error: java.lang.Exception: Agent 2 timed out with a
> timeout of 480 seconds; check co
On Tue, 14 Feb 2023 20:08:47 GMT, Alan Bateman wrote:
>I don't think we have a good handle on the issue. It's clear that this zlib
>implementation is a bit different but I'm concerned that your proposed change
>to the test is masking an issue. I say this because the check method is
>changed to
On Tue, 7 Feb 2023 07:07:54 GMT, Alan Bateman wrote:
>>> Hi @AlanBateman ,
>>> with latest changes (doing inflate/deinflate) test passes over s390 and x86
>>> as well. Please take a look now.
>>
>> Good. One thing to try is to just deflate/inflate into out1/out2, no need
>> for the intermediat
On Tue, 7 Feb 2023 07:07:54 GMT, Alan Bateman wrote:
>>> Hi @AlanBateman ,
>>> with latest changes (doing inflate/deinflate) test passes over s390 and x86
>>> as well. Please take a look now.
>>
>> Good. One thing to try is to just deflate/inflate into out1/out2, no need
>> for the intermediat
On Thu, 2 Feb 2023 08:27:55 GMT, Amit Kumar wrote:
>> DeInflate.java test fails on s390x platform because size for out1 array
>> which is responsible for storing the compressed data is insufficient. And
>> being unable to write whole compressed data on array, on s390 whole data
>> can't be rec
On Thu, 2 Feb 2023 08:27:55 GMT, Amit Kumar wrote:
>> DeInflate.java test fails on s390x platform because size for out1 array
>> which is responsible for storing the compressed data is insufficient. And
>> being unable to write whole compressed data on array, on s390 whole data
>> can't be rec
On Thu, 2 Feb 2023 08:27:55 GMT, Amit Kumar wrote:
>> DeInflate.java test fails on s390x platform because size for out1 array
>> which is responsible for storing the compressed data is insufficient. And
>> being unable to write whole compressed data on array, on s390 whole data
>> can't be rec
On Thu, 2 Feb 2023 10:06:23 GMT, Alan Bateman wrote:
>>> level:1, strategy: 0, dowrap: false
>>> is finished: false
>>
>> Thanks for checking that. So "is finished: false" is telling us that not all
>> of the input was compressed. So I think the right thing is to do the defl
On Thu, 2 Feb 2023 10:06:23 GMT, Alan Bateman wrote:
>>> level:1, strategy: 0, dowrap: false
>>> is finished: false
>>
>> Thanks for checking that. So "is finished: false" is telling us that not all
>> of the input was compressed. So I think the right thing is to do the defl
On Thu, 2 Feb 2023 08:27:55 GMT, Amit Kumar wrote:
>> DeInflate.java test fails on s390x platform because size for out1 array
>> which is responsible for storing the compressed data is insufficient. And
>> being unable to write whole compressed data on array, on s390 whole data
>> can't be rec
On Wed, 1 Feb 2023 08:46:12 GMT, Alan Bateman wrote:
>> Hi Alan, here is output:
>>
>> level:0, strategy: 2, dowrap: true
>>
>> is finished: true
>> i
On Wed, 1 Feb 2023 08:46:12 GMT, Alan Bateman wrote:
>> Hi Alan, here is output:
>>
>> level:0, strategy: 2, dowrap: true
>>
>> is finished: true
>> i
> DeInflate.java test fails on s390x platform because size for out1 array which
> is responsible for storing the compressed data is insufficient. And being
> unable to write whole compressed data on array, on s390 whole data can't be
> recovered after compression. So this fix increase Array size
On Wed, 1 Feb 2023 08:33:16 GMT, Amit Kumar wrote:
> level:1, strategy: 0, dowrap: false
> is finished: false
Thanks for checking that. So "is finished: false" is telling us that not all of
the input was compressed. So I think the right thing is to do the deflate in a
loop
On Mon, 30 Jan 2023 08:03:38 GMT, Amit Kumar wrote:
> DeInflate.java test fails on s390x platform because size for out1 array which
> is responsible for storing the compressed data is insufficient. And being
> unable to write whole compressed data on array, on s390 whole data can't be
> recove
On Tue, 31 Jan 2023 09:00:18 GMT, Alan Bateman wrote:
>> Hi @jaikiran ,
>> On my system OS's zlib is being used. and here is stack-trace.
>>
>> --System.out:(2/78)--
>> level:-1, strategy: 0, dowrap: false
>> m=525312, n=498060, len=524288, eq=false
>> --System.err:(11/58
On Tue, 31 Jan 2023 09:00:18 GMT, Alan Bateman wrote:
>> Hi @jaikiran ,
>> On my system OS's zlib is being used. and here is stack-trace.
>>
>> --System.out:(2/78)--
>> level:-1, strategy: 0, dowrap: false
>> m=525312, n=498060, len=524288, eq=false
>> --System.err:(11/58
On Mon, 30 Jan 2023 08:38:15 GMT, Amit Kumar wrote:
> m=525312, n=498060, len=524288, eq=false
The test doesn't print this so I assume this is tracing that you added in your
runs. If I read it correctly, the initial input is len=524288, it deflates to
m=525312, then re-inflates to n=498060. So
On Mon, 30 Jan 2023 08:24:27 GMT, Jaikiran Pai wrote:
>> DeInflate.java test fails on s390x platform because size for out1 array
>> which is responsible for storing the compressed data is insufficient. And
>> being unable to write whole compressed data on array, on s390 whole data
>> can't be
On Mon, 30 Jan 2023 08:03:38 GMT, Amit Kumar wrote:
> DeInflate.java test fails on s390x platform because size for out1 array which
> is responsible for storing the compressed data is insufficient. And being
> unable to write whole compressed data on array, on s390 whole data can't be
> recove
On Mon, 30 Jan 2023 08:03:38 GMT, Amit Kumar wrote:
> DeInflate.java test fails on s390x platform because size for out1 array which
> is responsible for storing the compressed data is insufficient. And being
> unable to write whole compressed data on array, on s390 whole data can't be
> recove
DeInflate.java test fails on s390x platform because size for out1 array which
is responsible for storing the compressed data is insufficient. And being
unable to write whole compressed data on array, on s390 whole data can't be
recovered after compression. So this fix increase Array size (for s3
74 matches
Mail list logo
