Re: RFR: 8299600: Use Objects.check*() where appropriate in java.io [v2]

2023-01-05 Thread Brian Burkhalter
On Thu, 5 Jan 2023 12:14:05 GMT, Sergey Tsypanov wrote: >> Use the following methods instead of hand-written code: >> - Objects.checkFromIndexSize() >> - Objects.checkFromToIndex() > > Sergey Tsypanov has updated the pull request incrementally with two > additional commits since the last revisio

Re: RFR: 8299600: Use Objects.check*() where appropriate in java.io [v2]

2023-01-05 Thread Alan Bateman
On Thu, 5 Jan 2023 12:14:05 GMT, Sergey Tsypanov wrote: >> Use the following methods instead of hand-written code: >> - Objects.checkFromIndexSize() >> - Objects.checkFromToIndex() > > Sergey Tsypanov has updated the pull request incrementally with two > additional commits since the last revisio

Re: RFR: 8299600: Use Objects.check*() where appropriate in java.io [v2]

2023-01-05 Thread Brian Burkhalter
On Thu, 5 Jan 2023 12:09:46 GMT, Sergey Tsypanov wrote: >>> Indeed there are at least four regression test failures with this as-is: >>> >>> * java/io/InputStream/ReadParams.java >>> * java/io/OutputStream/WriteParams.java >>> * java/io/Writer/WriteParams.java >>> * java/nio/channels/FileChannel

Re: RFR: 8299600: Use Objects.check*() where appropriate in java.io [v2]

2023-01-05 Thread Sergey Tsypanov
> Use the following methods instead of hand-written code: > - Objects.checkFromIndexSize() > - Objects.checkFromToIndex() Sergey Tsypanov has updated the pull request incrementally with two additional commits since the last revision: - 8299600: Use checkFromIndexSize in PipedWriter.java - 8299

Re: RFR: 8299600: Use Objects.check*() where appropriate in java.io [v2]

2023-01-05 Thread Sergey Tsypanov
On Thu, 5 Jan 2023 07:11:57 GMT, Alan Bateman wrote: >> Indeed there are at least four regression test failures with this as-is: >> >> - java/io/InputStream/ReadParams.java >> - java/io/OutputStream/WriteParams.java >> - java/io/Writer/WriteParams.java >> - java/nio/channels/FileChannel/Transfer