> Moving the built-in implementation of `Console` from `java.io` package into
> `jdk.internal.io` package. It now implements `JdkConsole` interface and is
> accessed through `ProxyingConsole`.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revisi
On Wed, 21 Dec 2022 11:18:25 GMT, Andrey Turbanov wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Replaced assert with requireNonNull
>
> src/java.base/share/classes/jdk/internal/io/JdkConsoleImpl.java line 60:
>
>>
On Wed, 21 Dec 2022 02:30:21 GMT, Naoto Sato wrote:
>> Moving the built-in implementation of `Console` from `java.io` package into
>> `jdk.internal.io` package. It now implements `JdkConsole` interface and is
>> accessed through `ProxyingConsole`.
>
> Naoto Sato has updated the pull request inc
On Wed, 21 Dec 2022 02:30:21 GMT, Naoto Sato wrote:
>> Moving the built-in implementation of `Console` from `java.io` package into
>> `jdk.internal.io` package. It now implements `JdkConsole` interface and is
>> accessed through `ProxyingConsole`.
>
> Naoto Sato has updated the pull request inc
On Wed, 21 Dec 2022 00:33:09 GMT, Jaikiran Pai wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Removed JdkConsoleProviderImpl, caching INSTANCE
>
> src/java.base/share/classes/jdk/internal/io/JdkConsoleImpl.java line
> Moving the built-in implementation of `Console` from `java.io` package into
> `jdk.internal.io` package. It now implements `JdkConsole` interface and is
> accessed through `ProxyingConsole`.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revisi
On Tue, 20 Dec 2022 22:06:26 GMT, Naoto Sato wrote:
>> Moving the built-in implementation of `Console` from `java.io` package into
>> `jdk.internal.io` package. It now implements `JdkConsole` interface and is
>> accessed through `ProxyingConsole`.
>
> Naoto Sato has updated the pull request inc
On Tue, 20 Dec 2022 14:24:28 GMT, Jaikiran Pai wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Removed JdkConsoleProviderImpl, caching INSTANCE
>
> src/java.base/share/classes/jdk/internal/io/JdkConsoleImpl.java line
On Tue, 20 Dec 2022 14:44:38 GMT, Jaikiran Pai wrote:
>> Actually, I see that it isn't possible for these to be final because we set
>> these up in the `console(...)` instance method of this class. That's because
>> this `JdkConsoleImpl` implements both the `JdkConsole` interface and the
>> `J
> Moving the built-in implementation of `Console` from `java.io` package into
> `jdk.internal.io` package. It now implements `JdkConsole` interface and is
> accessed through `ProxyingConsole`.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revisi
On Tue, 20 Dec 2022 14:37:10 GMT, Jaikiran Pai wrote:
>> src/java.base/share/classes/jdk/internal/io/JdkConsoleImpl.java line 179:
>>
>>> 177: private Writer out;
>>> 178: private PrintWriter pw;
>>> 179: private Formatter formatter;
>>
>> Hello Naoto, I think some of these can be m
On Tue, 20 Dec 2022 14:17:32 GMT, Jaikiran Pai wrote:
>> Moving the built-in implementation of `Console` from `java.io` package into
>> `jdk.internal.io` package. It now implements `JdkConsole` interface and is
>> accessed through `ProxyingConsole`.
>
> src/java.base/share/classes/jdk/internal/
On Mon, 19 Dec 2022 19:23:25 GMT, Naoto Sato wrote:
> Moving the built-in implementation of `Console` from `java.io` package into
> `jdk.internal.io` package. It now implements `JdkConsole` interface and is
> accessed through `ProxyingConsole`.
src/java.base/share/classes/jdk/internal/io/JdkCo
On Mon, 19 Dec 2022 19:23:25 GMT, Naoto Sato wrote:
> Moving the built-in implementation of `Console` from `java.io` package into
> `jdk.internal.io` package. It now implements `JdkConsole` interface and is
> accessed through `ProxyingConsole`.
src/java.base/share/classes/jdk/internal/io/JdkCo
On Mon, 19 Dec 2022 19:23:25 GMT, Naoto Sato wrote:
> Moving the built-in implementation of `Console` from `java.io` package into
> `jdk.internal.io` package. It now implements `JdkConsole` interface and is
> accessed through `ProxyingConsole`.
src/java.base/share/classes/jdk/internal/io/JdkCo
Moving the built-in implementation of `Console` from `java.io` package into
`jdk.internal.io` package. It now implements `JdkConsole` interface and is
accessed through `ProxyingConsole`.
-
Commit messages:
- Split Console_md.c
- 8298971: Move Console implementation into jdk intern
16 matches
Mail list logo
