Re: RFR: 8297976: Remove sun.net.ProgressMonitor and related classes [v4]

2022-12-07 Thread Daniel Jeliński
On Tue, 6 Dec 2022 13:42:04 GMT, Daniel Jeliński wrote: >> Please review this patch that removes progress monitoring classes used by >> UrlConnection. >> Since Java 9 these classes are not used in the JDK, and are not exported >> from java.base. If anyone was still using them, reimplementing th

Re: RFR: 8297976: Remove sun.net.ProgressMonitor and related classes [v4]

2022-12-06 Thread Jaikiran Pai
On Tue, 6 Dec 2022 13:42:04 GMT, Daniel Jeliński wrote: >> Please review this patch that removes progress monitoring classes used by >> UrlConnection. >> Since Java 9 these classes are not used in the JDK, and are not exported >> from java.base. If anyone was still using them, reimplementing th

Re: RFR: 8297976: Remove sun.net.ProgressMonitor and related classes [v4]

2022-12-06 Thread Daniel Fuchs
On Tue, 6 Dec 2022 13:42:04 GMT, Daniel Jeliński wrote: >> Please review this patch that removes progress monitoring classes used by >> UrlConnection. >> Since Java 9 these classes are not used in the JDK, and are not exported >> from java.base. If anyone was still using them, reimplementing th

Re: RFR: 8297976: Remove sun.net.ProgressMonitor and related classes [v4]

2022-12-06 Thread Michael McMahon
On Tue, 6 Dec 2022 13:42:04 GMT, Daniel Jeliński wrote: >> Please review this patch that removes progress monitoring classes used by >> UrlConnection. >> Since Java 9 these classes are not used in the JDK, and are not exported >> from java.base. If anyone was still using them, reimplementing th

Re: RFR: 8297976: Remove sun.net.ProgressMonitor and related classes [v2]

2022-12-06 Thread Daniel Jeliński
On Tue, 6 Dec 2022 12:43:44 GMT, Daniel Fuchs wrote: >> test/jdk/sun/net/www/http/KeepAliveStream/KeepAliveStreamFinalizer.java line >> 175: >> >>> 173: public InputStream getInputStream() throws IOException { >>> 174: if (finalized) { >>> 175: System.out.pri

Re: RFR: 8297976: Remove sun.net.ProgressMonitor and related classes [v4]

2022-12-06 Thread Daniel Jeliński
> Please review this patch that removes progress monitoring classes used by > UrlConnection. > Since Java 9 these classes are not used in the JDK, and are not exported from > java.base. If anyone was still using them, reimplementing them in user code > should be pretty straightforward. > > This

Re: RFR: 8297976: Remove sun.net.ProgressMonitor and related classes [v2]

2022-12-06 Thread Jaikiran Pai
On Tue, 6 Dec 2022 12:38:42 GMT, Daniel Fuchs wrote: >> test/jdk/sun/net/www/http/KeepAliveStream/KeepAliveStreamFinalizer.java line >> 28: >> >>> 26: * @bug 8240275 >>> 27: * @library /test/lib >>> 28: * @run main/othervm KeepAliveStreamFinalizer >> >> Hello Daniel, it doesn't look like we

Re: RFR: 8297976: Remove sun.net.ProgressMonitor and related classes [v2]

2022-12-06 Thread Daniel Fuchs
On Tue, 6 Dec 2022 12:05:26 GMT, Jaikiran Pai wrote: >> Daniel Jeliński has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Add test > > test/jdk/sun/net/www/http/KeepAliveStream/KeepAliveStreamFinalizer.java line > 175: > >> 173:

Re: RFR: 8297976: Remove sun.net.ProgressMonitor and related classes [v3]

2022-12-06 Thread Daniel Fuchs
On Mon, 5 Dec 2022 14:12:05 GMT, Daniel Jeliński wrote: >> Please review this patch that removes progress monitoring classes used by >> UrlConnection. >> Since Java 9 these classes are not used in the JDK, and are not exported >> from java.base. If anyone was still using them, reimplementing th

Re: RFR: 8297976: Remove sun.net.ProgressMonitor and related classes [v2]

2022-12-06 Thread Daniel Fuchs
On Tue, 6 Dec 2022 12:07:35 GMT, Jaikiran Pai wrote: >> Daniel Jeliński has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Add test > > test/jdk/sun/net/www/http/KeepAliveStream/KeepAliveStreamFinalizer.java line > 28: > >> 26: * @bug 82

Re: RFR: 8297976: Remove sun.net.ProgressMonitor and related classes [v2]

2022-12-06 Thread Jaikiran Pai
On Mon, 5 Dec 2022 14:06:10 GMT, Daniel Jeliński wrote: >> Please review this patch that removes progress monitoring classes used by >> UrlConnection. >> Since Java 9 these classes are not used in the JDK, and are not exported >> from java.base. If anyone was still using them, reimplementing th

Re: RFR: 8297976: Remove sun.net.ProgressMonitor and related classes [v3]

2022-12-05 Thread Daniel Jeliński
> Please review this patch that removes progress monitoring classes used by > UrlConnection. > Since Java 9 these classes are not used in the JDK, and are not exported from > java.base. If anyone was still using them, reimplementing them in user code > should be pretty straightforward. > > This

Re: RFR: 8297976: Remove sun.net.ProgressMonitor and related classes [v2]

2022-12-05 Thread Daniel Jeliński
On Mon, 5 Dec 2022 14:06:10 GMT, Daniel Jeliński wrote: >> Please review this patch that removes progress monitoring classes used by >> UrlConnection. >> Since Java 9 these classes are not used in the JDK, and are not exported >> from java.base. If anyone was still using them, reimplementing th

Re: RFR: 8297976: Remove sun.net.ProgressMonitor and related classes [v2]

2022-12-05 Thread Daniel Jeliński
> Please review this patch that removes progress monitoring classes used by > UrlConnection. > Since Java 9 these classes are not used in the JDK, and are not exported from > java.base. If anyone was still using them, reimplementing them in user code > should be pretty straightforward. > > This

Re: RFR: 8297976: Remove sun.net.ProgressMonitor and related classes

2022-12-05 Thread Jaikiran Pai
On Fri, 2 Dec 2022 08:31:25 GMT, Daniel Jeliński wrote: > Please review this patch that removes progress monitoring classes used by > UrlConnection. > Since Java 9 these classes are not used in the JDK, and are not exported from > java.base. If anyone was still using them, reimplementing them i

Re: RFR: 8297976: Remove sun.net.ProgressMonitor and related classes

2022-12-04 Thread Andrey Turbanov
On Fri, 2 Dec 2022 08:31:25 GMT, Daniel Jeliński wrote: > Please review this patch that removes progress monitoring classes used by > UrlConnection. > Since Java 9 these classes are not used in the JDK, and are not exported from > java.base. If anyone was still using them, reimplementing them i

Re: RFR: 8297976: Remove sun.net.ProgressMonitor and related classes

2022-12-02 Thread Daniel Fuchs
On Fri, 2 Dec 2022 08:31:25 GMT, Daniel Jeliński wrote: > Please review this patch that removes progress monitoring classes used by > UrlConnection. > Since Java 9 these classes are not used in the JDK, and are not exported from > java.base. If anyone was still using them, reimplementing them i

RFR: 8297976: Remove sun.net.ProgressMonitor and related classes

2022-12-02 Thread Daniel Jeliński
Please review this patch that removes progress monitoring classes used by UrlConnection. Since Java 9 these classes are not used in the JDK, and are not exported from java.base. If anyone was still using them, reimplementing them in user code should be pretty straightforward. This PR also fixes