Re: RFR: 8295970: Add jdk_vector tests in GHA [v2]

2022-10-30 Thread Jie Fu
On Sat, 29 Oct 2022 23:08:38 GMT, Sergey Bylokhov wrote: > What about possibility to run additional group of the test by passing somehow > the name of group to the GA, via label or via /test cmd, or via parameter to > the specific task in GA? Well, it sounds good to run specific tests via labe

Re: RFR: 8295970: Add jdk_vector tests in GHA

2022-10-30 Thread Jie Fu
On Sat, 29 Oct 2022 07:58:49 GMT, Alan Bateman wrote: > I realise there are already some test lists in both the hotspot and jdk > TEST.groups but it feels like it needs something better so that > RunTests.gmk/jtreg can select the sanity tests to run. Thanks @AlanBateman for this comment. Is th

Re: RFR: 8295970: Add jdk_vector tests in GHA [v2]

2022-10-29 Thread Sergey Bylokhov
On Fri, 28 Oct 2022 07:19:31 GMT, Jie Fu wrote: >> Hi all, >> >> As discussed here >> https://github.com/openjdk/jdk/pull/10807#pullrequestreview-1150314487 , it >> would be better to add the vector api tests in GHA. >> >> Thanks. >> Best regards, >> Jie > > Jie Fu has updated the pull reques

Re: RFR: 8295970: Add jdk_vector tests in GHA

2022-10-29 Thread Alan Bateman
On Fri, 28 Oct 2022 07:21:05 GMT, Jie Fu wrote: > Good suggestion! > And the `jdk_vector_sanity` test group had been added. In general, running a few fast sanity tests from several areas in tier1 seems a good idea. Having test lists in the TEST.group files isn't very appealing as they easily g

Re: RFR: 8295970: Add jdk_vector tests in GHA [v2]

2022-10-28 Thread Jie Fu
On Fri, 28 Oct 2022 13:41:28 GMT, Erik Joelsson wrote: > I think you need to add at least one other label than `build` to this now to > make sure the right people can have a say in the change. Done. Thanks @erikj79 . - PR: https://git.openjdk.org/jdk/pull/10879