On Tue, 14 Mar 2023 18:00:51 GMT, Mandy Chung wrote:
>> Right, I'll fix it, thanks.
>
> Looks like `LineNumberTable` is not stripped even with
> `Option.processLineNumbers(false)`.
Yes, I forgot to transform code elements, where
`Classfile.Option.processLineNumbers(false)` option is applied.
On Tue, 14 Mar 2023 15:22:04 GMT, Adam Sotona wrote:
>> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/StripJavaDebugAttributesPlugin.java
>> line 62:
>>
>>> 60: // XXX. Do we have debug info? Is Asm ready for
>>> module-info?
>>> 61: }
On Fri, 10 Mar 2023 22:14:00 GMT, Mandy Chung wrote:
>> Adam Sotona has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 208 commits:
>>
>> - Merge branch 'master' into JDK-8294972-jlink-plugins
>>
>># Conflicts:
>># src/j
On Mon, 13 Mar 2023 14:51:08 GMT, Alan Bateman wrote:
>> Adam Sotona has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 208 commits:
>>
>> - Merge branch 'master' into JDK-8294972-jlink-plugins
>>
>># Conflicts:
>># src/
On Fri, 10 Mar 2023 12:45:05 GMT, Adam Sotona wrote:
>> jdk.jlink internal plugins are heavily using ASM
>>
>> This patch converts ASM calls to Classfile API.
>>
>> Please review.
>> Thanks,
>> Adam
>
> Adam Sotona has updated the pull request with a new target base due to a
> merge or a rebas
On Fri, 10 Mar 2023 12:45:05 GMT, Adam Sotona wrote:
>> jdk.jlink internal plugins are heavily using ASM
>>
>> This patch converts ASM calls to Classfile API.
>>
>> Please review.
>> Thanks,
>> Adam
>
> Adam Sotona has updated the pull request with a new target base due to a
> merge or a rebas
On Fri, 10 Mar 2023 12:45:05 GMT, Adam Sotona wrote:
>> jdk.jlink internal plugins are heavily using ASM
>>
>> This patch converts ASM calls to Classfile API.
>>
>> Please review.
>> Thanks,
>> Adam
>
> Adam Sotona has updated the pull request with a new target base due to a
> merge or a rebas