Re: RFR: 8293910: tools/launcher/FXLauncherTest.java fail with jfx [v2]

2022-09-21 Thread Leslie Zhai
On Wed, 21 Sep 2022 07:56:27 GMT, Alan Bateman wrote: >> Hi @AlanBateman >> >> Debug patch: >> >> >> diff --git a/test/jdk/tools/launcher/FXLauncherTest.java >> b/test/jdk/tools/launcher/FXLauncherTest.java >> index 9cc4b5aea98..33c3e2788ad 100644 >> --- a/test/jdk/tools/launcher/FXLauncherT

Re: RFR: 8293910: tools/launcher/FXLauncherTest.java fail with jfx [v2]

2022-09-21 Thread Alan Bateman
On Wed, 21 Sep 2022 07:42:29 GMT, Leslie Zhai wrote: > Still failed: > [debug.log](https://github.com/openjdk/jdk/files/9614161/debug.log) You are running into module hashes now so I think you'll need some of JDK-8294093. In make/common/Modules.gmk ReadSingleImportMetaData can you add UPGR

Re: RFR: 8293910: tools/launcher/FXLauncherTest.java fail with jfx [v2]

2022-09-21 Thread Leslie Zhai
On Wed, 21 Sep 2022 07:56:27 GMT, Alan Bateman wrote: >> Hi @AlanBateman >> >> Debug patch: >> >> >> diff --git a/test/jdk/tools/launcher/FXLauncherTest.java >> b/test/jdk/tools/launcher/FXLauncherTest.java >> index 9cc4b5aea98..33c3e2788ad 100644 >> --- a/test/jdk/tools/launcher/FXLauncherT

Re: RFR: 8293910: tools/launcher/FXLauncherTest.java fail with jfx [v2]

2022-09-21 Thread Leslie Zhai
On Wed, 21 Sep 2022 07:10:07 GMT, Alan Bateman wrote: > but you've set the value to IMPORT_MODULE_DIR and it's not clear what this > means in this test I just want to try the imported javafx modules: --patch-module=javafx.graphics=build/linux-loongarch64-server-fastdebug/images/jdk/jmods/java

Re: RFR: 8293910: tools/launcher/FXLauncherTest.java fail with jfx [v2]

2022-09-21 Thread Alan Bateman
On Sat, 17 Sep 2022 04:03:35 GMT, Leslie Zhai wrote: >> Hi, >> >> @dumasun reported the issue: >> >> Configured with jfx-ls-modular-sdk: >> >> >> configure --with-import-modules=modular-sdk >> >> >> `make run-test CONF=fastdebug TEST="tools/launcher/FXLauncherTest.java"` >> failed: >> >>

Re: RFR: 8293910: tools/launcher/FXLauncherTest.java fail with jfx [v2]

2022-09-21 Thread Leslie Zhai
On Wed, 21 Sep 2022 07:10:07 GMT, Alan Bateman wrote: >> Leslie Zhai has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8293910: Try --upgrade-module-path and --patch-module but still failed > > The --patch-module option is used to override

Re: RFR: 8293910: tools/launcher/FXLauncherTest.java fail with jfx [v2]

2022-09-21 Thread Alan Bateman
On Sat, 17 Sep 2022 04:03:35 GMT, Leslie Zhai wrote: >> Hi, >> >> @dumasun reported the issue: >> >> Configured with jfx-ls-modular-sdk: >> >> >> configure --with-import-modules=modular-sdk >> >> >> `make run-test CONF=fastdebug TEST="tools/launcher/FXLauncherTest.java"` >> failed: >> >>

Re: RFR: 8293910: tools/launcher/FXLauncherTest.java fail with jfx [v2]

2022-09-20 Thread Leslie Zhai
On Tue, 20 Sep 2022 14:23:22 GMT, Kevin Rushforth wrote: >> Leslie Zhai has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8293910: Try --upgrade-module-path and --patch-module but still failed > > How does the test fail? Does it actually f

Re: RFR: 8293910: tools/launcher/FXLauncherTest.java fail with jfx [v2]

2022-09-20 Thread Kevin Rushforth
On Sat, 17 Sep 2022 04:03:35 GMT, Leslie Zhai wrote: >> Hi, >> >> @dumasun reported the issue: >> >> Configured with jfx-ls-modular-sdk: >> >> >> configure --with-import-modules=modular-sdk >> >> >> `make run-test CONF=fastdebug TEST="tools/launcher/FXLauncherTest.java"` >> failed: >> >>

Re: RFR: 8293910: tools/launcher/FXLauncherTest.java fail with jfx

2022-09-17 Thread Leslie Zhai
On Fri, 16 Sep 2022 13:02:16 GMT, Kevin Rushforth wrote: >> Hi, >> >> @dumasun reported the issue: >> >> Configured with jfx-ls-modular-sdk: >> >> >> configure --with-import-modules=modular-sdk >> >> >> `make run-test CONF=fastdebug TEST="tools/launcher/FXLauncherTest.java"` >> failed: >>

Re: RFR: 8293910: tools/launcher/FXLauncherTest.java fail with jfx [v2]

2022-09-16 Thread Leslie Zhai
On Sat, 17 Sep 2022 04:03:35 GMT, Leslie Zhai wrote: >> Hi, >> >> @dumasun reported the issue: >> >> Configured with jfx-ls-modular-sdk: >> >> >> configure --with-import-modules=modular-sdk >> >> >> `make run-test CONF=fastdebug TEST="tools/launcher/FXLauncherTest.java"` >> failed: >> >>

Re: RFR: 8293910: tools/launcher/FXLauncherTest.java fail with jfx [v2]

2022-09-16 Thread Leslie Zhai
> Hi, > > @dumasun reported the issue: > > Configured with jfx-ls-modular-sdk: > > > configure --with-import-modules=modular-sdk > > > `make run-test CONF=fastdebug TEST="tools/launcher/FXLauncherTest.java"` > failed: > > > --System.err:(11/697)-- > java.lang.RuntimeExcepti

Re: RFR: 8293910: tools/launcher/FXLauncherTest.java fail with jfx

2022-09-16 Thread Kevin Rushforth
On Fri, 16 Sep 2022 07:35:03 GMT, Leslie Zhai wrote: > Hi, > > @dumasun reported the issue: > > Configured with jfx-ls-modular-sdk: > > > configure --with-import-modules=modular-sdk > > > `make run-test CONF=fastdebug TEST="tools/launcher/FXLauncherTest.java"` > failed: > > > --S

Re: RFR: 8293910: tools/launcher/FXLauncherTest.java fail with jfx

2022-09-16 Thread Alan Bateman
On Fri, 16 Sep 2022 07:35:03 GMT, Leslie Zhai wrote: > Hi, > > @dumasun reported the issue: > > Configured with jfx-ls-modular-sdk: > > > configure --with-import-modules=modular-sdk > > > `make run-test CONF=fastdebug TEST="tools/launcher/FXLauncherTest.java"` > failed: > > > --S

Re: RFR: 8293910: tools/launcher/FXLauncherTest.java fail with jfx

2022-09-16 Thread Leslie Zhai
On Fri, 16 Sep 2022 07:35:03 GMT, Leslie Zhai wrote: > Hi, > > @dumasun reported the issue: > > Configured with jfx-ls-modular-sdk: > > > configure --with-import-modules=modular-sdk > > > `make run-test CONF=fastdebug TEST="tools/launcher/FXLauncherTest.java"` > failed: > > > --S

RFR: 8293910: tools/launcher/FXLauncherTest.java fail with jfx

2022-09-16 Thread Leslie Zhai
Hi, @dumasun reported the issue: Configured with jfx-ls-modular-sdk: configure --with-import-modules=modular-sdk `make run-test CONF=fastdebug TEST="tools/launcher/FXLauncherTest.java"` failed: --System.err:(11/697)-- java.lang.RuntimeException: JavaFX modules erroneously in