On Mon, 12 Sep 2022 11:48:50 GMT, Claes Redestad wrote:
> > Meaning, we allow `--compress=zip-[0..9]` and default to `zip-6`. This has
> > the added benefit of clearly stating that `zip-0` is still ZIP, but without
> > the compression applied. This is a bit ambiguous with
> > `--compression-le
On Mon, 12 Sep 2022 11:20:14 GMT, Aleksey Shipilev wrote:
> Meaning, we allow `--compress=zip-[0..9]` and default to `zip-6`. This has
> the added benefit of clearly stating that `zip-0` is still ZIP, but without
> the compression applied. This is a bit ambiguous with `--compression-level=0`.
On Mon, 12 Sep 2022 10:48:53 GMT, Claes Redestad wrote:
> The part about being open-ended about alternate compression algorithms still
> applies, but since the compression for `jmod` is currently always zip we can
> defer such wording for if/when that day comes.
Well, we can future-proof it by
On Mon, 12 Sep 2022 10:48:16 GMT, Aleksey Shipilev wrote:
>> I have been looking into `make clean-images images` performance, and
>> realized jmod keeps compressing files with default compression level. Tuning
>> that toward lighter compression levels improves build performance
>> considerably
On Mon, 12 Sep 2022 10:48:16 GMT, Aleksey Shipilev wrote:
>> I have been looking into `make clean-images images` performance, and
>> realized jmod keeps compressing files with default compression level. Tuning
>> that toward lighter compression levels improves build performance
>> considerably
On Mon, 12 Sep 2022 10:26:56 GMT, Aleksey Shipilev wrote:
> Um, this is `jmod`, it does not have `--compress=...` option? `jlink` does.
> So, I don't quite understand this comment :)
Doh! Yes, I mixed up the two and assumed you'd be considering this for `jlink`
as well. The part about being op
On Mon, 12 Sep 2022 10:18:40 GMT, Jaikiran Pai wrote:
> Should we instead complain/fail when this option is used for anything other
> than `create`?
Good idea, see new commit.
-
PR: https://git.openjdk.org/jdk/pull/10213
> I have been looking into `make clean-images images` performance, and realized
> jmod keeps compressing files with default compression level. Tuning that
> toward lighter compression levels improves build performance considerably,
> without a heavy loss in *.jmod sizes.
>
> This PR allows JMO
On Mon, 12 Sep 2022 10:15:26 GMT, Jaikiran Pai wrote:
>> I have been looking into `make clean-images images` performance, and
>> realized jmod keeps compressing files with default compression level. Tuning
>> that toward lighter compression levels improves build performance
>> considerably, wi
On Mon, 12 Sep 2022 10:13:12 GMT, Claes Redestad wrote:
> Could we word this so that the accepted values is compression-dependent? The
> value appears to be ignored for `--compress=0|1` (should it throw if
> specified or not specified to, say, 0?). We might also add other compressions
> in the
On Thu, 8 Sep 2022 07:57:36 GMT, Aleksey Shipilev wrote:
> I have been looking into `make clean-images images` performance, and realized
> jmod keeps compressing files with default compression level. Tuning that
> toward lighter compression levels improves build performance considerably,
> wit
On Thu, 8 Sep 2022 07:57:36 GMT, Aleksey Shipilev wrote:
> I have been looking into `make clean-images images` performance, and realized
> jmod keeps compressing files with default compression level. Tuning that
> toward lighter compression levels improves build performance considerably,
> wit
On Thu, 8 Sep 2022 07:57:36 GMT, Aleksey Shipilev wrote:
> I have been looking into `make clean-images images` performance, and realized
> jmod keeps compressing files with default compression level. Tuning that
> toward lighter compression levels improves build performance considerably,
> wit
On Thu, 8 Sep 2022 07:57:36 GMT, Aleksey Shipilev wrote:
> I have been looking into `make clean-images images` performance, and realized
> jmod keeps compressing files with default compression level. Tuning that
> toward lighter compression levels improves build performance considerably,
> wit
On Thu, 8 Sep 2022 07:57:36 GMT, Aleksey Shipilev wrote:
> I have been looking into `make clean-images images` performance, and realized
> jmod keeps compressing files with default compression level. Tuning that
> toward lighter compression levels improves build performance considerably,
> wit
On Thu, 8 Sep 2022 07:57:36 GMT, Aleksey Shipilev wrote:
> I have been looking into `make clean-images images` performance, and realized
> jmod keeps compressing files with default compression level. Tuning that
> toward lighter compression levels improves build performance considerably,
> wit
On Thu, 8 Sep 2022 07:57:36 GMT, Aleksey Shipilev wrote:
> I have been looking into `make clean-images images` performance, and realized
> jmod keeps compressing files with default compression level. Tuning that
> toward lighter compression levels improves build performance considerably,
> wit
On Thu, 8 Sep 2022 07:57:36 GMT, Aleksey Shipilev wrote:
> I have been looking into `make clean-images images` performance, and realized
> jmod keeps compressing files with default compression level. Tuning that
> toward lighter compression levels improves build performance considerably,
> wit
I have been looking into `make clean-images images` performance, and realized
jmod keeps compressing files with default compression level. Tuning that toward
lighter compression levels improves build performance considerably, without a
heavy loss in *.jmod sizes.
This PR allows JMOD to select
19 matches
Mail list logo
