Re: RFR: 8292955: Collections.checkedMap Map.merge does not properly check key and value [v3]

2024-05-27 Thread Per Minborg
On Thu, 7 Mar 2024 05:33:16 GMT, Lei Zhu wrote: >> When the specified key did not associated with a value, should check the >> `key` and `value` type. > > Lei Zhu has updated the pull request incrementally with one additional commit > since the last revision: > > Use testNG builtin functiona

Re: RFR: 8292955: Collections.checkedMap Map.merge does not properly check key and value [v3]

2024-05-27 Thread Per Minborg
On Mon, 27 May 2024 12:40:07 GMT, Chen Liang wrote: > @minborg Is it possible for you to review this collection bugfix? Will do! Thanks for the heads up. - PR Comment: https://git.openjdk.org/jdk/pull/18141#issuecomment-2134446236

Re: RFR: 8292955: Collections.checkedMap Map.merge does not properly check key and value [v3]

2024-05-27 Thread Chen Liang
On Thu, 7 Mar 2024 05:33:16 GMT, Lei Zhu wrote: >> When the specified key did not associated with a value, should check the >> `key` and `value` type. > > Lei Zhu has updated the pull request incrementally with one additional commit > since the last revision: > > Use testNG builtin functiona

Re: RFR: 8292955: Collections.checkedMap Map.merge does not properly check key and value [v3]

2024-05-13 Thread Chen Liang
On Fri, 12 Apr 2024 08:55:01 GMT, Viktor Klang wrote: >> Keep-alive, maybe people like @viktorklang-ora might look at this simple fix >> too > > @liach I'm not a Reviewer (yet) so I'll defer to someone like @stuart-marks :) @viktorklang-ora Can you just leave an approval as a collections engine

Re: RFR: 8292955: Collections.checkedMap Map.merge does not properly check key and value [v3]

2024-05-12 Thread Korov
On Thu, 7 Mar 2024 05:33:16 GMT, Korov wrote: >> When the specified key did not associated with a value, should check the >> `key` and `value` type. > > Korov has updated the pull request incrementally with one additional commit > since the last revision: > > Use testNG builtin functionaliti

Re: RFR: 8292955: Collections.checkedMap Map.merge does not properly check key and value [v3]

2024-04-12 Thread Viktor Klang
On Thu, 11 Apr 2024 14:44:32 GMT, Chen Liang wrote: >> Korov has updated the pull request incrementally with one additional commit >> since the last revision: >> >> Use testNG builtin functionalities and modify the test function name > > Keep-alive, maybe people like @viktorklang-ora might lo

Re: RFR: 8292955: Collections.checkedMap Map.merge does not properly check key and value [v3]

2024-04-11 Thread Chen Liang
On Thu, 7 Mar 2024 05:33:16 GMT, Korov wrote: >> When the specified key did not associated with a value, should check the >> `key` and `value` type. > > Korov has updated the pull request incrementally with one additional commit > since the last revision: > > Use testNG builtin functionaliti

Re: RFR: 8292955: Collections.checkedMap Map.merge does not properly check key and value [v3]

2024-03-13 Thread Chen Liang
On Thu, 7 Mar 2024 05:33:16 GMT, Korov wrote: >> When the specified key did not associated with a value, should check the >> `key` and `value` type. > > Korov has updated the pull request incrementally with one additional commit > since the last revision: > > Use testNG builtin functionaliti

Re: RFR: 8292955: Collections.checkedMap Map.merge does not properly check key and value [v3]

2024-03-13 Thread Korov
On Thu, 7 Mar 2024 05:33:16 GMT, Korov wrote: >> When the specified key did not associated with a value, should check the >> `key` and `value` type. > > Korov has updated the pull request incrementally with one additional commit > since the last revision: > > Use testNG builtin functionaliti

Re: RFR: 8292955: Collections.checkedMap Map.merge does not properly check key and value [v3]

2024-03-06 Thread Guoxiong Li
On Thu, 7 Mar 2024 05:33:16 GMT, Korov wrote: >> When the specified key did not associated with a value, should check the >> `key` and `value` type. > > Korov has updated the pull request incrementally with one additional commit > since the last revision: > > Use testNG builtin functionaliti

Re: RFR: 8292955: Collections.checkedMap Map.merge does not properly check key and value [v2]

2024-03-06 Thread Korov
On Thu, 7 Mar 2024 04:37:24 GMT, Chen Liang wrote: >> Korov has updated the pull request incrementally with one additional commit >> since the last revision: >> >> modify the code based on the review > > test/jdk/java/util/Collections/CheckedMapBash.java line 193: > >> 191: m.mer

Re: RFR: 8292955: Collections.checkedMap Map.merge does not properly check key and value [v3]

2024-03-06 Thread Korov
> When the specified key did not associated with a value, should check the > `key` and `value` type. Korov has updated the pull request incrementally with one additional commit since the last revision: Use testNG builtin functionalities and modify the test function name - Change

Re: RFR: 8292955: Collections.checkedMap Map.merge does not properly check key and value [v2]

2024-03-06 Thread Chen Liang
On Thu, 7 Mar 2024 04:13:17 GMT, Korov wrote: >> When the specified key did not associated with a value, should check the >> `key` and `value` type. > > Korov has updated the pull request incrementally with one additional commit > since the last revision: > > modify the code based on the rev

Re: RFR: 8292955: Collections.checkedMap Map.merge does not properly check key and value [v2]

2024-03-06 Thread Korov
On Thu, 7 Mar 2024 03:44:55 GMT, Guoxiong Li wrote: > Good caught. A trivial suggestion. Thanks for your suggestion, the code has been modified. - PR Comment: https://git.openjdk.org/jdk/pull/18141#issuecomment-1982318659

Re: RFR: 8292955: Collections.checkedMap Map.merge does not properly check key and value [v2]

2024-03-06 Thread Korov
> When the specified key did not associated with a value, should check the > `key` and `value` type. Korov has updated the pull request incrementally with one additional commit since the last revision: modify the code based on the review - Changes: - all: https://git.openjdk.o

Re: RFR: 8292955: Collections.checkedMap Map.merge does not properly check key and value

2024-03-06 Thread Guoxiong Li
On Wed, 6 Mar 2024 18:26:16 GMT, Korov wrote: > When the specified key did not associated with a value, should check the > `key` and `value` type. Good caught. A trivial suggestion. test/jdk/java/util/Collections/CheckedMapBash.java line 192: > 190: Map m = Collections.checkedMap(

RFR: 8292955: Collections.checkedMap Map.merge does not properly check key and value

2024-03-06 Thread Korov
When the specified key did not associated with a value, should check the `key` and `value` type. - Commit messages: - 8292955: Collections.checkedMap Map.merge does not properly check key and value - 8292955: Collections.checkedMap Map.merge does not properly check key and value