Re: RFR: 8292914: Drop the counter from lambda class names [v10]

2023-02-27 Thread Roger Riggs
On Fri, 24 Feb 2023 16:16:51 GMT, David M. Lloyd wrote: >> The class generated for lambda proxies is now defined as a hidden class. >> This means that the counter, which was used to ensure a unique class name >> and avoid clashes, is now redundant. In addition to performing redundant >> work,

Re: RFR: 8292914: Drop the counter from lambda class names [v10]

2023-02-27 Thread David M . Lloyd
On Fri, 24 Feb 2023 16:16:51 GMT, David M. Lloyd wrote: >> The class generated for lambda proxies is now defined as a hidden class. >> This means that the counter, which was used to ensure a unique class name >> and avoid clashes, is now redundant. In addition to performing redundant >> work,

Re: RFR: 8292914: Drop the counter from lambda class names [v10]

2023-02-24 Thread Mandy Chung
On Fri, 24 Feb 2023 16:12:29 GMT, David M. Lloyd wrote: >> The class generated for lambda proxies is now defined as a hidden class. >> This means that the counter, which was used to ensure a unique class name >> and avoid clashes, is now redundant. In addition to performing redundant >> work,

Re: RFR: 8292914: Drop the counter from lambda class names [v10]

2023-02-24 Thread David M . Lloyd
> The class generated for lambda proxies is now defined as a hidden class. This > means that the counter, which was used to ensure a unique class name and > avoid clashes, is now redundant. In addition to performing redundant work, > this also impacts build reproducibility for native image gener

Re: RFR: 8292914: Drop the counter from lambda class names [v9]

2023-02-24 Thread Mandy Chung
On Fri, 24 Feb 2023 14:19:40 GMT, David M. Lloyd wrote: >> The class generated for lambda proxies is now defined as a hidden class. >> This means that the counter, which was used to ensure a unique class name >> and avoid clashes, is now redundant. In addition to performing redundant >> work,

Re: RFR: 8292914: Drop the counter from lambda class names [v8]

2023-02-24 Thread David M . Lloyd
On Thu, 23 Feb 2023 23:50:16 GMT, Mandy Chung wrote: >> David M. Lloyd has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Many tests have patterns for lambda class names; update them >> - Update comments and javadoc showin the old patter

Re: RFR: 8292914: Drop the counter from lambda class names [v9]

2023-02-24 Thread David M . Lloyd
> The class generated for lambda proxies is now defined as a hidden class. This > means that the counter, which was used to ensure a unique class name and > avoid clashes, is now redundant. In addition to performing redundant work, > this also impacts build reproducibility for native image gener

Re: RFR: 8292914: Drop the counter from lambda class names [v8]

2023-02-23 Thread Mandy Chung
On Fri, 17 Feb 2023 19:37:59 GMT, David M. Lloyd wrote: >> The class generated for lambda proxies is now defined as a hidden class. >> This means that the counter, which was used to ensure a unique class name >> and avoid clashes, is now redundant. In addition to performing redundant >> work,

Re: RFR: 8292914: Drop the counter from lambda class names [v8]

2023-02-23 Thread Mandy Chung
On Fri, 17 Feb 2023 19:37:59 GMT, David M. Lloyd wrote: >> The class generated for lambda proxies is now defined as a hidden class. >> This means that the counter, which was used to ensure a unique class name >> and avoid clashes, is now redundant. In addition to performing redundant >> work,

Re: RFR: 8292914: Drop the counter from lambda class names [v8]

2023-02-23 Thread David M . Lloyd
On Fri, 17 Feb 2023 19:37:59 GMT, David M. Lloyd wrote: >> The class generated for lambda proxies is now defined as a hidden class. >> This means that the counter, which was used to ensure a unique class name >> and avoid clashes, is now redundant. In addition to performing redundant >> work,

Re: RFR: 8292914: Drop the counter from lambda class names [v8]

2023-02-23 Thread Brian Goetz
On Fri, 17 Feb 2023 19:37:59 GMT, David M. Lloyd wrote: >> The class generated for lambda proxies is now defined as a hidden class. >> This means that the counter, which was used to ensure a unique class name >> and avoid clashes, is now redundant. In addition to performing redundant >> work,

Re: RFR: 8292914: Drop the counter from lambda class names [v8]

2023-02-23 Thread Mandy Chung
On Wed, 22 Feb 2023 16:40:07 GMT, David M. Lloyd wrote: >> David M. Lloyd has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Many tests have patterns for lambda class names; update them >> - Update comments and javadoc showin the old pat

Re: RFR: 8292914: Drop the counter from lambda class names

2023-02-22 Thread John Rose
On 15 Feb 2023, at 10:34, Mandy Chung wrote: On Wed, 15 Feb 2023 17:32:38 GMT, David M. Lloyd wrote: The class generated for lambda proxies is now defined as a hidden class. This means that the counter, which was used to ensure a unique class name and avoid clashes, is now redundant. In add

Re: RFR: 8292914: Drop the counter from lambda class names [v8]

2023-02-22 Thread Ioi Lam
On Fri, 17 Feb 2023 19:37:59 GMT, David M. Lloyd wrote: >> The class generated for lambda proxies is now defined as a hidden class. >> This means that the counter, which was used to ensure a unique class name >> and avoid clashes, is now redundant. In addition to performing redundant >> work,

Re: RFR: 8292914: Drop the counter from lambda class names [v8]

2023-02-22 Thread Mandy Chung
On Fri, 17 Feb 2023 19:37:59 GMT, David M. Lloyd wrote: >> The class generated for lambda proxies is now defined as a hidden class. >> This means that the counter, which was used to ensure a unique class name >> and avoid clashes, is now redundant. In addition to performing redundant >> work,

Re: RFR: 8292914: Drop the counter from lambda class names [v8]

2023-02-22 Thread David M . Lloyd
On Fri, 17 Feb 2023 19:37:59 GMT, David M. Lloyd wrote: >> The class generated for lambda proxies is now defined as a hidden class. >> This means that the counter, which was used to ensure a unique class name >> and avoid clashes, is now redundant. In addition to performing redundant >> work,

Re: RFR: 8292914: Drop the counter from lambda class names [v8]

2023-02-22 Thread Brian Goetz
On Tue, 21 Feb 2023 19:08:30 GMT, Joe Darcy wrote: >> David M. Lloyd has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Many tests have patterns for lambda class names; update them >> - Update comments and javadoc showin the old pattern

Re: RFR: 8292914: Drop the counter from lambda class names [v8]

2023-02-21 Thread Joe Darcy
On Fri, 17 Feb 2023 19:37:59 GMT, David M. Lloyd wrote: >> The class generated for lambda proxies is now defined as a hidden class. >> This means that the counter, which was used to ensure a unique class name >> and avoid clashes, is now redundant. In addition to performing redundant >> work,

Re: RFR: 8292914: Drop the counter from lambda class names [v6]

2023-02-18 Thread Brian Goetz
On Fri, 17 Feb 2023 02:11:10 GMT, Mandy Chung wrote: >> David M. Lloyd has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Use a unique index for the dumped lambda class instead of a time stamp > > `this_class` in the classbyte is shown in t

Re: RFR: 8292914: Drop the counter from lambda class names [v6]

2023-02-17 Thread David M . Lloyd
On Fri, 17 Feb 2023 02:11:10 GMT, Mandy Chung wrote: >> David M. Lloyd has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Use a unique index for the dumped lambda class instead of a time stamp > > `this_class` in the classbyte is shown in t

Re: RFR: 8292914: Drop the counter from lambda class names [v8]

2023-02-17 Thread David M . Lloyd
> The class generated for lambda proxies is now defined as a hidden class. This > means that the counter, which was used to ensure a unique class name and > avoid clashes, is now redundant. In addition to performing redundant work, > this also impacts build reproducibility for native image gener

Re: RFR: 8292914: Drop the counter from lambda class names [v7]

2023-02-17 Thread Brian Goetz
On Fri, 17 Feb 2023 17:02:56 GMT, David M. Lloyd wrote: >> The class generated for lambda proxies is now defined as a hidden class. >> This means that the counter, which was used to ensure a unique class name >> and avoid clashes, is now redundant. In addition to performing redundant >> work,

Re: RFR: 8292914: Drop the counter from lambda class names [v7]

2023-02-17 Thread Ioi Lam
On Fri, 17 Feb 2023 17:02:56 GMT, David M. Lloyd wrote: >> The class generated for lambda proxies is now defined as a hidden class. >> This means that the counter, which was used to ensure a unique class name >> and avoid clashes, is now redundant. In addition to performing redundant >> work,

Re: RFR: 8292914: Drop the counter from lambda class names [v6]

2023-02-17 Thread David M . Lloyd
On Fri, 17 Feb 2023 16:55:28 GMT, Ioi Lam wrote: > Java doesn't guarantee to use unique names even for "regular" classes. You > can use two class loaders that load two completely different classes with the > exact same name. > > How does Graal and qbicc handle this? In qbicc, we keep separate

Re: RFR: 8292914: Drop the counter from lambda class names [v6]

2023-02-17 Thread David M . Lloyd
On Fri, 17 Feb 2023 15:18:25 GMT, Vojin Jovanovic wrote: > We didn't use the cryptographic hash as it is not resilient to the changes > that happen to the bytecode generators of hidden classes. If anything in the > bytecode generation (e.g., in `InnerClassLambdaMetafactory`) changes, the > has

Re: RFR: 8292914: Drop the counter from lambda class names [v6]

2023-02-17 Thread Ioi Lam
On Thu, 16 Feb 2023 19:35:54 GMT, David M. Lloyd wrote: >> The class generated for lambda proxies is now defined as a hidden class. >> This means that the counter, which was used to ensure a unique class name >> and avoid clashes, is now redundant. In addition to performing redundant >> work,

Re: RFR: 8292914: Drop the counter from lambda class names [v7]

2023-02-17 Thread David M . Lloyd
> The class generated for lambda proxies is now defined as a hidden class. This > means that the counter, which was used to ensure a unique class name and > avoid clashes, is now redundant. In addition to performing redundant work, > this also impacts build reproducibility for native image gener

Re: RFR: 8292914: Drop the counter from lambda class names [v6]

2023-02-17 Thread Vojin Jovanovic
On Thu, 16 Feb 2023 19:35:54 GMT, David M. Lloyd wrote: >> The class generated for lambda proxies is now defined as a hidden class. >> This means that the counter, which was used to ensure a unique class name >> and avoid clashes, is now redundant. In addition to performing redundant >> work,

Re: RFR: 8292914: Drop the counter from lambda class names [v6]

2023-02-17 Thread David M . Lloyd
On Thu, 16 Feb 2023 19:35:54 GMT, David M. Lloyd wrote: >> The class generated for lambda proxies is now defined as a hidden class. >> This means that the counter, which was used to ensure a unique class name >> and avoid clashes, is now redundant. In addition to performing redundant >> work,

Re: RFR: 8292914: Drop the counter from lambda class names [v6]

2023-02-17 Thread Vojin Jovanovic
On Thu, 16 Feb 2023 19:35:54 GMT, David M. Lloyd wrote: >> The class generated for lambda proxies is now defined as a hidden class. >> This means that the counter, which was used to ensure a unique class name >> and avoid clashes, is now redundant. In addition to performing redundant >> work,

Re: RFR: 8292914: Drop the counter from lambda class names [v6]

2023-02-16 Thread Mandy Chung
On Thu, 16 Feb 2023 19:35:54 GMT, David M. Lloyd wrote: >> The class generated for lambda proxies is now defined as a hidden class. >> This means that the counter, which was used to ensure a unique class name >> and avoid clashes, is now redundant. In addition to performing redundant >> work,

Re: RFR: 8292914: Drop the counter from lambda class names [v6]

2023-02-16 Thread David M . Lloyd
On Thu, 16 Feb 2023 22:23:09 GMT, ExE Boss wrote: >> The Lamdba class name already ends in `$` - is there a reason we'd need a >> second one when dumping? > > I suggested removing it in: > https://github.com/openjdk/jdk/pull/12579#discussion_r1108941733 Ah I missed that. Sure, I guess that's f

Re: RFR: 8292914: Drop the counter from lambda class names [v6]

2023-02-16 Thread ExE Boss
On Thu, 16 Feb 2023 20:02:36 GMT, David M. Lloyd wrote: >> src/java.base/share/classes/java/lang/invoke/ProxyClassesDumper.java line >> 124: >> >>> 122: } >>> 123: } >>> 124: sb.append(counter.incrementAndGet()); >> >> Suggestion: >> >> sb.append('$').appen

Re: RFR: 8292914: Drop the counter from lambda class names [v6]

2023-02-16 Thread David M . Lloyd
On Thu, 16 Feb 2023 19:37:18 GMT, ExE Boss wrote: >> David M. Lloyd has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Use a unique index for the dumped lambda class instead of a time stamp > > src/java.base/share/classes/java/lang/invoke/I

Re: RFR: 8292914: Drop the counter from lambda class names [v6]

2023-02-16 Thread ExE Boss
On Thu, 16 Feb 2023 19:35:54 GMT, David M. Lloyd wrote: >> The class generated for lambda proxies is now defined as a hidden class. >> This means that the counter, which was used to ensure a unique class name >> and avoid clashes, is now redundant. In addition to performing redundant >> work,

Re: RFR: 8292914: Drop the counter from lambda class names [v6]

2023-02-16 Thread David M . Lloyd
> The class generated for lambda proxies is now defined as a hidden class. This > means that the counter, which was used to ensure a unique class name and > avoid clashes, is now redundant. In addition to performing redundant work, > this also impacts build reproducibility for native image gener

Re: RFR: 8292914: Drop the counter from lambda class names [v5]

2023-02-16 Thread David M . Lloyd
On Thu, 16 Feb 2023 14:06:54 GMT, David M. Lloyd wrote: >> The class generated for lambda proxies is now defined as a hidden class. >> This means that the counter, which was used to ensure a unique class name >> and avoid clashes, is now redundant. In addition to performing redundant >> work,

Re: RFR: 8292914: Drop the counter from lambda class names [v5]

2023-02-16 Thread Ioi Lam
On Thu, 16 Feb 2023 14:06:54 GMT, David M. Lloyd wrote: >> The class generated for lambda proxies is now defined as a hidden class. >> This means that the counter, which was used to ensure a unique class name >> and avoid clashes, is now redundant. In addition to performing redundant >> work,

Re: RFR: 8292914: Drop the counter from lambda class names [v5]

2023-02-16 Thread David M . Lloyd
On Thu, 16 Feb 2023 14:06:54 GMT, David M. Lloyd wrote: >> The class generated for lambda proxies is now defined as a hidden class. >> This means that the counter, which was used to ensure a unique class name >> and avoid clashes, is now redundant. In addition to performing redundant >> work,

Re: RFR: 8292914: Drop the counter from lambda class names [v5]

2023-02-16 Thread David M . Lloyd
> The class generated for lambda proxies is now defined as a hidden class. This > means that the counter, which was used to ensure a unique class name and > avoid clashes, is now redundant. In addition to performing redundant work, > this also impacts build reproducibility for native image gener

Re: RFR: 8292914: Drop the counter from lambda class names [v4]

2023-02-16 Thread David M . Lloyd
On Thu, 16 Feb 2023 01:42:16 GMT, David M. Lloyd wrote: >> The class generated for lambda proxies is now defined as a hidden class. >> This means that the counter, which was used to ensure a unique class name >> and avoid clashes, is now redundant. In addition to performing redundant >> work,

Re: RFR: 8292914: Drop the counter from lambda class names [v4]

2023-02-15 Thread Ioi Lam
On Thu, 16 Feb 2023 01:42:16 GMT, David M. Lloyd wrote: >> The class generated for lambda proxies is now defined as a hidden class. >> This means that the counter, which was used to ensure a unique class name >> and avoid clashes, is now redundant. In addition to performing redundant >> work,

Re: RFR: 8292914: Drop the counter from lambda class names [v4]

2023-02-15 Thread David M . Lloyd
> The class generated for lambda proxies is now defined as a hidden class. This > means that the counter, which was used to ensure a unique class name and > avoid clashes, is now redundant. In addition to performing redundant work, > this also impacts build reproducibility for native image gener

Re: RFR: 8292914: Drop the counter from lambda class names [v3]

2023-02-15 Thread David M . Lloyd
> The class generated for lambda proxies is now defined as a hidden class. This > means that the counter, which was used to ensure a unique class name and > avoid clashes, is now redundant. In addition to performing redundant work, > this also impacts build reproducibility for native image gener

Re: RFR: 8292914: Drop the counter from lambda class names [v2]

2023-02-15 Thread David M . Lloyd
On Wed, 15 Feb 2023 22:44:21 GMT, David M. Lloyd wrote: >> The class generated for lambda proxies is now defined as a hidden class. >> This means that the counter, which was used to ensure a unique class name >> and avoid clashes, is now redundant. In addition to performing redundant >> work,

Re: RFR: 8292914: Drop the counter from lambda class names [v2]

2023-02-15 Thread Mandy Chung
On Wed, 15 Feb 2023 22:44:21 GMT, David M. Lloyd wrote: >> The class generated for lambda proxies is now defined as a hidden class. >> This means that the counter, which was used to ensure a unique class name >> and avoid clashes, is now redundant. In addition to performing redundant >> work,

Re: RFR: 8292914: Drop the counter from lambda class names [v2]

2023-02-15 Thread David M . Lloyd
> The class generated for lambda proxies is now defined as a hidden class. This > means that the counter, which was used to ensure a unique class name and > avoid clashes, is now redundant. In addition to performing redundant work, > this also impacts build reproducibility for native image gener

Re: RFR: 8292914: Drop the counter from lambda class names

2023-02-15 Thread Brian Goetz
On Wed, 15 Feb 2023 20:46:47 GMT, David M. Lloyd wrote: >> The class generated for lambda proxies is now defined as a hidden class. >> This means that the counter, which was used to ensure a unique class name >> and avoid clashes, is now redundant. In addition to performing redundant >> work,

Re: RFR: 8292914: Drop the counter from lambda class names

2023-02-15 Thread David M . Lloyd
On Wed, 15 Feb 2023 17:32:38 GMT, David M. Lloyd wrote: > The class generated for lambda proxies is now defined as a hidden class. This > means that the counter, which was used to ensure a unique class name and > avoid clashes, is now redundant. In addition to performing redundant work, > this

Re: RFR: 8292914: Drop the counter from lambda class names

2023-02-15 Thread David M . Lloyd
On Wed, 15 Feb 2023 17:32:38 GMT, David M. Lloyd wrote: > The class generated for lambda proxies is now defined as a hidden class. This > means that the counter, which was used to ensure a unique class name and > avoid clashes, is now redundant. In addition to performing redundant work, > this

Re: RFR: 8292914: Drop the counter from lambda class names

2023-02-15 Thread Brian Goetz
On Wed, 15 Feb 2023 17:32:38 GMT, David M. Lloyd wrote: > The class generated for lambda proxies is now defined as a hidden class. This > means that the counter, which was used to ensure a unique class name and > avoid clashes, is now redundant. In addition to performing redundant work, > this

Re: RFR: 8292914: Drop the counter from lambda class names

2023-02-15 Thread Mandy Chung
On Wed, 15 Feb 2023 17:32:38 GMT, David M. Lloyd wrote: > The class generated for lambda proxies is now defined as a hidden class. This > means that the counter, which was used to ensure a unique class name and > avoid clashes, is now redundant. In addition to performing redundant work, > this

Re: RFR: 8292914: Drop the counter from lambda class names

2023-02-15 Thread David M . Lloyd
On Wed, 15 Feb 2023 17:32:38 GMT, David M. Lloyd wrote: > The class generated for lambda proxies is now defined as a hidden class. This > means that the counter, which was used to ensure a unique class name and > avoid clashes, is now redundant. In addition to performing redundant work, > this

Re: RFR: 8292914: Drop the counter from lambda class names

2023-02-15 Thread Mandy Chung
On Wed, 15 Feb 2023 17:32:38 GMT, David M. Lloyd wrote: > The class generated for lambda proxies is now defined as a hidden class. This > means that the counter, which was used to ensure a unique class name and > avoid clashes, is now redundant. In addition to performing redundant work, > this

RFR: 8292914: Drop the counter from lambda class names

2023-02-15 Thread David M . Lloyd
The class generated for lambda proxies is now defined as a hidden class. This means that the counter, which was used to ensure a unique class name and avoid clashes, is now redundant. In addition to performing redundant work, this also impacts build reproducibility for native image generators wh