On Tue, 16 Aug 2022 20:01:10 GMT, Lance Andersen wrote:
>> Volker Simonis has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Changed the payload to a more innocent version
>
> This looks OK Volker.
>
> It would be nice if possible to add a
On Tue, 16 Aug 2022 17:34:58 GMT, Volker Simonis wrote:
>> The problem is that after
>> [JDK-8281962](https://bugs.openjdk.org/browse/JDK-8281962) we call `fill()`
>> unconditionally (and before calling `Inflater::inflate()`) in
>> `InflaterInputStream::read()` if `Inflater::needsInput()` is t
On Tue, 16 Aug 2022 09:53:54 GMT, Alan Bateman wrote:
>> I've updated the link in the description (sorry, copy-paste error) and
>> opened a [JBS issue for
>> `fill()`](https://bugs.openjdk.org/browse/JDK-8292427).
>>
>> What else is needed to push this to HEAD?
>>
>> And what do we want to do
On Tue, 16 Aug 2022 17:34:58 GMT, Volker Simonis wrote:
>> The problem is that after
>> [JDK-8281962](https://bugs.openjdk.org/browse/JDK-8281962) we call `fill()`
>> unconditionally (and before calling `Inflater::inflate()`) in
>> `InflaterInputStream::read()` if `Inflater::needsInput()` is t
On Tue, 16 Aug 2022 17:31:33 GMT, Volker Simonis wrote:
>> First of all I just realized that `deflated` is the wrong name, it should
>> actually be `inflated`.
>>
>> The deflated source (in `bytes`) is the payload which triggers the bug and I
>> can't simply change the string to which it decom
On Tue, 16 Aug 2022 11:25:03 GMT, Volker Simonis wrote:
>> test/jdk/java/util/zip/InflaterInputStream/UnexpectedEndOfZlibStream.java
>> line 48:
>>
>>> 46: };
>>> 47: String deflated = "@ObjectiveCName(\"DYNSApi\")\npackage
>>> com.google.apps.dynamite.v1.shared.api;\n\n"+
>>>
> The problem is that after
> [JDK-8281962](https://bugs.openjdk.org/browse/JDK-8281962) we call `fill()`
> unconditionally (and before calling `Inflater::inflate()`) in
> `InflaterInputStream::read()` if `Inflater::needsInput()` is true. This
> misses the case where the native inflater has con
On Tue, 16 Aug 2022 09:41:07 GMT, Alan Bateman wrote:
>> Volker Simonis has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Minor changes regarding indentation, naming and spelling
>
> test/jdk/java/util/zip/InflaterInputStream/UnexpectedEnd
On Tue, 16 Aug 2022 09:15:03 GMT, Volker Simonis wrote:
> And what do we want to do about JDK 19?
It's not a P1 so I don't think it's a change for the RC builds. It is a
regression in 19 so we will need to create a RN-KnownIssue release note (I will
do that).
I agree with Lance's suggestion
On Mon, 15 Aug 2022 20:23:16 GMT, Volker Simonis wrote:
>> The problem is that after
>> [JDK-8281962](https://bugs.openjdk.org/browse/JDK-8281962) we call `fill()`
>> unconditionally (and before calling `Inflater::inflate()`) in
>> `InflaterInputStream::read()` if `Inflater::needsInput()` is t
On Mon, 15 Aug 2022 20:23:16 GMT, Volker Simonis wrote:
>> The problem is that after
>> [JDK-8281962](https://bugs.openjdk.org/browse/JDK-8281962) we call `fill()`
>> unconditionally (and before calling `Inflater::inflate()`) in
>> `InflaterInputStream::read()` if `Inflater::needsInput()` is t
On Tue, 16 Aug 2022 06:26:24 GMT, Alan Bateman wrote:
>> Not sure about this one? `fill()` is specified to throw an `IOException` and
>> `EOFException` is an `IOException`. It probably depends on how you interpret
>> the current "*if an I/O error has occurred*" description in the throws
>> sec
On Mon, 15 Aug 2022 19:42:36 GMT, Volker Simonis wrote:
>> src/java.base/share/classes/java/util/zip/InflaterInputStream.java line 164:
>>
>>> 162: // fill() to avoid an EOF error if no more input
>>> is available and the
>>> 163: // next call to inflate
On Mon, 15 Aug 2022 20:23:16 GMT, Volker Simonis wrote:
>> The problem is that after
>> [JDK-8281962](https://bugs.openjdk.org/browse/JDK-8292327) we call `fill()`
>> unconditionally (and before calling `Inflater::inflate()`) in
>> `InflaterInputStream::read()` if `Inflater::needsInput()` is t
> The problem is that after
> [JDK-8281962](https://bugs.openjdk.org/browse/JDK-8292327) we call `fill()`
> unconditionally (and before calling `Inflater::inflate()`) in
> `InflaterInputStream::read()` if `Inflater::needsInput()` is true. This
> misses the case where the native inflater has con
On Mon, 15 Aug 2022 18:36:11 GMT, Alan Bateman wrote:
>> The problem is that after
>> [JDK-8281962](https://bugs.openjdk.org/browse/JDK-8292327) we call `fill()`
>> unconditionally (and before calling `Inflater::inflate()`) in
>> `InflaterInputStream::read()` if `Inflater::needsInput()` is tru
On Mon, 15 Aug 2022 18:34:17 GMT, Alan Bateman wrote:
>> The problem is that after
>> [JDK-8281962](https://bugs.openjdk.org/browse/JDK-8292327) we call `fill()`
>> unconditionally (and before calling `Inflater::inflate()`) in
>> `InflaterInputStream::read()` if `Inflater::needsInput()` is tru
On Mon, 15 Aug 2022 18:01:15 GMT, Alan Bateman wrote:
>> The problem is that after
>> [JDK-8281962](https://bugs.openjdk.org/browse/JDK-8292327) we call `fill()`
>> unconditionally (and before calling `Inflater::inflate()`) in
>> `InflaterInputStream::read()` if `Inflater::needsInput()` is tru
On Mon, 15 Aug 2022 17:43:27 GMT, Volker Simonis wrote:
> The problem is that after
> [JDK-8281962](https://bugs.openjdk.org/browse/JDK-8292327) we call `fill()`
> unconditionally (and before calling `Inflater::inflate()`) in
> `InflaterInputStream::read()` if `Inflater::needsInput()` is true.
The problem is that after
[JDK-8281962](https://bugs.openjdk.org/browse/JDK-8292327) we call `fill()`
unconditionally (and before calling `Inflater::inflate()`) in
`InflaterInputStream::read()` if `Inflater::needsInput()` is true. This misses
the case where the native inflater has consumed all
20 matches
Mail list logo
