Re: RFR: 8292317: Missing null check for Iterator.forEachRemaining implementations [v2]

2022-11-18 Thread Jaikiran Pai
On Thu, 17 Nov 2022 06:05:40 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which proposes to fix >> https://bugs.openjdk.org/browse/JDK-8292317? >> >> The `java.util.Iterator` has a `forEachRemaining(Consumer >> action)` method. As per its contract, the implementations a

Re: RFR: 8292317: Missing null check for Iterator.forEachRemaining implementations [v2]

2022-11-18 Thread Stuart Marks
On Thu, 17 Nov 2022 06:05:40 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which proposes to fix >> https://bugs.openjdk.org/browse/JDK-8292317? >> >> The `java.util.Iterator` has a `forEachRemaining(Consumer >> action)` method. As per its contract, the implementations a

Re: RFR: 8292317: Missing null check for Iterator.forEachRemaining implementations [v2]

2022-11-17 Thread Jaikiran Pai
On Thu, 17 Nov 2022 20:15:55 GMT, Marcono1234 wrote: >> Jaikiran Pai has updated the pull request incrementally with one additional >> commit since the last revision: >> >> review suggestion - simplify test > > src/java.base/share/classes/java/util/Collections.java line 1718: > >> 1716:

Re: RFR: 8292317: Missing null check for Iterator.forEachRemaining implementations [v2]

2022-11-17 Thread Marcono1234
On Thu, 17 Nov 2022 06:05:40 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which proposes to fix >> https://bugs.openjdk.org/browse/JDK-8292317? >> >> The `java.util.Iterator` has a `forEachRemaining(Consumer >> action)` method. As per its contract, the implementations a

Re: RFR: 8292317: Missing null check for Iterator.forEachRemaining implementations [v2]

2022-11-17 Thread Jaikiran Pai
On Thu, 17 Nov 2022 06:05:40 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which proposes to fix >> https://bugs.openjdk.org/browse/JDK-8292317? >> >> The `java.util.Iterator` has a `forEachRemaining(Consumer >> action)` method. As per its contract, the implementations a

Re: RFR: 8292317: Missing null check for Iterator.forEachRemaining implementations [v2]

2022-11-16 Thread Jaikiran Pai
On Thu, 17 Nov 2022 03:39:37 GMT, Stuart Marks wrote: >> Jaikiran Pai has updated the pull request incrementally with one additional >> commit since the last revision: >> >> review suggestion - simplify test > > test/jdk/java/util/Collections/DelegatingIteratorForEachRemaining.java line > 23

Re: RFR: 8292317: Missing null check for Iterator.forEachRemaining implementations [v2]

2022-11-16 Thread Jaikiran Pai
> Can I please get a review of this change which proposes to fix > https://bugs.openjdk.org/browse/JDK-8292317? > > The `java.util.Iterator` has a `forEachRemaining(Consumer action)` > method. As per its contract, the implementations are expected to throw a > `NullPointerException` if the passe

Re: RFR: 8292317: Missing null check for Iterator.forEachRemaining implementations

2022-11-16 Thread Stuart Marks
On Tue, 15 Nov 2022 02:10:01 GMT, Jaikiran Pai wrote: > Can I please get a review of this change which proposes to fix > https://bugs.openjdk.org/browse/JDK-8292317? > > The `java.util.Iterator` has a `forEachRemaining(Consumer action)` > method. As per its contract, the implementations are ex

Re: RFR: 8292317: Missing null check for Iterator.forEachRemaining implementations

2022-11-14 Thread Athijegannathan Sundararajan
On Tue, 15 Nov 2022 02:10:01 GMT, Jaikiran Pai wrote: > Can I please get a review of this change which proposes to fix > https://bugs.openjdk.org/browse/JDK-8292317? > > The `java.util.Iterator` has a `forEachRemaining(Consumer action)` > method. As per its contract, the implementations are ex

RFR: 8292317: Missing null check for Iterator.forEachRemaining implementations

2022-11-14 Thread Jaikiran Pai
Can I please get a review of this change which proposes to fix https://bugs.openjdk.org/browse/JDK-8292317? The `java.util.Iterator` has a `forEachRemaining(Consumer action)` method. As per its contract, the implementations are expected to throw a `NullPointerException` if the passed `action` i