Re: RFR: 8292043: Incorrect decoding near EOF for stateful decoders like UTF-16 [v2]

2022-08-22 Thread Lance Andersen
On Sun, 21 Aug 2022 23:19:16 GMT, Naoto Sato wrote: >> Fixing incorrect state handling with EOF in `StreamDecoder`. There's a >> `reset()` call to the decoder seeing the EOF before the last `decode()` >> operation to handle the state correctly. Removing the call should not affect >> other case

Re: RFR: 8292043: Incorrect decoding near EOF for stateful decoders like UTF-16 [v2]

2022-08-21 Thread Alan Bateman
On Sun, 21 Aug 2022 23:19:16 GMT, Naoto Sato wrote: >> Fixing incorrect state handling with EOF in `StreamDecoder`. There's a >> `reset()` call to the decoder seeing the EOF before the last `decode()` >> operation to handle the state correctly. Removing the call should not affect >> other case

Re: RFR: 8292043: Incorrect decoding near EOF for stateful decoders like UTF-16 [v2]

2022-08-21 Thread Naoto Sato
On Sat, 20 Aug 2022 08:03:55 GMT, Alan Bateman wrote: >> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Modified the test per review suggestion > > test/jdk/java/io/InputStreamReader/StatefulDecoderNearEOF.java line 53: > >>

Re: RFR: 8292043: Incorrect decoding near EOF for stateful decoders like UTF-16 [v2]

2022-08-21 Thread Naoto Sato
> Fixing incorrect state handling with EOF in `StreamDecoder`. There's a > `reset()` call to the decoder seeing the EOF before the last `decode()` > operation to handle the state correctly. Removing the call should not affect > other cases because `reset()` is issued down the execution. Naoto S

Re: RFR: 8292043: Incorrect decoding near EOF for stateful decoders like UTF-16

2022-08-20 Thread Alan Bateman
On Fri, 19 Aug 2022 16:32:02 GMT, Naoto Sato wrote: > Fixing incorrect state handling with EOF in `StreamDecoder`. There's a > `reset()` call to the decoder seeing the EOF before the last `decode()` > operation to handle the state correctly. Removing the call should not affect > other cases be

Re: RFR: 8292043: Incorrect decoding near EOF for stateful decoders like UTF-16

2022-08-19 Thread Joe Wang
On Fri, 19 Aug 2022 16:32:02 GMT, Naoto Sato wrote: > Fixing incorrect state handling with EOF in `StreamDecoder`. There's a > `reset()` call to the decoder seeing the EOF before the last `decode()` > operation to handle the state correctly. Removing the call should not affect > other cases be

RFR: 8292043: Incorrect decoding near EOF for stateful decoders like UTF-16

2022-08-19 Thread Naoto Sato
Fixing incorrect state handling with EOF in `StreamDecoder`. There's a `reset()` call to the decoder seeing the EOF before the last `decode()` operation to handle the state correctly. Removing the call should not affect other cases because `reset()` is issued down the execution. -