Re: RFR: 8291598: Matcher.appendReplacement should not create new StringBuilder instances [v3]

2023-03-28 Thread Raffaello Giulietti
On Tue, 28 Mar 2023 17:35:22 GMT, Roger Riggs wrote: >> Raffaello Giulietti has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8291598: Matcher.appendReplacement should not create new StringBuilder >> instances >> >> Removed other all

Re: RFR: 8291598: Matcher.appendReplacement should not create new StringBuilder instances [v3]

2023-03-28 Thread Roger Riggs
On Wed, 15 Mar 2023 20:01:05 GMT, Raffaello Giulietti wrote: >> Remove instantiation of `StringBuilder` > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the last revision: > > 8291598: Matcher.appendReplacement should not create new String

Re: RFR: 8291598: Matcher.appendReplacement should not create new StringBuilder instances [v3]

2023-03-28 Thread Raffaello Giulietti
On Wed, 15 Mar 2023 20:01:05 GMT, Raffaello Giulietti wrote: >> Remove instantiation of `StringBuilder` > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the last revision: > > 8291598: Matcher.appendReplacement should not create new String

Re: RFR: 8291598: Matcher.appendReplacement should not create new StringBuilder instances [v2]

2023-03-15 Thread Raffaello Giulietti
On Wed, 15 Mar 2023 18:55:35 GMT, Roger Riggs wrote: >> Raffaello Giulietti has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8291598: Matcher.appendReplacement should not create new StringBuilder >> instances >> >> Fix copyright yea

Re: RFR: 8291598: Matcher.appendReplacement should not create new StringBuilder instances [v3]

2023-03-15 Thread Raffaello Giulietti
> Remove instantiation of `StringBuilder` Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision: 8291598: Matcher.appendReplacement should not create new StringBuilder instances Removed other allocations of StringBuilder when pr

Re: RFR: 8291598: Matcher.appendReplacement should not create new StringBuilder instances [v2]

2023-03-15 Thread Roger Riggs
On Wed, 15 Mar 2023 18:47:09 GMT, Raffaello Giulietti wrote: >> Remove instantiation of `StringBuilder` > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the last revision: > > 8291598: Matcher.appendReplacement should not create new String

Re: RFR: 8291598: Matcher.appendReplacement should not create new StringBuilder instances [v2]

2023-03-15 Thread Raffaello Giulietti
> Remove instantiation of `StringBuilder` Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision: 8291598: Matcher.appendReplacement should not create new StringBuilder instances Fix copyright year - Changes: - al

Re: RFR: 8291598: Matcher.appendReplacement should not create new StringBuilder instances

2023-03-15 Thread Raffaello Giulietti
On Wed, 15 Mar 2023 18:15:02 GMT, Raffaello Giulietti wrote: > Remove instantiation of `StringBuilder` Benchmark for the example in the documentation for `Matcher.appendReplacement()` before BenchmarkMode CntScore Error Units AppendReplacement.testAppen

RFR: 8291598: Matcher.appendReplacement should not create new StringBuilder instances

2023-03-15 Thread Raffaello Giulietti
Remove instantiation of `StringBuilder` - Commit messages: - 8291598: Matcher.appendReplacement should not create new StringBuilder instances Changes: https://git.openjdk.org/jdk/pull/13048/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=13048&range=00 Issue: https://bugs