Re: RFR: 8291454: Missing check for JLI C runtime library in CoreLibraries.gmk [v2]

2022-08-08 Thread Magnus Ihse Bursie
On Mon, 8 Aug 2022 05:44:01 GMT, Julian Waters wrote: >> CoreLibraries.gmk is missing a check for MSVCR_DLL. This results in a >> defined, but empty macro in libjli if it is not defined in the build system, >> which is incorrect > > Julian Waters has updated the pull request with a new target b

Re: RFR: 8291454: Missing check for JLI C runtime library in CoreLibraries.gmk

2022-08-07 Thread Julian Waters
On Thu, 28 Jul 2022 02:20:26 GMT, Julian Waters wrote: > CoreLibraries.gmk is missing a check for MSVCR_DLL. This results in a > defined, but empty macro in libjli if it is not defined in the build system, > which is incorrect Merged with latest, currently awaiting further review and/or sponso

Re: RFR: 8291454: Missing check for JLI C runtime library in CoreLibraries.gmk [v2]

2022-08-07 Thread Julian Waters
> CoreLibraries.gmk is missing a check for MSVCR_DLL. This results in a > defined, but empty macro in libjli if it is not defined in the build system, > which is incorrect Julian Waters has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev exclud

Re: RFR: 8291454: Missing check for JLI C runtime library in CoreLibraries.gmk

2022-08-03 Thread Julian Waters
On Thu, 28 Jul 2022 02:20:26 GMT, Julian Waters wrote: > CoreLibraries.gmk is missing a check for MSVCR_DLL. This results in a > defined, but empty macro in libjli if it is not defined in the build system, > which is incorrect Comment to keep thread alive - PR: https://git.openjd

Re: RFR: 8291454: Missing check for JLI C runtime library in CoreLibraries.gmk

2022-07-28 Thread Erik Joelsson
On Thu, 28 Jul 2022 02:20:26 GMT, Julian Waters wrote: > CoreLibraries.gmk is missing a check for MSVCR_DLL. This results in a > defined, but empty macro in libjli if it is not defined in the build system, > which is incorrect Marked as reviewed by erikj (Reviewer). - PR: https:/

RFR: 8291454: Missing check for JLI C runtime library in CoreLibraries.gmk

2022-07-28 Thread Julian Waters
CoreLibraries.gmk is missing a check for MSVCR_DLL. This results in a defined, but empty macro in libjli if it is not defined in the build system, which is incorrect - Commit messages: - Add missing check in JLI macro definitions Changes: https://git.openjdk.org/jdk/pull/9669/file