Re: RFR: 8288589: Files.readString ignores encoding errors for UTF-16 [v5]

2022-06-23 Thread Alan Bateman
On Wed, 22 Jun 2022 17:41:45 GMT, Naoto Sato wrote: > Done. Thanks, that will be helpful if the test fails. - PR: https://git.openjdk.org/jdk/pull/9193

Re: RFR: 8288589: Files.readString ignores encoding errors for UTF-16 [v5]

2022-06-22 Thread Naoto Sato
On Wed, 22 Jun 2022 10:48:47 GMT, Alan Bateman wrote: >> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Moved `@Test` annotations > > test/jdk/java/nio/file/Files/ReadWriteString.java line 304: > >> 302: throws I

Re: RFR: 8288589: Files.readString ignores encoding errors for UTF-16 [v5]

2022-06-22 Thread Alan Bateman
On Tue, 21 Jun 2022 21:49:58 GMT, Naoto Sato wrote: >> This is a regression caused by the fix to >> [JDK-8286287](https://bugs.openjdk.org/browse/JDK-8286287), which assumed >> the method `String.decodeWithDecoder()` was only invoked with cs.REPLACE >> mode based on the comment "should not hap

Re: RFR: 8288589: Files.readString ignores encoding errors for UTF-16 [v5]

2022-06-21 Thread Naoto Sato
> This is a regression caused by the fix to > [JDK-8286287](https://bugs.openjdk.org/browse/JDK-8286287), which assumed the > method `String.decodeWithDecoder()` was only invoked with cs.REPLACE mode > based on the comment "should not happen". Possibly this refers to the > `String(byte[], int,