Re: RFR: 8288495: [test] Make OutputAnalyzer exception more informative [v3]

2022-06-23 Thread David Holmes
On Thu, 23 Jun 2022 19:01:47 GMT, Roger Riggs wrote: >> The RuntimeException from OutputAnalyzer for expected and unexpected exit >> values should include both the actual and expected values. >> The method `shouldHaveExitvalue` and `shouldNotHaveExitValue` include the >> value expected and the

Re: RFR: 8288495: [test] Make OutputAnalyzer exception more informative [v3]

2022-06-23 Thread Jaikiran Pai
On Thu, 23 Jun 2022 19:01:47 GMT, Roger Riggs wrote: >> The RuntimeException from OutputAnalyzer for expected and unexpected exit >> values should include both the actual and expected values. >> The method `shouldHaveExitvalue` and `shouldNotHaveExitValue` include the >> value expected and the

Re: RFR: 8288495: [test] Make OutputAnalyzer exception more informative [v3]

2022-06-23 Thread Roger Riggs
> The RuntimeException from OutputAnalyzer for expected and unexpected exit > values should include both the actual and expected values. > The method `shouldHaveExitvalue` and `shouldNotHaveExitValue` include the > value expected and the value not expected instead of the actual value > returned.

Re: RFR: 8288495: [test] Make OutputAnalyzer exception more informative [v2]

2022-06-23 Thread Naoto Sato
On Thu, 23 Jun 2022 14:09:20 GMT, Roger Riggs wrote: >> The RuntimeException from OutputAnalyzer for expected and unexpected exit >> values should include both the actual and expected values. >> The method `shouldHaveExitvalue` and `shouldNotHaveExitValue` include the >> value expected and the

Re: RFR: 8288495: [test] Make OutputAnalyzer exception more informative [v2]

2022-06-23 Thread Leonid Mesnik
On Thu, 23 Jun 2022 14:09:20 GMT, Roger Riggs wrote: >> The RuntimeException from OutputAnalyzer for expected and unexpected exit >> values should include both the actual and expected values. >> The method `shouldHaveExitvalue` and `shouldNotHaveExitValue` include the >> value expected and the

Re: RFR: 8288495: [test] Make OutputAnalyzer exception more informative [v2]

2022-06-23 Thread Roger Riggs
> The RuntimeException from OutputAnalyzer for expected and unexpected exit > values should include both the actual and expected values. > The method `shouldHaveExitvalue` and `shouldNotHaveExitValue` include the > value expected and the value not expected instead of the actual value > returned.

Re: RFR: 8288495: [test] Make OutputAnalyzer exception more informative

2022-06-23 Thread Roger Riggs
On Thu, 23 Jun 2022 06:08:49 GMT, David Holmes wrote: >> test/lib/jdk/test/lib/process/OutputAnalyzer.java line 505: >> >>> 503: reportDiagnosticSummary(); >>> 504: throw new RuntimeException("Unexpected to get exit value >>> of [" >>> 505: + notExpec

Re: RFR: 8288495: [test] Make OutputAnalyzer exception more informative

2022-06-23 Thread Roger Riggs
On Thu, 23 Jun 2022 01:13:17 GMT, Jaikiran Pai wrote: >> The RuntimeException from OutputAnalyzer for expected and unexpected exit >> values should include both the actual and expected values. >> The method `shouldHaveExitvalue` and `shouldNotHaveExitValue` include the >> value expected and the

Re: RFR: 8288495: [test] Make OutputAnalyzer exception more informative

2022-06-22 Thread David Holmes
On Thu, 23 Jun 2022 01:40:57 GMT, Naoto Sato wrote: >> The RuntimeException from OutputAnalyzer for expected and unexpected exit >> values should include both the actual and expected values. >> The method `shouldHaveExitvalue` and `shouldNotHaveExitValue` include the >> value expected and the v

Re: RFR: 8288495: [test] Make OutputAnalyzer exception more informative

2022-06-22 Thread Naoto Sato
On Wed, 22 Jun 2022 18:19:56 GMT, Roger Riggs wrote: > The RuntimeException from OutputAnalyzer for expected and unexpected exit > values should include both the actual and expected values. > The method `shouldHaveExitvalue` and `shouldNotHaveExitValue` include the > value expected and the valu

Re: RFR: 8288495: [test] Make OutputAnalyzer exception more informative

2022-06-22 Thread Jaikiran Pai
On Wed, 22 Jun 2022 18:19:56 GMT, Roger Riggs wrote: > The RuntimeException from OutputAnalyzer for expected and unexpected exit > values should include both the actual and expected values. > The method `shouldHaveExitvalue` and `shouldNotHaveExitValue` include the > value expected and the valu

RFR: 8288495: [test] Make OutputAnalyzer exception more informative

2022-06-22 Thread Roger Riggs
The RuntimeException from OutputAnalyzer for expected and unexpected exit values should include both the actual and expected values. The method `shouldHaveExitvalue` and `shouldNotHaveExitValue` include the value expected and the value not expected instead of the actual value returned. The value