Re: [jdk19] RFR: 8287809: Revisit implementation of memory session [v6]

2022-07-08 Thread Jorn Vernee
On Wed, 6 Jul 2022 21:50:36 GMT, Maurizio Cimadamore wrote: >> This is a JDK 19 clone of: https://github.com/openjdk/jdk/pull/9017 > > Maurizio Cimadamore has updated the pull request incrementally with one > additional commit since the last revision: > > Turn non-closeable view back into Me

Re: [jdk19] RFR: 8287809: Revisit implementation of memory session [v4]

2022-07-07 Thread Maurizio Cimadamore
On Wed, 6 Jul 2022 17:07:37 GMT, Jorn Vernee wrote: >> Maurizio Cimadamore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Revert implicit vs. heap session changes > > src/java.base/share/classes/jdk/internal/foreign/abi/aarch64/macos/Ma

Re: [jdk19] RFR: 8287809: Revisit implementation of memory session [v5]

2022-07-07 Thread Maurizio Cimadamore
On Wed, 6 Jul 2022 18:01:28 GMT, Maurizio Cimadamore wrote: >> This is a JDK 19 clone of: https://github.com/openjdk/jdk/pull/9017 > > Maurizio Cimadamore has updated the pull request with a new target base due > to a merge or a rebase. The pull request now contains ten commits: > > - Merge b

Re: [jdk19] RFR: 8287809: Revisit implementation of memory session [v6]

2022-07-07 Thread Maurizio Cimadamore
> This is a JDK 19 clone of: https://github.com/openjdk/jdk/pull/9017 Maurizio Cimadamore has updated the pull request incrementally with one additional commit since the last revision: Turn non-closeable view back into MemorySession impl - Changes: - all: https://git.openjdk.or

Re: [jdk19] RFR: 8287809: Revisit implementation of memory session [v4]

2022-07-07 Thread Jorn Vernee
On Wed, 6 Jul 2022 17:05:51 GMT, Jorn Vernee wrote: >> Maurizio Cimadamore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Revert implicit vs. heap session changes > > src/java.base/share/classes/java/lang/invoke/X-VarHandleSegmentView.j

Re: [jdk19] RFR: 8287809: Revisit implementation of memory session [v4]

2022-07-07 Thread Jorn Vernee
On Fri, 17 Jun 2022 18:39:03 GMT, Maurizio Cimadamore wrote: >> This is a JDK 19 clone of: https://github.com/openjdk/jdk/pull/9017 > > Maurizio Cimadamore has updated the pull request incrementally with one > additional commit since the last revision: > > Revert implicit vs. heap session ch

Re: [jdk19] RFR: 8287809: Revisit implementation of memory session [v4]

2022-07-07 Thread Jorn Vernee
On Fri, 17 Jun 2022 18:39:03 GMT, Maurizio Cimadamore wrote: >> This is a JDK 19 clone of: https://github.com/openjdk/jdk/pull/9017 > > Maurizio Cimadamore has updated the pull request incrementally with one > additional commit since the last revision: > > Revert implicit vs. heap session ch

Re: [jdk19] RFR: 8287809: Revisit implementation of memory session [v5]

2022-07-07 Thread Maurizio Cimadamore
> This is a JDK 19 clone of: https://github.com/openjdk/jdk/pull/9017 Maurizio Cimadamore has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains ten commits: - Merge branch 'master' into memory_session_cleanup - Fix ambiguity between sessi

Re: RFR: 8287809: Revisit implementation of memory session [v4]

2022-06-17 Thread Maurizio Cimadamore
On Fri, 17 Jun 2022 20:39:40 GMT, Maurizio Cimadamore wrote: >> Maurizio Cimadamore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Revert implicit vs. heap session changes > > src/java.base/share/classes/jdk/internal/foreign/AbstractMe

Re: RFR: 8287809: Revisit implementation of memory session [v4]

2022-06-17 Thread Maurizio Cimadamore
On Fri, 17 Jun 2022 18:39:03 GMT, Maurizio Cimadamore wrote: >> This is a JDK 19 clone of: >> https://urldefense.com/v3/__https://github.com/openjdk/jdk/pull/9017__;!!ACWV5N9M2RV99hQ!PTgf-96nF99J6u5zXvgIK8gDa_y-GwCjRZ0uALQAk5zZJ7sIb8lIrdasF6oRY-U2YqR3JXkv4CFtxlWidLpOuYm5qPP4KA$ >> > > Maurizi

Re: RFR: 8287809: Revisit implementation of memory session [v4]

2022-06-17 Thread Maurizio Cimadamore
> This is a JDK 19 clone of: > https://urldefense.com/v3/__https://github.com/openjdk/jdk/pull/9017__;!!ACWV5N9M2RV99hQ!JbqlSnOAQCnoGfGjSR9ODas1vyjzkF4ONduTcHSVCWdjG3CB4-ZhX8llEZg_0mu3-AqmRhVAWY5lZS-IDBMIEaKzWm2ckQ$ > Maurizio Cimadamore has updated the pull request incrementally with one addi

Re: RFR: 8287809: Revisit implementation of memory session [v2]

2022-06-17 Thread Maurizio Cimadamore
On Fri, 17 Jun 2022 18:19:22 GMT, Maurizio Cimadamore wrote: >> This is a JDK 19 clone of: >> https://urldefense.com/v3/__https://github.com/openjdk/jdk/pull/9017__;!!ACWV5N9M2RV99hQ!P7sU9UDKU8tT1iAO9LVvEHY405JOZwI2z8rLL3-ARQTa7ikW-1bYQJvtSC2KTMkZZ2-OCKKdpbjG5qunW-7bt6qpT3197Q$ >> > > Maurizi

Re: RFR: 8287809: Revisit implementation of memory session [v3]

2022-06-17 Thread Maurizio Cimadamore
> This is a JDK 19 clone of: > https://urldefense.com/v3/__https://github.com/openjdk/jdk/pull/9017__;!!ACWV5N9M2RV99hQ!Iad5ZYIBKo6G8OmmBEpmRZekLOyVUfHNgi9JARpVmrUedI3fLRC3VvMwy4h-WDdnsbZ71KGxv99JP5gzdsD4RP7upCEDuQ$ > Maurizio Cimadamore has updated the pull request incrementally with one addi

Re: RFR: 8287809: Revisit implementation of memory session [v2]

2022-06-17 Thread Maurizio Cimadamore
> This is a JDK 19 clone of: > https://urldefense.com/v3/__https://github.com/openjdk/jdk/pull/9017__;!!ACWV5N9M2RV99hQ!PURf47Tx3IHsn4r3Q6t3YUMp-kirS2J1rdJ0hx_W3gPaJy1oHsJ_LsQEmyMD_isGigYq82vk18K6ERWiCmNns5bTKx4HWA$ > Maurizio Cimadamore has updated the pull request with a new target base due t

Re: RFR: 8287809: Revisit implementation of memory session

2022-06-15 Thread Jorn Vernee
On Wed, 15 Jun 2022 18:06:44 GMT, Maurizio Cimadamore wrote: > This is a JDK 19 clone of: https://github.com/openjdk/jdk/pull/9017 Already reviewed in the mainline repo. - Marked as reviewed by jvernee (Reviewer). PR: https://git.openjdk.org/jdk19/pull/22

RFR: 8287809: Revisit implementation of memory session

2022-06-15 Thread Maurizio Cimadamore
This is a JDK 19 clone of: https://github.com/openjdk/jdk/pull/9017 - Commit messages: - Add missing files - Initial push Changes: https://git.openjdk.org/jdk19/pull/22/files Webrev: https://webrevs.openjdk.org/?repo=jdk19&pr=22&range=00 Issue: https://bugs.openjdk.org/browse/JD

Re: RFR: 8287809: Revisit implementation of memory session [v4]

2022-06-15 Thread Maurizio Cimadamore
> This is a cleanup of the memory session implementation. The main new concept > is that `MemorySessionImpl` is split into two parts: there is an > implementation of memory session and then there is a state abstraction > (`MemorySessionImpl.State`). This allows to share the state across multiple

Re: RFR: 8287809: Revisit implementation of memory session [v2]

2022-06-15 Thread Maurizio Cimadamore
On Tue, 7 Jun 2022 13:00:37 GMT, Maurizio Cimadamore wrote: >> This is a cleanup of the memory session implementation. The main new concept >> is that `MemorySessionImpl` is split into two parts: there is an >> implementation of memory session and then there is a state abstraction >> (`Memory

Re: RFR: 8287809: Revisit implementation of memory session [v3]

2022-06-15 Thread Maurizio Cimadamore
> This is a cleanup of the memory session implementation. The main new concept > is that `MemorySessionImpl` is split into two parts: there is an > implementation of memory session and then there is a state abstraction > (`MemorySessionImpl.State`). This allows to share the state across multiple

Re: RFR: 8287809: Revisit implementation of memory session [v2]

2022-06-15 Thread Maurizio Cimadamore
On Wed, 15 Jun 2022 14:55:56 GMT, Jorn Vernee wrote: > I think this looks good overall, but please try to limit the accessibility of > the methods in `State`. Thanks, I'll take another look - PR: https://git.openjdk.org/jdk/pull/9017