Re: RFR: 8285447: StackWalker minimal batch size should be optimized for getCallerClass [v4]

2023-09-12 Thread Brent Christian
On Tue, 12 Sep 2023 21:09:25 GMT, Mandy Chung wrote: >> test/micro/org/openjdk/bench/java/lang/CallerClassBench.java line 45: >> >>> 43: public class CallerClassBench { >>> 44: static final StackWalker INST = >>> StackWalker.getInstance(StackWalker.Option.RETAIN_CLASS_REFERENCE); >>> 45: >

Re: RFR: 8285447: StackWalker minimal batch size should be optimized for getCallerClass [v4]

2023-09-12 Thread Mandy Chung
On Tue, 12 Sep 2023 21:06:15 GMT, Brent Christian wrote: >> Mandy Chung has updated the pull request incrementally with one additional >> commit since the last revision: >> >> cleanup > > test/micro/org/openjdk/bench/java/lang/CallerClassBench.java line 45: > >> 43: public class CallerClassB

Re: RFR: 8285447: StackWalker minimal batch size should be optimized for getCallerClass [v4]

2023-09-12 Thread Brent Christian
On Mon, 11 Sep 2023 17:52:56 GMT, Mandy Chung wrote: >> Typically it will find the caller class at the second stack frame from the >> frame of executing `StackWalker::getCallerClass`. The initial size of the >> buffer can be changed from 8 to 4 (the top 2 elements are reserved for >> impleme

Re: RFR: 8285447: StackWalker minimal batch size should be optimized for getCallerClass [v4]

2023-09-12 Thread Mandy Chung
On Tue, 12 Sep 2023 14:38:07 GMT, Volker Simonis wrote: >> Mandy Chung has updated the pull request incrementally with one additional >> commit since the last revision: >> >> cleanup > > src/java.base/share/classes/java/lang/StackStreamFactory.java line 766: > >> 764: @Override >> 76

Re: RFR: 8285447: StackWalker minimal batch size should be optimized for getCallerClass [v4]

2023-09-12 Thread Volker Simonis
On Mon, 11 Sep 2023 17:52:56 GMT, Mandy Chung wrote: >> Typically it will find the caller class at the second stack frame from the >> frame of executing `StackWalker::getCallerClass`. The initial size of the >> buffer can be changed from 8 to 4 (the top 2 elements are reserved for >> impleme

Re: RFR: 8285447: StackWalker minimal batch size should be optimized for getCallerClass [v4]

2023-09-11 Thread Mandy Chung
> Typically it will find the caller class at the second stack frame from the > frame of executing `StackWalker::getCallerClass`. The initial size of the > buffer can be changed from 8 to 4 (the top 2 elements are reserved for > implementation use). If it fetches another batch, `getCallerClas

Re: RFR: 8285447: StackWalker minimal batch size should be optimized for getCallerClass [v3]

2023-09-11 Thread Mandy Chung
> Typically it will find the caller class at the second stack frame from the > frame of executing `StackWalker::getCallerClass`. The initial size of the > buffer can be changed from 8 to 4 (the top 2 elements are reserved for > implementation use). If it fetches another batch, `getCallerClas

Re: RFR: 8285447: StackWalker minimal batch size should be optimized for getCallerClass [v2]

2023-09-11 Thread Mandy Chung
> Typically it will find the caller class at the second stack frame from the > frame of executing `StackWalker::getCallerClass`. The initial size of the > buffer can be changed from 8 to 4 (the top 2 elements are reserved for > implementation use). If it fetches another batch, `getCallerClas

Re: RFR: 8285447: StackWalker minimal batch size should be optimized for getCallerClass [v2]

2023-09-11 Thread Mandy Chung
On Mon, 11 Sep 2023 12:18:42 GMT, Volker Simonis wrote: >> Mandy Chung has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Review feedback > > src/java.base/share/classes/java/lang/StackStreamFactory.java line 758: > >> 756: * So s

Re: RFR: 8285447: StackWalker minimal batch size should be optimized for getCallerClass [v2]

2023-09-11 Thread Mandy Chung
On Mon, 11 Sep 2023 17:27:15 GMT, Mandy Chung wrote: >> Typically it will find the caller class at the second stack frame from the >> frame of executing `StackWalker::getCallerClass`. The initial size of the >> buffer can be changed from 8 to 4 (the top 2 elements are reserved for >> impleme

Re: RFR: 8285447: StackWalker minimal batch size should be optimized for getCallerClass

2023-09-11 Thread Volker Simonis
On Fri, 8 Sep 2023 16:57:14 GMT, Mandy Chung wrote: > Typically it will find the caller class at the second stack frame from the > frame of executing `StackWalker::getCallerClass`. The initial size of the > buffer can be changed from 8 to 4 (the top 2 elements are reserved for > implementati

RFR: 8285447: StackWalker minimal batch size should be optimized for getCallerClass

2023-09-08 Thread Mandy Chung
Typically it will find the caller class at the second stack frame from the frame of executing `StackWalker::getCallerClass`. The initial size of the buffer can be changed from 8 to 4 (the top 2 elements are reserved for implementation use). If it fetches another batch, `getCallerClass` may b