Re: RFR: 8282319: java.util.Locale method to stream available Locales [v4]

2023-02-27 Thread Roger Riggs
On Mon, 27 Feb 2023 17:37:48 GMT, Justin Lu wrote: >> This PR adds a new method to java.util.Locale which returns Stream >> >> The contents of the Stream are composed of the same underlying elements as >> Locale.getAvailableLocales(). >> >> This method allows streaming of the Locale array with

Re: RFR: 8282319: java.util.Locale method to stream available Locales [v4]

2023-02-27 Thread Lance Andersen
On Mon, 27 Feb 2023 17:32:47 GMT, Justin Lu wrote: > Hi Lance and Roger, I have switched the tag {@return to @return for > consistency. And like you proposed Roger, I will open a separate issue to > address converting the tags. Thank you Justin - PR: https://git.openjdk.org/jdk/p

Re: RFR: 8282319: java.util.Locale method to stream available Locales [v4]

2023-02-27 Thread Lance Andersen
On Mon, 27 Feb 2023 17:37:48 GMT, Justin Lu wrote: >> This PR adds a new method to java.util.Locale which returns Stream >> >> The contents of the Stream are composed of the same underlying elements as >> Locale.getAvailableLocales(). >> >> This method allows streaming of the Locale array with

Re: RFR: 8282319: java.util.Locale method to stream available Locales [v4]

2023-02-27 Thread Justin Lu
On Fri, 24 Feb 2023 22:10:11 GMT, Roger Riggs wrote: >> Makes sense, will look at both Locale and LocaleServiceProviderPool and >> update the methods that are applicable for {@return ..}. Thanks Lance > > That's getting a bit far afield of the original issue; a separate issue might > be a bette

Re: RFR: 8282319: java.util.Locale method to stream available Locales [v4]

2023-02-27 Thread Justin Lu
> This PR adds a new method to java.util.Locale which returns Stream > > The contents of the Stream are composed of the same underlying elements as > Locale.getAvailableLocales(). > > This method allows streaming of the Locale array without creating a defensive > copy. Justin Lu has updated th

Re: RFR: 8282319: java.util.Locale method to stream available Locales [v3]

2023-02-24 Thread Roger Riggs
On Fri, 24 Feb 2023 21:57:41 GMT, Justin Lu wrote: >> OK but then we should be consistent and update all of the methods to use the >> new tag or revert the change for consistency > > Makes sense, will look at both Locale and LocaleServiceProviderPool and > update the methods that are applicabl

Re: RFR: 8282319: java.util.Locale method to stream available Locales [v3]

2023-02-24 Thread Justin Lu
On Fri, 24 Feb 2023 18:58:45 GMT, Lance Andersen wrote: >> From what I saw in other methods, `@return ...` goes on the bottom (like the >> line I removed), but the javadoc 16 tag `{@return ... }` goes on the top. > > OK but then we should be consistent and update all of the methods to use the >

Re: RFR: 8282319: java.util.Locale method to stream available Locales [v3]

2023-02-24 Thread Lance Andersen
On Fri, 24 Feb 2023 18:39:55 GMT, Justin Lu wrote: >> src/java.base/share/classes/sun/util/locale/provider/LocaleServiceProviderPool.java >> line 155: >> >>> 153: * that are provided by each provider, including the JRE. >>> 154: * >>> 155: * @return a stream of the available loca

Re: RFR: 8282319: java.util.Locale method to stream available Locales [v3]

2023-02-24 Thread Justin Lu
> This PR adds a new method to java.util.Locale which returns Stream > > The contents of the Stream are composed of the same underlying elements as > Locale.getAvailableLocales(). > > This method allows streaming of the Locale array without creating a defensive > copy. Justin Lu has updated th

Re: RFR: 8282319: java.util.Locale method to stream available Locales [v2]

2023-02-24 Thread Justin Lu
On Fri, 24 Feb 2023 18:33:20 GMT, Lance Andersen wrote: >> Justin Lu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Doc adjustments, fix method name in test > > src/java.base/share/classes/sun/util/locale/provider/LocaleServiceProviderP

Re: RFR: 8282319: java.util.Locale method to stream available Locales [v2]

2023-02-24 Thread Naoto Sato
On Fri, 24 Feb 2023 18:27:30 GMT, Justin Lu wrote: >> This PR adds a new method to java.util.Locale which returns Stream >> >> The contents of the Stream are composed of the same underlying elements as >> Locale.getAvailableLocales(). >> >> This method allows streaming of the Locale array with

Re: RFR: 8282319: java.util.Locale method to stream available Locales [v2]

2023-02-24 Thread Lance Andersen
On Fri, 24 Feb 2023 18:27:30 GMT, Justin Lu wrote: >> This PR adds a new method to java.util.Locale which returns Stream >> >> The contents of the Stream are composed of the same underlying elements as >> Locale.getAvailableLocales(). >> >> This method allows streaming of the Locale array with

Re: RFR: 8282319: java.util.Locale method to stream available Locales [v2]

2023-02-24 Thread Naoto Sato
On Fri, 24 Feb 2023 18:27:30 GMT, Justin Lu wrote: >> This PR adds a new method to java.util.Locale which returns Stream >> >> The contents of the Stream are composed of the same underlying elements as >> Locale.getAvailableLocales(). >> >> This method allows streaming of the Locale array with

Re: RFR: 8282319: java.util.Locale method to stream available Locales [v2]

2023-02-24 Thread Justin Lu
> This PR adds a new method to java.util.Locale which returns Stream > > The contents of the Stream are composed of the same underlying elements as > Locale.getAvailableLocales(). > > This method allows streaming of the Locale array without creating a defensive > copy. Justin Lu has updated th

Re: RFR: 8282319: java.util.Locale method to stream available Locales

2023-02-23 Thread Naoto Sato
On Fri, 27 Jan 2023 21:48:26 GMT, Justin Lu wrote: > This PR adds a new method to java.util.Locale which returns Stream > > The contents of the Stream are composed of the same underlying elements as > Locale.getAvailableLocales(). > > This method allows streaming of the Locale array without cr

Re: RFR: 8282319: java.util.Locale method to stream available Locales

2023-02-23 Thread Sergey Tsypanov
On Fri, 27 Jan 2023 21:48:26 GMT, Justin Lu wrote: > This PR adds a new method to java.util.Locale which returns Stream > > The contents of the Stream are composed of the same underlying elements as > Locale.getAvailableLocales(). > > This method allows streaming of the Locale array without cr

Re: RFR: 8282319: java.util.Locale method to stream available Locales

2023-02-23 Thread Justin Lu
On Mon, 30 Jan 2023 07:11:57 GMT, Sergey Tsypanov wrote: >> This PR proposes introducing a new method to Locale which returns >> Stream >> >> It involves adding an additional method to _LocaleServiceProviderPool_ that >> returns Stream, which _Locale_ can call. >> >> `LocaleServiceProviderPoo

Re: RFR: 8282319: java.util.Locale method to stream available Locales

2023-02-23 Thread Sergey Tsypanov
On Fri, 27 Jan 2023 21:48:26 GMT, Justin Lu wrote: > This PR proposes introducing a new method to Locale which returns > Stream > > It involves adding an additional method to _LocaleServiceProviderPool_ that > returns Stream, which _Locale_ can call. > > `LocaleServiceProviderPool.streamAllAv

RFR: 8282319: java.util.Locale method to stream available Locales

2023-02-23 Thread Justin Lu
This PR proposes introducing a new method to Locale which returns Stream It involves adding an additional method to _LocaleServiceProviderPool_ that returns Stream, which _Locale_ can call. `LocaleServiceProviderPool.streamAllAvaliableLocales()` does not need a defensive copy of `AllAvailableLo