Re: RFR: 8254711: Add java.security.Provider.getService JFR Event [v2]

2022-09-19 Thread Jaikiran Pai
On Mon, 19 Sep 2022 16:55:01 GMT, Sean Coffey wrote: >> Plus one regarding "too much noise". This event is at the >> Provider.getService() level and would reports all calls regardless the type >> and algorithm. Crypto services which supports the delayed provider selection >> may call Provider.

Re: RFR: 8254711: Add java.security.Provider.getService JFR Event [v2]

2022-09-19 Thread Jaikiran Pai
On Mon, 19 Sep 2022 16:12:18 GMT, Sean Coffey wrote: >> Add a JFR Event for `java.security.Provider.getService(String type, String >> algorithm)` calls. > > Sean Coffey has updated the pull request incrementally with one additional > commit since the last revision: > > update from review com

Re: RFR: 8254711: Add java.security.Provider.getService JFR Event [v2]

2022-09-19 Thread Valerie Peng
On Mon, 19 Sep 2022 16:12:18 GMT, Sean Coffey wrote: >> Add a JFR Event for `java.security.Provider.getService(String type, String >> algorithm)` calls. > > Sean Coffey has updated the pull request incrementally with one additional > commit since the last revision: > > update from review com

Re: RFR: 8254711: Add java.security.Provider.getService JFR Event [v2]

2022-09-19 Thread Sean Coffey
On Mon, 19 Sep 2022 16:43:26 GMT, Valerie Peng wrote: >> Yes, I think this would generate too much noise and detract from the main >> motivation for these events, which is to help users analyze the security of >> algorithms that are being used by their applications at the JCE layer. > > Plus on

Re: RFR: 8254711: Add java.security.Provider.getService JFR Event [v2]

2022-09-19 Thread Valerie Peng
On Mon, 19 Sep 2022 15:52:08 GMT, Sean Mullan wrote: >> I had this as the original design actually. I'm not sure how interesting it >> would be to record such "no-service" type events. It would probably add 2-4 >> times the number of events for this event type to a typical recording, given >>

Re: RFR: 8254711: Add java.security.Provider.getService JFR Event [v2]

2022-09-19 Thread Sean Coffey
> Add a JFR Event for `java.security.Provider.getService(String type, String > algorithm)` calls. Sean Coffey has updated the pull request incrementally with one additional commit since the last revision: update from review comments - Changes: - all: https://git.openjdk.org/jd