On Fri, 14 Jul 2023 16:08:12 GMT, Mandy Chung wrote:
>>> It's looking pretty good.
>>
>> Thank you!
>>
>>> About the test, I don't see `ArrayList::add` in the generated bytecode of
>>> `sub2-13`. The dedup string set is used for the targets of qualified
>>> exports and opens and uses. The mod
On Wed, 5 Jul 2023 23:30:03 GMT, Oliver Kopp wrote:
>> It's looking pretty good.
>>
>> About the test, I don't see `ArrayList::add` in the generated bytecode of
>> `sub2-13`. The dedup string set is used for the targets of qualified
>> exports and opens and uses. The modifiers set of `req
On Wed, 5 Jul 2023 23:30:03 GMT, Oliver Kopp wrote:
>> It's looking pretty good.
>>
>> About the test, I don't see `ArrayList::add` in the generated bytecode of
>> `sub2-13`. The dedup string set is used for the targets of qualified
>> exports and opens and uses. The modifiers set of `req
On Thu, 6 Jul 2023 00:13:05 GMT, Oliver Kopp wrote:
>> Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567):
>> "MethodTooLargeException thrown while creating a jlink image".
>>
>> Java still has a 64kb limit: A method may not be longer than 64kb. The idea
>> of the fix is to spl
On Wed, 5 Jul 2023 23:37:28 GMT, Mandy Chung wrote:
>> Oliver Kopp has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 30 commits:
>>
>> - Merge remote-tracking branch 'upstream/master' into fix-8240567
>> - Reformat
>> - Update te
> Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567):
> "MethodTooLargeException thrown while creating a jlink image".
>
> Java still has a 64kb limit: A method may not be longer than 64kb. The idea
> of the fix is to split up the generated methods in several smaller methods
>
>
On Wed, 5 Jul 2023 22:43:14 GMT, Oliver Kopp wrote:
>> Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567):
>> "MethodTooLargeException thrown while creating a jlink image".
>>
>> Java still has a 64kb limit: A method may not be longer than 64kb. The idea
>> of the fix is to spl
On Wed, 5 Jul 2023 17:25:03 GMT, Mandy Chung wrote:
> It's looking pretty good.
Thank you!
> About the test, I don't see `ArrayList::add` in the generated bytecode of
> `sub2-13`. The dedup string set is used for the targets of qualified exports
> and opens and uses. The modifiers set of `req
> Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567):
> "MethodTooLargeException thrown while creating a jlink image".
>
> Java still has a 64kb limit: A method may not be longer than 64kb. The idea
> of the fix is to split up the generated methods in several smaller methods
>
>
> Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567):
> "MethodTooLargeException thrown while creating a jlink image".
>
> Java still has a 64kb limit: A method may not be longer than 64kb. The idea
> of the fix is to split up the generated methods in several smaller methods
>
>
On Tue, 4 Jul 2023 11:00:13 GMT, Oliver Kopp wrote:
>> Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567):
>> "MethodTooLargeException thrown while creating a jlink image".
>>
>> Java still has a 64kb limit: A method may not be longer than 64kb. The idea
>> of the fix is to spl
On Mon, 3 Jul 2023 20:22:30 GMT, Mandy Chung wrote:
> Thanks for the update. Some comments below.
Thank you for the feedback! I didn't see the "proper" usage of effectively
final variables.
> The test you add does not cause new locals be defined in the helper methods.
> Do you think you can
> Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567):
> "MethodTooLargeException thrown while creating a jlink image".
>
> Java still has a 64kb limit: A method may not be longer than 64kb. The idea
> of the fix is to split up the generated methods in several smaller methods
>
>
> Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567):
> "MethodTooLargeException thrown while creating a jlink image".
>
> Java still has a 64kb limit: A method may not be longer than 64kb. The idea
> of the fix is to split up the generated methods in several smaller methods
>
>
> Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567):
> "MethodTooLargeException thrown while creating a jlink image".
>
> Java still has a 64kb limit: A method may not be longer than 64kb. The idea
> of the fix is to split up the generated methods in several smaller methods
>
>
> Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567):
> "MethodTooLargeException thrown while creating a jlink image".
>
> Java still has a 64kb limit: A method may not be longer than 64kb. The idea
> of the fix is to split up the generated methods in several smaller methods
>
>
On Mon, 3 Jul 2023 21:22:36 GMT, Oliver Kopp wrote:
>> `plugins.properties` needs to be updated to show the option added for this
>> plugin.
>>
>> BTW, the current argument described in the usage is out-dated which needs
>> update.
>>
>> system-modules.argument=retainModuleTarget
>
> Added
> Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567):
> "MethodTooLargeException thrown while creating a jlink image".
>
> Java still has a 64kb limit: A method may not be longer than 64kb. The idea
> of the fix is to split up the generated methods in several smaller methods
>
>
> Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567):
> "MethodTooLargeException thrown while creating a jlink image".
>
> Java still has a 64kb limit: A method may not be longer than 64kb. The idea
> of the fix is to split up the generated methods in several smaller methods
>
>
On Mon, 3 Jul 2023 17:09:35 GMT, Mandy Chung wrote:
>> What I meant here is to change the `configure` method to allow the plugin to
>> take an argument for example
>>
>> --system-modules batch-size=100
>>
>>
>> This argument is optional. If not specified, the default value is 75.
>>
On Mon, 3 Jul 2023 20:00:40 GMT, Mandy Chung wrote:
>> Oliver Kopp has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Fix test
>> - Fix ArrayList initialization and off-by-one errors
>
> src/jdk.jlink/share/classes/jdk/tools/jlink/intern
> Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567):
> "MethodTooLargeException thrown while creating a jlink image".
>
> Java still has a 64kb limit: A method may not be longer than 64kb. The idea
> of the fix is to split up the generated methods in several smaller methods
>
>
On Sat, 1 Jul 2023 18:36:10 GMT, Oliver Kopp wrote:
>> Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567):
>> "MethodTooLargeException thrown while creating a jlink image".
>>
>> Java still has a 64kb limit: A method may not be longer than 64kb. The idea
>> of the fix is to spl
On Sat, 1 Jul 2023 10:07:15 GMT, Oliver Kopp wrote:
>> test/jdk/tools/jlink/JLink100Modules.java line 40:
>>
>>> 38: * @library ../lib
>>> 39: * @modules java.base/jdk.internal.jimage
>>> 40: * jdk.jdeps/com.sun.tools.classfile
>>
>> I guess you copied this from other jlink tests.
On Thu, 29 Jun 2023 20:43:59 GMT, Mandy Chung wrote:
>> Oliver Kopp has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix threshold
>
> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/SystemModulesPlugin.java
> line 669:
>
>
On Mon, 3 Jul 2023 17:07:16 GMT, Mandy Chung wrote:
>> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/SystemModulesPlugin.java
>> line 669:
>>
>>> 667: */
>>> 668: private void genModuleDescriptorsMethod(ClassBuilder clb) {
>>> 669: if (moduleInfos.siz
On Mon, 3 Jul 2023 16:21:22 GMT, Mandy Chung wrote:
>> I assume the "old" comments were too detailed. I removed them at
>> [JabRef/jdk@`23bbc0c`
>> (#2)](https://github.com/JabRef/jdk/pull/2/commits/23bbc0ce0c8fd8a4cd689c0260c5fbcb91b20046)
>> to have the code reviewable. I can readd some of t
On Sat, 1 Jul 2023 10:38:05 GMT, Oliver Kopp wrote:
>> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/SystemModulesPlugin.java
>> line 691:
>>
>>> 689: }
>>> 690:
>>> 691: List> splitModuleInfos = new
>>> ArrayList<>();
>>
>> Please add the comments to d
On Sat, 1 Jul 2023 18:36:10 GMT, Oliver Kopp wrote:
>> Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567):
>> "MethodTooLargeException thrown while creating a jlink image".
>>
>> Java still has a 64kb limit: A method may not be longer than 64kb. The idea
>> of the fix is to spl
> Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567):
> "MethodTooLargeException thrown while creating a jlink image".
>
> Java still has a 64kb limit: A method may not be longer than 64kb. The idea
> of the fix is to split up the generated methods in several smaller methods
>
>
> Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567):
> "MethodTooLargeException thrown while creating a jlink image".
>
> Java still has a 64kb limit: A method may not be longer than 64kb. The idea
> of the fix is to split up the generated methods in several smaller methods
>
>
> Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567):
> "MethodTooLargeException thrown while creating a jlink image".
>
> Java still has a 64kb limit: A method may not be longer than 64kb. The idea
> of the fix is to split up the generated methods in several smaller methods
>
>
> Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567):
> "MethodTooLargeException thrown while creating a jlink image".
>
> Java still has a 64kb limit: A method may not be longer than 64kb. The idea
> of the fix is to split up the generated methods in several smaller methods
>
>
> Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567):
> "MethodTooLargeException thrown while creating a jlink image".
>
> Java still has a 64kb limit: A method may not be longer than 64kb. The idea
> of the fix is to split up the generated methods in several smaller methods
>
>
> Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567):
> "MethodTooLargeException thrown while creating a jlink image".
>
> Java still has a 64kb limit: A method may not be longer than 64kb. The idea
> of the fix is to split up the generated methods in several smaller methods
>
>
On Thu, 29 Jun 2023 20:58:53 GMT, Mandy Chung wrote:
>> Oliver Kopp has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix threshold
>
> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/SystemModulesPlugin.java
> line 691:
>
>
On Thu, 29 Jun 2023 20:26:58 GMT, Mandy Chung wrote:
>> Oliver Kopp has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix threshold
>
> test/jdk/tools/jlink/JLink100Modules.java line 40:
>
>> 38: * @library ../lib
>> 39: * @modules java
On Thu, 29 Jun 2023 17:37:02 GMT, Alan Bateman wrote:
> The size of the generated moduleDescriptors is a function of the number of
> modules, the number of packages in the modules, number of exports, ... I
> think your approach is okay for now, meaning pick some threshold that you are
> confid
On Thu, 29 Jun 2023 19:15:15 GMT, Oliver Kopp wrote:
>> Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567):
>> "MethodTooLargeException thrown while creating a jlink image".
>>
>> Java still has a 64kb limit: A method may not be longer than 64kb. The idea
>> of the fix is to sp
On Thu, 29 Jun 2023 20:34:58 GMT, Mandy Chung wrote:
>> Oliver Kopp has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix threshold
>
> test/jdk/tools/jlink/JLink100Modules.java line 47:
>
>> 45: * jdk.compiler
>> 46: * @build
> Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567):
> "MethodTooLargeException thrown while creating a jlink image".
>
> Java still has a 64kb limit: A method may not be longer than 64kb. The idea
> of the fix is to split up the generated methods in several smaller methods
>
>
On Fri, 23 Jun 2023 12:10:33 GMT, Oliver Kopp wrote:
>> Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567):
>> "MethodTooLargeException thrown while creating a jlink image".
>>
>> Java still has a 64kb limit: A method may not be longer than 64kb. The idea
>> of the fix is to sp
> Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567):
> "MethodTooLargeException thrown while creating a jlink image".
>
> Java still has a 64kb limit: A method may not be longer than 64kb. The idea
> of the fix is to split up the generated methods in several smaller methods
>
>
On Mon, 12 Jun 2023 05:03:28 GMT, Alan Bateman wrote:
>> Oliver Kopp has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains five additional
>> commits
On Mon, 12 Jun 2023 05:03:28 GMT, Alan Bateman wrote:
>> Oliver Kopp has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains five additional
>> commits
> Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567):
> "MethodTooLargeException thrown while creating a jlink image".
>
> Java still has a 64kb limit: A method may not be longer than 64kb. The idea
> of the fix is to split up the generated methods in several smaller methods
>
>
On Mon, 12 Jun 2023 05:47:41 GMT, Oliver Kopp wrote:
>> Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567):
>> "MethodTooLargeException thrown while creating a jlink image".
>>
>> Java still has a 64kb limit: A method may not be longer than 64kb. The idea
>> of the fix is to sp
> Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567):
> "MethodTooLargeException thrown while creating a jlink image".
>
> Java still has a 64kb limit: A method may not be longer than 64kb. The idea
> of the fix is to split up the generated methods in several smaller methods
>
>
On Mon, 12 Jun 2023 05:41:08 GMT, Oliver Kopp wrote:
>> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/SystemModulesPlugin.java
>> line 754:
>>
>>> 752: // Restore all (!) sets from parameter to
>>> local variables
>>> 753:
On Mon, 12 Jun 2023 05:02:07 GMT, Alan Bateman wrote:
> Do you mind fixing all the comments as these 160+ lines
Done. I copied the (for me) important comments to the GitHub reply
https://github.com/openjdk/jdk/pull/14408#issuecomment-1586615579.
> You had fixed that in the original PR but it l
On Sun, 11 Jun 2023 21:01:54 GMT, Oliver Kopp wrote:
> Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567):
> "MethodTooLargeException thrown while creating a jlink image".
>
> Java still has a 64kb limit: A method may not be longer than 64kb. The idea
> of the fix is to split u
> Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567):
> "MethodTooLargeException thrown while creating a jlink image".
>
> Java still has a 64kb limit: A method may not be longer than 64kb. The idea
> of the fix is to split up the generated methods in several smaller methods
>
>
On Sun, 11 Jun 2023 21:01:54 GMT, Oliver Kopp wrote:
> Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567):
> "MethodTooLargeException thrown while creating a jlink image".
>
> Java still has a 64kb limit: A method may not be longer than 64kb. The idea
> of the fix is to split u
On Sun, 11 Jun 2023 21:01:54 GMT, Oliver Kopp wrote:
> Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567):
> "MethodTooLargeException thrown while creating a jlink image".
>
> Java still has a 64kb limit: A method may not be longer than 64kb. The idea
> of the fix is to split u
Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567):
"MethodTooLargeException thrown while creating a jlink image".
Java still has a 64kb limit: A method may not be longer than 64kb. The idea of
the fix is to split up the generated methods in several smaller methods
This is a fol
On Thu, 26 Jan 2023 19:30:50 GMT, Christoph wrote:
> We readded the splitting code and the test is passing. In the test we could
> make it work with up to 130 modules where each module _n_ requires all
> modules from _0...n_
The patch looks similar to the original. As a quick test, I changed t
> Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567):
> "MethodTooLargeException thrown while creating a jlink image".
>
> Java still has a 64kb limit: A method may not be longer than 64kb. The idea
> of the fix is to split up the generated methods in several smaller methods
Oli
On Thu, 26 Jan 2023 19:18:52 GMT, Oliver Kopp wrote:
>> Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567):
>> "MethodTooLargeException thrown while creating a jlink image".
>>
>> Java still has a 64kb limit: A method may not be longer than 64kb. The idea
>> of the fix is to sp
> Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567):
> "MethodTooLargeException thrown while creating a jlink image".
>
> Java still has a 64kb limit: A method may not be longer than 64kb. The idea
> of the fix is to split up the generated methods in several smaller methods
Oli
> Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567):
> "MethodTooLargeException thrown while creating a jlink image".
>
> Java still has a 64kb limit: A method may not be longer than 64kb. The idea
> of the fix is to split up the generated methods in several smaller methods
Oli
On Tue, 3 Jan 2023 16:17:41 GMT, Alan Bateman wrote:
>>> Would it be possible to paste in a summary on the VerifyError with the
>>> previous iteration?
>>
>> Isn't this https://github.com/openjdk/jdk/pull/10704#issuecomment-1286106503?
>>
>> Type top (current frame, locals[15]) is not assi
> Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567):
> "MethodTooLargeException thrown while creating a jlink image".
>
> Java still has a 64kb limit: A method may not be longer than 64kb. The idea
> of the fix is to split up the generated methods in several smaller methods
Oli
> Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567):
> "MethodTooLargeException thrown while creating a jlink image".
>
> Java still has a 64kb limit: A method may not be longer than 64kb. The idea
> of the fix is to split up the generated methods in several smaller methods
Oli
> Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567):
> "MethodTooLargeException thrown while creating a jlink image".
>
> Java still has a 64kb limit: A method may not be longer than 64kb. The idea
> of the fix is to split up the generated methods in several smaller methods
Oli
On Thu, 8 Dec 2022 07:41:22 GMT, Oliver Kopp wrote:
>> Would it be possible to paste in a summary on the VerifyError with the
>> previous iteration? If I read the latest update then the limit per helper
>> method has been bump to avoid it, is that right?
>
>> Would it be possible to paste in a
On Thu, 8 Dec 2022 07:41:22 GMT, Oliver Kopp wrote:
>> Would it be possible to paste in a summary on the VerifyError with the
>> previous iteration? If I read the latest update then the limit per helper
>> method has been bump to avoid it, is that right?
>
>> Would it be possible to paste in a
> Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567):
> "MethodTooLargeException thrown while creating a jlink image".
>
> Java still has a 64kb limit: A method may not be longer than 64kb. The idea
> of the fix is to split up the generated methods in several smaller methods
Oli
> Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567):
> "MethodTooLargeException thrown while creating a jlink image".
>
> Java still has a 64kb limit: A method may not be longer than 64kb. The idea
> of the fix is to split up the generated methods in several smaller methods
Oli
> Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567):
> "MethodTooLargeException thrown while creating a jlink image".
>
> Java still has a 64kb limit: A method may not be longer than 64kb. The idea
> of the fix is to split up the generated methods in several smaller methods
Oli
On Thu, 8 Dec 2022 07:41:22 GMT, Oliver Kopp wrote:
> Yes. Then, the compiler still works - and we can try to debug using the test
> case (yet to be finalized).
Okay, so maybe the PR should be returned to draft until it is ready.
-
PR: https://git.openjdk.org/jdk/pull/10704
On Tue, 6 Dec 2022 16:46:02 GMT, Alan Bateman wrote:
> Would it be possible to paste in a summary on the VerifyError with the
> previous iteration?
Isn't this https://github.com/openjdk/jdk/pull/10704#issuecomment-1286106503?
Type top (current frame, locals[15]) is not assignable to refere
On Mon, 5 Dec 2022 21:38:20 GMT, Oliver Kopp wrote:
>> Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567):
>> "MethodTooLargeException thrown while creating a jlink image".
>>
>> Java still has a 64kb limit: A method may not be longer than 64kb. The idea
>> of the fix is to spl
> Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567):
> "MethodTooLargeException thrown while creating a jlink image".
>
> Java still has a 64kb limit: A method may not be longer than 64kb. The idea
> of the fix is to split up the generated methods in several smaller methods
Oli
> Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567):
> "MethodTooLargeException thrown while creating a jlink image".
>
> Java still has a 64kb limit: A method may not be longer than 64kb. The idea
> of the fix is to split up the generated methods in several smaller methods
Oli
On Sun, 16 Oct 2022 16:22:44 GMT, Alan Bateman wrote:
> I think there are still issues. As a quick test, set the maximum number of
> descriptors to generate per method to less than 70, so that you get Sub0,
> Sub1, ... generated. Then try `java -Xlog:init=debug
> -XX:+UnlockDiagnosticVMOptions
On Mon, 17 Oct 2022 06:37:24 GMT, Jaikiran Pai wrote:
> Looking at the existing code (without the proposed changes in this PR), it
> appears that it's not just the number of `moduleInfos` that could impact the
> method size but even details like `requires`, `exports`, `opens` and other
> such
On Fri, 14 Oct 2022 23:12:38 GMT, Oliver Kopp wrote:
>> Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567):
>> "MethodTooLargeException thrown while creating a jlink image".
>>
>> Java still has a 64kb limit: A method may not be longer than 64kb. The idea
>> of the fix is to sp
On Fri, 14 Oct 2022 06:10:11 GMT, Jaikiran Pai wrote:
> Hello Oliver, the GitHub actions job failures appear related to this change.
> For example:
>
> ```
> Error occurred during initialization of boot layer
> java.lang.VerifyError: Method does not expect a return value
I think there are stil
On Fri, 14 Oct 2022 23:12:38 GMT, Oliver Kopp wrote:
>> Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567):
>> "MethodTooLargeException thrown while creating a jlink image".
>>
>> Java still has a 64kb limit: A method may not be longer than 64kb. The idea
>> of the fix is to sp
On Fri, 14 Oct 2022 16:07:44 GMT, Alan Bateman wrote:
>> Oliver Kopp has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Reduce number of included ModuleDescriptors
>
> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/SystemModul
On Fri, 14 Oct 2022 12:25:43 GMT, Alan Bateman wrote:
> Can you look at the tests in test/jdk/tools/jlink, that is where we will need
> to add the test for this.
I looked and started to create some Java files at [`7c39bd3`
(#10704)](https://github.com/openjdk/jdk/pull/10704/commits/7c39bd3ec82
> Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567):
> "MethodTooLargeException thrown while creating a jlink image".
>
> Java still has a 64kb limit: A method may not be longer than 64kb. The idea
> of the fix is to split up the generated methods in several smaller methods
Oli
On Fri, 14 Oct 2022 16:02:21 GMT, Oliver Kopp wrote:
>> Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567):
>> "MethodTooLargeException thrown while creating a jlink image".
>>
>> Java still has a 64kb limit: A method may not be longer than 64kb. The idea
>> of the fix is to sp
> Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567):
> "MethodTooLargeException thrown while creating a jlink image".
>
> Java still has a 64kb limit: A method may not be longer than 64kb. The idea
> of the fix is to split up the generated methods in several smaller methods
Oli
On Fri, 14 Oct 2022 12:22:16 GMT, Oliver Kopp wrote:
>> Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567):
>> "MethodTooLargeException thrown while creating a jlink image".
>>
>> Java still has a 64kb limit: A method may not be longer than 64kb. The idea
>> of the fix is to sp
> Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567):
> "MethodTooLargeException thrown while creating a jlink image".
>
> Java still has a 64kb limit: A method may not be longer than 64kb. The idea
> of the fix is to split up the generated methods in several smaller methods
Oli
On Thu, 13 Oct 2022 21:15:16 GMT, Oliver Kopp wrote:
> Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567):
> "MethodTooLargeException thrown while creating a jlink image".
>
> Java still has a 64kb limit: A method may not be longer than 64kb. The idea
> of the fix is to split u
Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567):
"MethodTooLargeException thrown while creating a jlink image".
Java still has a 64kb limit: A method may not be longer than 64kb. The idea of
the fix is to split up the generated methods in several smaller methods
-
88 matches
Mail list logo
