On Tue, 14 Jan 2025 09:23:35 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this enhancement which proposes to enhance
>> `java.util.zip.Deflater/Inflater` classes to now implement `AutoCloseable`?
>>
>> The actual work for this was done a few years back when we discussed the
>> prop
On Tue, 14 Jan 2025 09:23:35 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this enhancement which proposes to enhance
>> `java.util.zip.Deflater/Inflater` classes to now implement `AutoCloseable`?
>>
>> The actual work for this was done a few years back when we discussed the
>> prop
On Tue, 14 Jan 2025 09:23:35 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this enhancement which proposes to enhance
>> `java.util.zip.Deflater/Inflater` classes to now implement `AutoCloseable`?
>>
>> The actual work for this was done a few years back when we discussed the
>> prop
On Tue, 14 Jan 2025 09:23:35 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this enhancement which proposes to enhance
>> `java.util.zip.Deflater/Inflater` classes to now implement `AutoCloseable`?
>>
>> The actual work for this was done a few years back when we discussed the
>> prop
On Tue, 14 Jan 2025 09:17:59 GMT, Jaikiran Pai wrote:
>> I believe an `@implSpec` only restricts the implementation of this immediate
>> method, such as those seen on default methods, and has no impact on the
>> overrides. If we need to specify something for overrides to abide to, I
>> believe
On Tue, 14 Jan 2025 08:28:38 GMT, Chen Liang wrote:
>> src/java.base/share/classes/java/util/zip/Deflater.java line 66:
>>
>>> 64: * {@code try}-with-resources statement. The {@linkplain
>>> Deflater#close() close() method} simply
>>> 65: * calls {@code end()}. Subclasses should override {@li
> Can I please get a review of this enhancement which proposes to enhance
> `java.util.zip.Deflater/Inflater` classes to now implement `AutoCloseable`?
>
> The actual work for this was done a few years back when we discussed the
> proposed approaches and then I raised a RFR. At that time I could
> Can I please get a review of this enhancement which proposes to enhance
> `java.util.zip.Deflater/Inflater` classes to now implement `AutoCloseable`?
>
> The actual work for this was done a few years back when we discussed the
> proposed approaches and then I raised a RFR. At that time I could
On Tue, 14 Jan 2025 06:35:04 GMT, Alan Bateman wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix javadoc tag ordering - "@throws" after "@return"
>
> src/java.base/share/classes/java/util/zip/Deflater.java line 5
On Tue, 14 Jan 2025 08:18:57 GMT, Alan Bateman wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix javadoc tag ordering - "@throws" after "@return"
>
> src/java.base/share/classes/java/util/zip/Deflater.java line 6
On Wed, 8 Jan 2025 06:01:55 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this enhancement which proposes to enhance
>> `java.util.zip.Deflater/Inflater` classes to now implement `AutoCloseable`?
>>
>> The actual work for this was done a few years back when we discussed the
>> propo
On Wed, 8 Jan 2025 06:01:55 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this enhancement which proposes to enhance
>> `java.util.zip.Deflater/Inflater` classes to now implement `AutoCloseable`?
>>
>> The actual work for this was done a few years back when we discussed the
>> propo
On Wed, 8 Jan 2025 06:01:55 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this enhancement which proposes to enhance
>> `java.util.zip.Deflater/Inflater` classes to now implement `AutoCloseable`?
>>
>> The actual work for this was done a few years back when we discussed the
>> propo
On Wed, 8 Jan 2025 06:01:55 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this enhancement which proposes to enhance
>> `java.util.zip.Deflater/Inflater` classes to now implement `AutoCloseable`?
>>
>> The actual work for this was done a few years back when we discussed the
>> propo
> Can I please get a review of this enhancement which proposes to enhance
> `java.util.zip.Deflater/Inflater` classes to now implement `AutoCloseable`?
>
> The actual work for this was done a few years back when we discussed the
> proposed approaches and then I raised a RFR. At that time I could
On Tue, 7 Jan 2025 20:37:32 GMT, Roger Riggs wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> change "@since" to 25
>
> src/java.base/share/classes/java/util/zip/Deflater.java line 815:
>
>> 813: * than {@link
On Tue, 7 Jan 2025 10:45:09 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this enhancement which proposes to enhance
>> `java.util.zip.Deflater/Inflater` classes to now implement `AutoCloseable`?
>>
>> The actual work for this was done a few years back when we discussed the
>> propo
On Tue, 7 Jan 2025 10:45:09 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this enhancement which proposes to enhance
>> `java.util.zip.Deflater/Inflater` classes to now implement `AutoCloseable`?
>>
>> The actual work for this was done a few years back when we discussed the
>> propo
On Tue, 7 Jan 2025 10:45:09 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this enhancement which proposes to enhance
>> `java.util.zip.Deflater/Inflater` classes to now implement `AutoCloseable`?
>>
>> The actual work for this was done a few years back when we discussed the
>> propo
> Can I please get a review of this enhancement which proposes to enhance
> `java.util.zip.Deflater/Inflater` classes to now implement `AutoCloseable`?
>
> The actual work for this was done a few years back when we discussed the
> proposed approaches and then I raised a RFR. At that time I could
On Mon, 2 Dec 2024 16:55:23 GMT, Roger Riggs wrote:
>> Jaikiran Pai has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 22 additional
>> commits sin
> Can I please get a review of this enhancement which proposes to enhance
> `java.util.zip.Deflater/Inflater` classes to now implement `AutoCloseable`?
>
> The actual work for this was done a few years back when we discussed the
> proposed approaches and then I raised a RFR. At that time I could
On Mon, 2 Dec 2024 05:26:30 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this enhancement which proposes to enhance
>> `java.util.zip.Deflater/Inflater` classes to now implement `AutoCloseable`?
>>
>> The actual work for this was done a few years back when we discussed the
>> propo
On Wed, 27 Nov 2024 07:18:43 GMT, Alan Bateman wrote:
>> Hello Alan,
>>
>>> If it goes ahead as reviewed, then we'll to do some outreach and be
>>> prepared to back out this change in the event that breakage is reported
>>> before GA.
>>
>> I agree that if the `final close()` causes issues,
> Can I please get a review of this enhancement which proposes to enhance
> `java.util.zip.Deflater/Inflater` classes to now implement `AutoCloseable`?
>
> The actual work for this was done a few years back when we discussed the
> proposed approaches and then I raised a RFR. At that time I could
On Wed, 27 Nov 2024 06:26:17 GMT, Jaikiran Pai wrote:
>> Inflater/Deflater date from JDK 1.1 so I think there is some risk to adding
>> a final no-arg close method. I understand that a corpus analysis has been
>> done, and the intention of making it final is for subclasses to know which
>> met
On Tue, 26 Nov 2024 17:36:40 GMT, Alan Bateman wrote:
>> Done.
>
> Inflater/Deflater date from JDK 1.1 so I think there is some risk to adding a
> final no-arg close method. I understand that a corpus analysis has been done,
> and the intention of making it final is for subclasses to know which
On Fri, 15 Nov 2024 11:12:06 GMT, Jaikiran Pai wrote:
>> src/java.base/share/classes/java/util/zip/Inflater.java line 719:
>>
>>> 717: */
>>> 718: @Override
>>> 719: public void close() {
>>
>> Ditto, should this be `final` to be clear about what should be overridden to
>> perform
On Tue, 26 Nov 2024 12:13:20 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this enhancement which proposes to enhance
>> `java.util.zip.Deflater/Inflater` classes to now implement `AutoCloseable`?
>>
>> The actual work for this was done a few years back when we discussed the
>> prop
On Tue, 26 Nov 2024 12:13:20 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this enhancement which proposes to enhance
>> `java.util.zip.Deflater/Inflater` classes to now implement `AutoCloseable`?
>>
>> The actual work for this was done a few years back when we discussed the
>> prop
> Can I please get a review of this enhancement which proposes to enhance
> `java.util.zip.Deflater/Inflater` classes to now implement `AutoCloseable`?
>
> The actual work for this was done a few years back when we discussed the
> proposed approaches and then I raised a RFR. At that time I could
On Tue, 19 Nov 2024 19:28:50 GMT, Stuart Marks wrote:
>> Thank you. It was an oversight that the original javadoc did not call out
>> the NPE, but now is our chance to get it right with a more reasonable
>> exception.
>
> Overall I agree with defining that IllegalStateException is thrown after
On Tue, 26 Nov 2024 07:28:02 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this enhancement which proposes to enhance
>> `java.util.zip.Deflater/Inflater` classes to now implement `AutoCloseable`?
>>
>> The actual work for this was done a few years back when we discussed the
>> prop
On Tue, 26 Nov 2024 07:28:02 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this enhancement which proposes to enhance
>> `java.util.zip.Deflater/Inflater` classes to now implement `AutoCloseable`?
>>
>> The actual work for this was done a few years back when we discussed the
>> prop
> Can I please get a review of this enhancement which proposes to enhance
> `java.util.zip.Deflater/Inflater` classes to now implement `AutoCloseable`?
>
> The actual work for this was done a few years back when we discussed the
> proposed approaches and then I raised a RFR. At that time I could
On Fri, 22 Nov 2024 04:43:55 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this enhancement which proposes to enhance
>> `java.util.zip.Deflater/Inflater` classes to now implement `AutoCloseable`?
>>
>> The actual work for this was done a few years back when we discussed the
>> prop
On Fri, 22 Nov 2024 04:43:55 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this enhancement which proposes to enhance
>> `java.util.zip.Deflater/Inflater` classes to now implement `AutoCloseable`?
>>
>> The actual work for this was done a few years back when we discussed the
>> prop
On Tue, 19 Nov 2024 19:27:39 GMT, Stuart Marks wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> missed a few methods for specifying IllegalStateException
>
> src/java.base/share/classes/java/util/zip/Deflater.java l
> Can I please get a review of this enhancement which proposes to enhance
> `java.util.zip.Deflater/Inflater` classes to now implement `AutoCloseable`?
>
> The actual work for this was done a few years back when we discussed the
> proposed approaches and then I raised a RFR. At that time I could
On Tue, 19 Nov 2024 19:25:30 GMT, Stuart Marks wrote:
>> Hi Jai,
>>
>> I am not convinced we need to call this out specifically at the class level
>> given the classes implements AutoClosable and close indicates it calls end.
>> We will also want to add a Release Note which can help further
> Can I please get a review of this enhancement which proposes to enhance
> `java.util.zip.Deflater/Inflater` classes to now implement `AutoCloseable`?
>
> The actual work for this was done a few years back when we discussed the
> proposed approaches and then I raised a RFR. At that time I could
On Fri, 15 Nov 2024 12:17:47 GMT, Lance Andersen wrote:
>> Stuart in one of his review comments in this PR had noted that:
>>
>>> I think the class specification needs to be clearer about the positioning
>>> of end() and close(). The end() method has done the real work of "closing"
>>> since t
On Fri, 15 Nov 2024 11:15:28 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this enhancement which proposes to enhance
>> `java.util.zip.Deflater/Inflater` classes to now implement `AutoCloseable`?
>>
>> The actual work for this was done a few years back when we discussed the
>> prop
On Fri, 15 Nov 2024 11:19:43 GMT, Jaikiran Pai wrote:
>> src/java.base/share/classes/java/util/zip/Deflater.java line 66:
>>
>>> 64: * usage with try-with-resources, this class implements {@link
>>> AutoCloseable}. The
>>> 65: * {@link #close()} method of this class calls {@code end()} to cle
On Thu, 14 Nov 2024 17:29:06 GMT, Lance Andersen wrote:
>> Jaikiran Pai has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 10 additional
>> commits
On Thu, 7 Nov 2024 14:34:23 GMT, Roger Riggs wrote:
>> Jaikiran Pai has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains nine additional
>> commits s
On Thu, 14 Nov 2024 17:33:34 GMT, Lance Andersen wrote:
>> Jaikiran Pai has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 10 additional
>> commits
On Thu, 14 Nov 2024 20:36:45 GMT, Chen Liang wrote:
>> Hello Chen, corpus analysis shows that there are no subclasses of
>> Inflater/Deflater which have a `close()` method.
>
> Great news! Feel free to make their close final.
I have updated the PR to follow Roger's suggestion of marking this n
> Can I please get a review of this enhancement which proposes to enhance
> `java.util.zip.Deflater/Inflater` classes to now implement `AutoCloseable`?
>
> The actual work for this was done a few years back when we discussed the
> proposed approaches and then I raised a RFR. At that time I could
> Can I please get a review of this enhancement which proposes to enhance
> `java.util.zip.Deflater/Inflater` classes to now implement `AutoCloseable`?
>
> The actual work for this was done a few years back when we discussed the
> proposed approaches and then I raised a RFR. At that time I could
On Thu, 14 Nov 2024 12:28:21 GMT, Jaikiran Pai wrote:
>> I agree with marking these close methods as final as long as the previous
>> corpus search did not find any user-defined close method in subclasses.
>
> Hello Chen, corpus analysis shows that there are no subclasses of
> Inflater/Deflater
On Thu, 14 Nov 2024 04:14:03 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this enhancement which proposes to enhance
>> `java.util.zip.Deflater/Inflater` classes to now implement `AutoCloseable`?
>>
>> The actual work for this was done a few years back when we discussed the
>> prop
On Thu, 14 Nov 2024 04:59:48 GMT, Chen Liang wrote:
>> Hello Roger, I think that's a good idea. At least until there is a real
>> reason for `close()` to be overridden by subclasses. I went back and checked
>> the mailing list discussions (linked in this PR description) and I don't
>> think ma
On Thu, 7 Nov 2024 14:43:41 GMT, Jaikiran Pai wrote:
>> src/java.base/share/classes/java/util/zip/Deflater.java line 902:
>>
>>> 900: */
>>> 901: @Override
>>> 902: public void close() {
>>
>> Can/should this method be final? The real/original cleanup method is `end`
>> and if bo
> Can I please get a review of this enhancement which proposes to enhance
> `java.util.zip.Deflater/Inflater` classes to now implement `AutoCloseable`?
>
> The actual work for this was done a few years back when we discussed the
> proposed approaches and then I raised a RFR. At that time I could
> Can I please get a review of this enhancement which proposes to enhance
> `java.util.zip.Deflater/Inflater` classes to now implement `AutoCloseable`?
>
> The actual work for this was done a few years back when we discussed the
> proposed approaches and then I raised a RFR. At that time I could
On Thu, 7 Nov 2024 14:28:34 GMT, Roger Riggs wrote:
>> Jaikiran Pai has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains nine additional
>> commits s
On Thu, 7 Nov 2024 14:16:36 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this enhancement which proposes to enhance
>> `java.util.zip.Deflater/Inflater` classes to now implement `AutoCloseable`?
>>
>> The actual work for this was done a few years back when we discussed the
>> propo
On Thu, 7 Nov 2024 14:16:36 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this enhancement which proposes to enhance
>> `java.util.zip.Deflater/Inflater` classes to now implement `AutoCloseable`?
>>
>> The actual work for this was done a few years back when we discussed the
>> propo
On Sun, 16 Jun 2024 06:36:00 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this enhancement which proposes to enhance
>> `java.util.zip.Deflater/Inflater` classes to now implement `AutoCloseable`?
>>
>> The actual work for this was done a few years back when we discussed the
>> prop
On Sun, 16 Jun 2024 06:36:00 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this enhancement which proposes to enhance
>> `java.util.zip.Deflater/Inflater` classes to now implement `AutoCloseable`?
>>
>> The actual work for this was done a few years back when we discussed the
>> prop
> Can I please get a review of this enhancement which proposes to enhance
> `java.util.zip.Deflater/Inflater` classes to now implement `AutoCloseable`?
>
> The actual work for this was done a few years back when we discussed the
> proposed approaches and then I raised a RFR. At that time I could
On Thu, 13 Jun 2024 16:02:38 GMT, Chen Liang wrote:
> My suggestion is that our comment should say why we have this check here even
> though there's already an identical check in end().
I now see what you mean. I'll update this appropriately tomorrow.
-
PR Review Comment: https://
On Thu, 13 Jun 2024 14:09:16 GMT, Jaikiran Pai wrote:
>> src/java.base/share/classes/java/util/zip/Deflater.java line 904:
>>
>>> 902: public void close() {
>>> 903: synchronized (zsRef) {
>>> 904: // check if already closed
>>
>> Should we comment `// in case subclasses
On Wed, 12 Jun 2024 21:07:25 GMT, Chen Liang wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> convert the tests to junit
>
> src/java.base/share/classes/java/util/zip/Deflater.java line 904:
>
>> 902: public vo
On Wed, 12 Jun 2024 21:08:35 GMT, Chen Liang wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> convert the tests to junit
>
> test/jdk/java/util/zip/DeflaterClose.java line 2:
>
>> 1: /*
>> 2: * Copyright (c) 2019,
> Can I please get a review of this enhancement which proposes to enhance
> `java.util.zip.Deflater/Inflater` classes to now implement `AutoCloseable`?
>
> The actual work for this was done a few years back when we discussed the
> proposed approaches and then I raised a RFR. At that time I could
On Wed, 12 Jun 2024 10:45:30 GMT, Jaikiran Pai wrote:
> Can I please get a review of this enhancement which proposes to enhance
> `java.util.zip.Deflater/Inflater` classes to now implement `AutoCloseable`?
>
> The actual work for this was done a few years back when we discussed the
> proposed
Can I please get a review of this enhancement which proposes to enhance
`java.util.zip.Deflater/Inflater` classes to now implement `AutoCloseable`?
The actual work for this was done a few years back when we discussed the
proposed approaches and then I raised a RFR. At that time I couldn't take t
69 matches
Mail list logo
