Re: RFR: 8211033: Clean up the processing -classpath argument not to set LM_CLASS

2024-11-10 Thread Jaikiran Pai
On Fri, 8 Nov 2024 08:51:38 GMT, Jaikiran Pai wrote: > Can I please get a review of this change which addresses > https://bugs.openjdk.org/browse/JDK-8211033? > > As noted in that issue, this is a clean up of the code which determines the > "mode" through with the `java` application is being l

Re: RFR: 8211033: Clean up the processing -classpath argument not to set LM_CLASS

2024-11-08 Thread Alan Bateman
On Fri, 8 Nov 2024 08:51:38 GMT, Jaikiran Pai wrote: > Can I please get a review of this change which addresses > https://bugs.openjdk.org/browse/JDK-8211033? > > As noted in that issue, this is a clean up of the code which determines the > "mode" through with the `java` application is being l

Re: RFR: 8211033: Clean up the processing -classpath argument not to set LM_CLASS

2024-11-08 Thread Jaikiran Pai
On Fri, 8 Nov 2024 09:28:07 GMT, Alan Bateman wrote: > On the surface this looks okay but just to double check: this has no impact > on `java -cp -jar app.jar`. The class path in that case is > `app.jar`, the class path specified to -cp is ignored. That's right - the launcher explicitly overr

Re: RFR: 8211033: Clean up the processing -classpath argument not to set LM_CLASS

2024-11-08 Thread Alan Bateman
On Fri, 8 Nov 2024 08:51:38 GMT, Jaikiran Pai wrote: > Can I please get a review of this change which addresses > https://bugs.openjdk.org/browse/JDK-8211033? > > As noted in that issue, this is a clean up of the code which determines the > "mode" through with the `java` application is being l

RFR: 8211033: Clean up the processing -classpath argument not to set LM_CLASS

2024-11-08 Thread Jaikiran Pai
Can I please get a review of this change which addresses https://bugs.openjdk.org/browse/JDK-8211033? As noted in that issue, this is a clean up of the code which determines the "mode" through with the `java` application is being launched. In its current form the presence of `--classpath` (or i