Re: RFR: 8155902: DataOutputStream writeInt creates 2 packets instead of 1 [v4]

2023-07-11 Thread Brian Burkhalter
> Add a disclaimer to `java.io.DataOutputStream` to the effect that it makes no > guarantee as to how the underlying output stream actually writes the bytes > provided to it. Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision: 81559

Re: RFR: 8155902: DataOutputStream writeInt creates 2 packets instead of 1 [v4]

2023-07-11 Thread Alan Bateman
On Tue, 11 Jul 2023 17:31:24 GMT, Brian Burkhalter wrote: >> Add a disclaimer to `java.io.DataOutputStream` to the effect that it makes >> no guarantee as to how the underlying output stream actually writes the >> bytes provided to it. > > Brian Burkhalter has updated the pull request increment

Re: RFR: 8155902: DataOutputStream writeInt creates 2 packets instead of 1 [v3]

2023-07-11 Thread Brian Burkhalter
On Tue, 11 Jul 2023 17:24:11 GMT, Alan Bateman wrote: >> Brian Burkhalter has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8155902: Add verbiage to existing paragraph; remove apiNote > > src/java.base/share/classes/java/io/DataOutputStrea

Re: RFR: 8155902: DataOutputStream writeInt creates 2 packets instead of 1 [v3]

2023-07-11 Thread Alan Bateman
On Tue, 11 Jul 2023 16:48:24 GMT, Brian Burkhalter wrote: >> Add a disclaimer to `java.io.DataOutputStream` to the effect that it makes >> no guarantee as to how the underlying output stream actually writes the >> bytes provided to it. > > Brian Burkhalter has updated the pull request increment

Re: RFR: 8155902: DataOutputStream writeInt creates 2 packets instead of 1 [v2]

2023-07-11 Thread Brian Burkhalter
On Tue, 11 Jul 2023 08:15:34 GMT, Alan Bateman wrote: > In passing, we should probably look into the inconsistency in the > synchronization. This can be addressed in the context of [JDK-8295797](https://bugs.openjdk.org/browse/JDK-8295797). - PR Comment: https://git.openjdk.org/j

Re: RFR: 8155902: DataOutputStream writeInt creates 2 packets instead of 1 [v3]

2023-07-11 Thread Brian Burkhalter
> Add a disclaimer to `java.io.DataOutputStream` to the effect that it makes no > guarantee as to how the underlying output stream actually writes the bytes > provided to it. Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision: 81559

Re: RFR: 8155902: DataOutputStream writeInt creates 2 packets instead of 1 [v2]

2023-07-11 Thread Brian Burkhalter
On Tue, 11 Jul 2023 08:30:43 GMT, Alan Bateman wrote: >> Brian Burkhalter has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8155902: Delete "merely" > > src/java.base/share/classes/java/io/DataOutputStream.java line 44: > >> 42: * the un

Re: RFR: 8155902: DataOutputStream writeInt creates 2 packets instead of 1 [v2]

2023-07-11 Thread Alan Bateman
On Fri, 7 Jul 2023 15:44:06 GMT, Brian Burkhalter wrote: >> Add a disclaimer to `java.io.DataOutputStream` to the effect that it makes >> no guarantee as to how the underlying output stream actually writes the >> bytes provided to it. > > Brian Burkhalter has updated the pull request incrementa

Re: RFR: 8155902: DataOutputStream writeInt creates 2 packets instead of 1 [v2]

2023-07-11 Thread Alan Bateman
On Fri, 7 Jul 2023 15:44:06 GMT, Brian Burkhalter wrote: >> Add a disclaimer to `java.io.DataOutputStream` to the effect that it makes >> no guarantee as to how the underlying output stream actually writes the >> bytes provided to it. > > Brian Burkhalter has updated the pull request incrementa

Re: RFR: 8155902: DataOutputStream writeInt creates 2 packets instead of 1 [v2]

2023-07-10 Thread Brian Burkhalter
On Fri, 7 Jul 2023 18:14:16 GMT, Roger Riggs wrote: >>> I would not want to give any assurances about whether the bytes of an >>> encoded primitive were written individually or as a group. >> >> Would it be helpful to add further verbiage? >> >> For example, the sequence of bytes comprising th

Re: RFR: 8155902: DataOutputStream writeInt creates 2 packets instead of 1 [v2]

2023-07-07 Thread Roger Riggs
On Fri, 7 Jul 2023 17:41:02 GMT, Brian Burkhalter wrote: >> src/java.base/share/classes/java/io/DataOutputStream.java line 44: >> >>> 42: * the underlying output stream, hence there is no guarantee as to >>> 43: * the details of how the bytes are written. >>> 44: * >> >> I'd drop "merely". >

Re: RFR: 8155902: DataOutputStream writeInt creates 2 packets instead of 1

2023-07-07 Thread Daniel Jeliński
On Fri, 7 Jul 2023 15:27:29 GMT, Brian Burkhalter wrote: > Was it actually verified that things are not split up into two or more > packets? It seems that `write(2)` could in fact return a value less than the > number of bytes requested. Yes, the test case included in JBS sends all 4 bytes in

Re: RFR: 8155902: DataOutputStream writeInt creates 2 packets instead of 1 [v2]

2023-07-07 Thread Brian Burkhalter
On Fri, 7 Jul 2023 14:21:23 GMT, Roger Riggs wrote: > I would not want to give any assurances about whether the bytes of an encoded > primitive were written individually or as a group. Would it be helpful to add further verbiage? For example, the sequence of bytes comprising the primitive data

Re: RFR: 8155902: DataOutputStream writeInt creates 2 packets instead of 1 [v2]

2023-07-07 Thread Brian Burkhalter
> Add a disclaimer to `java.io.DataOutputStream` to the effect that it makes no > guarantee as to how the underlying output stream actually writes the bytes > provided to it. Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision: 81559

Re: RFR: 8155902: DataOutputStream writeInt creates 2 packets instead of 1

2023-07-07 Thread Brian Burkhalter
On Thu, 6 Jul 2023 21:40:38 GMT, Brian Burkhalter wrote: > Add a disclaimer to `java.io.DataOutputStream` to the effect that it makes no > guarantee as to how the underlying output stream actually writes the bytes > provided to it. > This issue is reported against JDK 8 and 9. It was fixed in

Re: RFR: 8155902: DataOutputStream writeInt creates 2 packets instead of 1

2023-07-07 Thread Roger Riggs
On Thu, 6 Jul 2023 21:40:38 GMT, Brian Burkhalter wrote: > Add a disclaimer to `java.io.DataOutputStream` to the effect that it makes no > guarantee as to how the underlying output stream actually writes the bytes > provided to it. src/java.base/share/classes/java/io/DataOutputStream.java line

Re: RFR: 8155902: DataOutputStream writeInt creates 2 packets instead of 1

2023-07-06 Thread Daniel Jeliński
On Thu, 6 Jul 2023 21:40:38 GMT, Brian Burkhalter wrote: > Add a disclaimer to `java.io.DataOutputStream` to the effect that it makes no > guarantee as to how the underlying output stream actually writes the bytes > provided to it. This issue is reported against JDK 8 and 9. It was fixed in 16

Re: RFR: 8155902: DataOutputStream writeInt creates 2 packets instead of 1

2023-07-06 Thread Brian Burkhalter
On Thu, 6 Jul 2023 21:40:38 GMT, Brian Burkhalter wrote: > Add a disclaimer to `java.io.DataOutputStream` to the effect that it makes no > guarantee as to how the underlying output stream actually writes the bytes > provided to it. It might be equally reasonable simply to resolve the issue as

RFR: 8155902: DataOutputStream writeInt creates 2 packets instead of 1

2023-07-06 Thread Brian Burkhalter
Add a disclaimer to `java.io.DataOutputStream` to the effect that it makes no guarantee as to how the underlying output stream actually writes the bytes provided to it. - Commit messages: - 8155902: DataOutputStream writeInt creates 2 packets instead of 1 Changes: https://git.open