Re: RFR: 8132995: Matcher$ImmutableMatchResult should be optimized to reduce space usage [v4]

2023-05-18 Thread Stuart Marks
On Wed, 17 May 2023 15:05:53 GMT, Raffaello Giulietti wrote: >> When appropriate and useful, copies only the relevant portion of the >> `CharSequence` to the match result. > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the last revision: >

Re: RFR: 8132995: Matcher$ImmutableMatchResult should be optimized to reduce space usage [v4]

2023-05-17 Thread Raffaello Giulietti
On Wed, 17 May 2023 15:05:53 GMT, Raffaello Giulietti wrote: >> When appropriate and useful, copies only the relevant portion of the >> `CharSequence` to the match result. > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the last revision: >

Re: RFR: 8132995: Matcher$ImmutableMatchResult should be optimized to reduce space usage [v3]

2023-05-17 Thread Claes Redestad
On Wed, 17 May 2023 09:19:10 GMT, Raffaello Giulietti wrote: >> When appropriate and useful, copies only the relevant portion of the >> `CharSequence` to the match result. > > Raffaello Giulietti has updated the pull request with a new target base due > to a merge or a rebase. The incremental

Re: RFR: 8132995: Matcher$ImmutableMatchResult should be optimized to reduce space usage [v3]

2023-05-17 Thread Raffaello Giulietti
On Wed, 17 May 2023 14:42:52 GMT, Claes Redestad wrote: >> Raffaello Giulietti has updated the pull request with a new target base due >> to a merge or a rebase. The incremental webrev excludes the unrelated >> changes brought in by the merge/rebase. The pull request contains five >> additiona

Re: RFR: 8132995: Matcher$ImmutableMatchResult should be optimized to reduce space usage [v4]

2023-05-17 Thread Raffaello Giulietti
> When appropriate and useful, copies only the relevant portion of the > `CharSequence` to the match result. Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision: Simplified text capturing. - Changes: - all: https://

Re: RFR: 8132995: Matcher$ImmutableMatchResult should be optimized to reduce space usage [v2]

2023-05-17 Thread Raffaello Giulietti
On Wed, 17 May 2023 04:50:14 GMT, Stuart Marks wrote: >> src/java.base/share/classes/java/util/regex/Matcher.java line 1381: >> >>> 1379: >>> 1380: // Capture the input sequence as a string on first >>> find >>> 1381: textAsString = captureText(); >> >> Is this

Re: RFR: 8132995: Matcher$ImmutableMatchResult should be optimized to reduce space usage [v2]

2023-05-17 Thread Raffaello Giulietti
On Tue, 16 May 2023 13:29:26 GMT, Claes Redestad wrote: >> Raffaello Giulietti has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Added some randomness in tests. > > src/java.base/share/classes/java/util/regex/Matcher.java line 359: > >> 3

Re: RFR: 8132995: Matcher$ImmutableMatchResult should be optimized to reduce space usage [v2]

2023-05-17 Thread Raffaello Giulietti
On Wed, 17 May 2023 05:24:28 GMT, Stuart Marks wrote: >> Raffaello Giulietti has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Added some randomness in tests. > > src/java.base/share/classes/java/util/regex/Matcher.java line 271: > >> 269

Re: RFR: 8132995: Matcher$ImmutableMatchResult should be optimized to reduce space usage [v3]

2023-05-17 Thread Raffaello Giulietti
> When appropriate and useful, copies only the relevant portion of the > `CharSequence` to the match result. Raffaello Giulietti has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase.

Re: RFR: 8132995: Matcher$ImmutableMatchResult should be optimized to reduce space usage [v2]

2023-05-16 Thread Stuart Marks
On Thu, 11 May 2023 09:22:44 GMT, Raffaello Giulietti wrote: >> When appropriate and useful, copies only the relevant portion of the >> `CharSequence` to the match result. > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the last revision: >

Re: RFR: 8132995: Matcher$ImmutableMatchResult should be optimized to reduce space usage [v2]

2023-05-16 Thread Stuart Marks
On Tue, 16 May 2023 13:38:03 GMT, Claes Redestad wrote: >> Raffaello Giulietti has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Added some randomness in tests. > > src/java.base/share/classes/java/util/regex/Matcher.java line 1381: > >>

Re: RFR: 8132995: Matcher$ImmutableMatchResult should be optimized to reduce space usage [v2]

2023-05-16 Thread Claes Redestad
On Thu, 11 May 2023 09:22:44 GMT, Raffaello Giulietti wrote: >> When appropriate and useful, copies only the relevant portion of the >> `CharSequence` to the match result. > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the last revision: >

Re: RFR: 8132995: Matcher$ImmutableMatchResult should be optimized to reduce space usage [v2]

2023-05-11 Thread Raffaello Giulietti
> When appropriate and useful, copies only the relevant portion of the > `CharSequence` to the match result. Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision: Added some randomness in tests. - Changes: - all: htt

Re: RFR: 8132995: Matcher$ImmutableMatchResult should be optimized to reduce space usage

2023-04-17 Thread Raffaello Giulietti
On Wed, 29 Mar 2023 18:09:22 GMT, Raffaello Giulietti wrote: > When appropriate and useful, copies only the relevant portion of the > `CharSequence` to the match result. @stuart-marks As the reporter of the issue, would this interest you? - PR Comment: https://git.openjdk.org/jdk

RFR: 8132995: Matcher$ImmutableMatchResult should be optimized to reduce space usage

2023-03-29 Thread Raffaello Giulietti
When appropriate and useful, copies only the relevant portion of the `CharSequence` to the match result. - Commit messages: - 8132995: Matcher should be optimized to reduce space usage Changes: https://git.openjdk.org/jdk/pull/13231/files Webrev: https://webrevs.openjdk.org/?repo=