On Thu, 22 Sep 2022 10:22:40 GMT, Raffaello Giulietti
wrote:
>> Add support for named groups to java.util.regex.MatchResult
>
> Raffaello Giulietti has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8065554: MatchResult should provide values
On Thu, 22 Sep 2022 10:22:40 GMT, Raffaello Giulietti
wrote:
>> Add support for named groups to java.util.regex.MatchResult
>
> Raffaello Giulietti has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8065554: MatchResult should provide values
> Add support for named groups to java.util.regex.MatchResult
Raffaello Giulietti has updated the pull request incrementally with one
additional commit since the last revision:
8065554: MatchResult should provide values of named-capturing groups
-
Changes:
- all: https://git.op
On Fri, 2 Sep 2022 17:33:21 GMT, Stuart Marks wrote:
>> Raffaello Giulietti has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8065554: MatchResult should provide values of named-capturing groups
>
> src/java.base/share/classes/java/util/re
> Add support for named groups to java.util.regex.MatchResult
Raffaello Giulietti has updated the pull request incrementally with one
additional commit since the last revision:
8065554: MatchResult should provide values of named-capturing groups
-
Changes:
- all: https://git.op
On Wed, 31 Aug 2022 13:26:32 GMT, Raffaello Giulietti wrote:
>> Add support for named groups to java.util.regex.MatchResult
>
> Raffaello Giulietti has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8065554: MatchResult should provide values o
On Wed, 31 Aug 2022 13:26:32 GMT, Raffaello Giulietti wrote:
>> Add support for named groups to java.util.regex.MatchResult
>
> Raffaello Giulietti has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8065554: MatchResult should provide values o
On Wed, 31 Aug 2022 13:26:32 GMT, Raffaello Giulietti wrote:
>> Add support for named groups to java.util.regex.MatchResult
>
> Raffaello Giulietti has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8065554: MatchResult should provide values o
> Add support for named groups to java.util.regex.MatchResult
Raffaello Giulietti has updated the pull request incrementally with one
additional commit since the last revision:
8065554: MatchResult should provide values of named-capturing groups
-
Changes:
- all: https://git.op
On Mon, 29 Aug 2022 13:49:52 GMT, Raffaello Giulietti wrote:
>> Add support for named groups to java.util.regex.MatchResult
>
> Raffaello Giulietti has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8065554: MatchResult should provide values o
On Tue, 30 Aug 2022 20:17:04 GMT, Raffaello Giulietti wrote:
>> test/jdk/java/util/regex/NamedGroupsTests.java line 45:
>>
>>> 43:
>>> 44: testMatchResultStartEndGroup();
>>> 45: }
>>
>> I haven't gone through all the tests in great detail (yet), but it occurs to
>> me that we pot
On Tue, 30 Aug 2022 19:27:26 GMT, Stuart Marks wrote:
>> Raffaello Giulietti has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8065554: MatchResult should provide values of named-capturing groups
>
> test/jdk/java/util/regex/NamedGroupsTes
On Mon, 29 Aug 2022 13:49:52 GMT, Raffaello Giulietti wrote:
>> Add support for named groups to java.util.regex.MatchResult
>
> Raffaello Giulietti has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8065554: MatchResult should provide values o
On Mon, 29 Aug 2022 13:49:52 GMT, Raffaello Giulietti wrote:
>> Add support for named groups to java.util.regex.MatchResult
>
> Raffaello Giulietti has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8065554: MatchResult should provide values o
On Mon, 29 Aug 2022 13:49:52 GMT, Raffaello Giulietti wrote:
>> Add support for named groups to java.util.regex.MatchResult
>
> Raffaello Giulietti has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8065554: MatchResult should provide values o
On Mon, 29 Aug 2022 13:49:52 GMT, Raffaello Giulietti wrote:
>> Add support for named groups to java.util.regex.MatchResult
>
> Raffaello Giulietti has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8065554: MatchResult should provide values o
> Add support for named groups to java.util.regex.MatchResult
Raffaello Giulietti has updated the pull request incrementally with one
additional commit since the last revision:
8065554: MatchResult should provide values of named-capturing groups
-
Changes:
- all: https://git.op
On Fri, 26 Aug 2022 10:36:41 GMT, Raffaello Giulietti wrote:
>> Add support for named groups to java.util.regex.MatchResult
>
> Raffaello Giulietti has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8065554: MatchResult should provide values o
> Add support for named groups to java.util.regex.MatchResult
Raffaello Giulietti has updated the pull request incrementally with one
additional commit since the last revision:
8065554: MatchResult should provide values of named-capturing groups
-
Changes:
- all: https://git.op
On Thu, 25 Aug 2022 09:24:20 GMT, Raffaello Giulietti wrote:
>> Add support for named groups to java.util.regex.MatchResult
>
> Raffaello Giulietti has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8065554: MatchResult should provide values o
On Thu, 25 Aug 2022 09:24:20 GMT, Raffaello Giulietti wrote:
>> Add support for named groups to java.util.regex.MatchResult
>
> Raffaello Giulietti has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8065554: MatchResult should provide values o
On Wed, 24 Aug 2022 18:22:42 GMT, Raffaello Giulietti wrote:
>> In principle, yes. In practice, I see that `namedGroups` doesn't have an
>> `@throws UnsupportedOperationException` but has an `@implSpec` that says
>> that the default implementation throws `UnsupportedOperationException`. This
>
On Thu, 25 Aug 2022 09:24:20 GMT, Raffaello Giulietti wrote:
>> Add support for named groups to java.util.regex.MatchResult
>
> Raffaello Giulietti has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8065554: MatchResult should provide values o
On Thu, 25 Aug 2022 09:24:20 GMT, Raffaello Giulietti wrote:
>> Add support for named groups to java.util.regex.MatchResult
>
> Raffaello Giulietti has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8065554: MatchResult should provide values o
On Thu, 25 Aug 2022 09:24:20 GMT, Raffaello Giulietti wrote:
>> Add support for named groups to java.util.regex.MatchResult
>
> Raffaello Giulietti has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8065554: MatchResult should provide values o
On Thu, 25 Aug 2022 09:24:20 GMT, Raffaello Giulietti wrote:
>> Add support for named groups to java.util.regex.MatchResult
>
> Raffaello Giulietti has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8065554: MatchResult should provide values o
> Add support for named groups to java.util.regex.MatchResult
Raffaello Giulietti has updated the pull request incrementally with one
additional commit since the last revision:
8065554: MatchResult should provide values of named-capturing groups
-
Changes:
- all: https://git.op
On Wed, 24 Aug 2022 15:48:38 GMT, Raffaello Giulietti wrote:
> Add support for named groups to java.util.regex.MatchResult
Addressed concerns about undocumented `UnsuportedOperationException`.
-
PR: https://git.openjdk.org/jdk/pull/1
On Wed, 24 Aug 2022 17:34:17 GMT, Daniel Fuchs wrote:
>> Not sure.
>> If the convention is to document every single `RuntimeException` that
>> methods invoked by this one could throw, then yes.
>> In other words, should `RuntimeExcpetion`s thrown deep in an invocation
>> stack be documented in
On Wed, 24 Aug 2022 16:12:52 GMT, Raffaello Giulietti wrote:
>> src/java.base/share/classes/java/util/regex/MatchResult.java line 274:
>>
>>> 272: * might be preferable for other reasons.
>>> 273: *
>>> 274: * @since 20
>>
>> Should the method declare that it throws `Uns
On Wed, 24 Aug 2022 16:02:25 GMT, Daniel Fuchs wrote:
>> Add support for named groups to java.util.regex.MatchResult
>
> src/java.base/share/classes/java/util/regex/MatchResult.java line 274:
>
>> 272: * might be preferable for other reasons.
>> 273: *
>> 274: * @since 20
On Wed, 24 Aug 2022 15:48:38 GMT, Raffaello Giulietti wrote:
> Add support for named groups to java.util.regex.MatchResult
src/java.base/share/classes/java/util/regex/MatchResult.java line 274:
> 272: * might be preferable for other reasons.
> 273: *
> 274: * @since 20
Add support for named groups to java.util.regex.MatchResult
-
Commit messages:
- 8065554: MatchResult should provide values of named-capturing groups
Changes: https://git.openjdk.org/jdk/pull/1/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=1&range=00
Issue: https
33 matches
Mail list logo
