Re: RFR: 8003887: File.getCanonicalFile() does not resolve symlinks on MS Windows [v5]

2024-09-04 Thread Alan Bateman
On Wed, 4 Sep 2024 19:03:32 GMT, Brian Burkhalter wrote: >> Return the final path derived from the string returned by `canonicalize0()`. > > Brian Burkhalter has updated the pull request incrementally with one > additional commit since the last revision: > > 8003887: Use Assumptions.assumeTru

Re: RFR: 8003887: File.getCanonicalFile() does not resolve symlinks on MS Windows [v5]

2024-09-04 Thread Brian Burkhalter
> Return the final path derived from the string returned by `canonicalize0()`. Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision: 8003887: Use Assumptions.assumeTrue() and other and other cleanup - Changes: - all: htt

Re: RFR: 8003887: File.getCanonicalFile() does not resolve symlinks on MS Windows [v4]

2024-09-04 Thread Brian Burkhalter
On Wed, 4 Sep 2024 08:40:36 GMT, Alan Bateman wrote: >> Brian Burkhalter has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8003887: Test getCanonicalPath when the path contains links > > src/java.base/windows/native/libjava/WinNTFileSystem

Re: RFR: 8003887: File.getCanonicalFile() does not resolve symlinks on MS Windows [v4]

2024-09-04 Thread Alan Bateman
On Tue, 3 Sep 2024 21:50:32 GMT, Brian Burkhalter wrote: >> Return the final path derived from the string returned by `canonicalize0()`. > > Brian Burkhalter has updated the pull request incrementally with one > additional commit since the last revision: > > 8003887: Test getCanonicalPath whe

Re: RFR: 8003887: File.getCanonicalFile() does not resolve symlinks on MS Windows [v3]

2024-09-03 Thread Brian Burkhalter
On Tue, 3 Sep 2024 18:45:36 GMT, Brian Burkhalter wrote: >> Return the final path derived from the string returned by `canonicalize0()`. > > Brian Burkhalter has updated the pull request incrementally with one > additional commit since the last revision: > > 8003887: If getFinalPath() fails,

Re: RFR: 8003887: File.getCanonicalFile() does not resolve symlinks on MS Windows [v4]

2024-09-03 Thread Brian Burkhalter
> Return the final path derived from the string returned by `canonicalize0()`. Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision: 8003887: Test getCanonicalPath when the path contains links - Changes: - all: https://g

Re: RFR: 8003887: File.getCanonicalFile() does not resolve symlinks on MS Windows [v2]

2024-09-03 Thread Brian Burkhalter
On Tue, 3 Sep 2024 16:00:53 GMT, Brian Burkhalter wrote: >> Brian Burkhalter has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8003887: Free value allocated in and returned by getFinalPath() > > src/java.base/windows/classes/java/io/WinNTF

Re: RFR: 8003887: File.getCanonicalFile() does not resolve symlinks on MS Windows [v3]

2024-09-03 Thread Brian Burkhalter
> Return the final path derived from the string returned by `canonicalize0()`. Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision: 8003887: If getFinalPath() fails, return the string returned by canonicalize0() - Change

Re: RFR: 8003887: File.getCanonicalFile() does not resolve symlinks on MS Windows [v2]

2024-09-03 Thread Brian Burkhalter
On Tue, 3 Sep 2024 15:56:36 GMT, Alan Bateman wrote: > Can you check the tests in java/nio/file. I think they may skip if > Files.createSymbolicLink fails, which it might do some Windows test machines > but not others. >From `Links.java`: // Check if sym links are supported tr

Re: RFR: 8003887: File.getCanonicalFile() does not resolve symlinks on MS Windows [v2]

2024-09-03 Thread Brian Burkhalter
On Fri, 30 Aug 2024 21:39:47 GMT, Brian Burkhalter wrote: >> Return the final path derived from the string returned by `canonicalize0()`. > > Brian Burkhalter has updated the pull request incrementally with one > additional commit since the last revision: > > 8003887: Free value allocated in

Re: RFR: 8003887: File.getCanonicalFile() does not resolve symlinks on MS Windows [v2]

2024-09-03 Thread Alan Bateman
On Tue, 3 Sep 2024 15:41:38 GMT, Brian Burkhalter wrote: > Links can't be created without elevated permissions so I need to investigate > how to do this. I think it's already done in some other tests. Can you check the tests in java/nio/file. I think they may skip if Files.createSymbolicLink f

Re: RFR: 8003887: File.getCanonicalFile() does not resolve symlinks on MS Windows [v2]

2024-09-03 Thread Brian Burkhalter
On Mon, 2 Sep 2024 09:06:59 GMT, Alan Bateman wrote: > Are you planning to add a test for this? Links can't be created without elevated permissions so I need to investigate how to do this. I think it's already done in some other tests. - PR Comment: https://git.openjdk.org/jdk/pul

Re: RFR: 8003887: File.getCanonicalFile() does not resolve symlinks on MS Windows [v2]

2024-09-02 Thread Alan Bateman
On Fri, 30 Aug 2024 21:39:47 GMT, Brian Burkhalter wrote: >> Return the final path derived from the string returned by `canonicalize0()`. > > Brian Burkhalter has updated the pull request incrementally with one > additional commit since the last revision: > > 8003887: Free value allocated in

Re: RFR: 8003887: File.getCanonicalFile() does not resolve symlinks on MS Windows [v2]

2024-08-30 Thread Brian Burkhalter
> Return the final path derived from the string returned by `canonicalize0()`. Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision: 8003887: Free value allocated in and returned by getFinalPath() - Changes: - all: https

Re: RFR: 8003887: File.getCanonicalFile() does not resolve symlinks on MS Windows

2024-08-30 Thread Brian Burkhalter
On Fri, 30 Aug 2024 20:59:18 GMT, Brian Burkhalter wrote: > Return the final path derived from the string returned by `canonicalize0()`. The variable `GetFinalPathNameByHandle_func` is removed from the native code as we no longer care about Windows versions preceding Vista. - PR C

RFR: 8003887: File.getCanonicalFile() does not resolve symlinks on MS Windows

2024-08-30 Thread Brian Burkhalter
Return the final path derived from the string returned by `canonicalize0()`. - Commit messages: - 8003887: File.getCanonicalFile() does not resolve symlinks on MS Windows Changes: https://git.openjdk.org/jdk/pull/20801/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=20801&r