Re: RFR: 6228794: java.text.ChoiceFormat pattern behavior is not well documented. [v2]

2023-09-07 Thread Justin Lu
On Thu, 7 Sep 2023 19:35:06 GMT, Naoto Sato wrote: > This should be excluded from the pattern syntax I presume you meant that the syntax should _include_ the required ascending order of limits. Updated to make this apparent, I also adjusted the syntax a little bit to be more accurate. The prev

Re: RFR: 6228794: java.text.ChoiceFormat pattern behavior is not well documented. [v2]

2023-09-07 Thread Naoto Sato
On Thu, 7 Sep 2023 17:18:33 GMT, Justin Lu wrote: >> src/java.base/share/classes/java/text/ChoiceFormat.java line 136: >> >>> 134: * Limit Relation Format >>> 135: * Limit: >>> 136: * {@code String} that can be parsed as a {@code double} / >>> "∞" ({@code U+221E}) / "-∞" (-{@

Re: RFR: 6228794: java.text.ChoiceFormat pattern behavior is not well documented. [v2]

2023-09-07 Thread Justin Lu
On Wed, 6 Sep 2023 23:04:59 GMT, Naoto Sato wrote: > Could the first choice be more specific? Updated with a more syntactical definition. Please let me know if you think this is _too_ specific. > Also, do SubPatterns need to be sorted with Limits? If I am interpreting the question right, you'

Re: RFR: 6228794: java.text.ChoiceFormat pattern behavior is not well documented. [v2]

2023-09-06 Thread Naoto Sato
On Fri, 1 Sep 2023 22:17:00 GMT, Justin Lu wrote: >> Please review this PR and associated >> [CSR](https://bugs.openjdk.org/browse/JDK-8314546) which expands on the >> `java.text.ChoiceFormat` specification regarding its pattern. >> >> `j.text.ChoiceFormat` provides an example pattern in the c

Re: RFR: 6228794: java.text.ChoiceFormat pattern behavior is not well documented. [v2]

2023-09-01 Thread Justin Lu
> Please review this PR and associated > [CSR](https://bugs.openjdk.org/browse/JDK-8314546) which expands on the > `java.text.ChoiceFormat` specification regarding its pattern. > > `j.text.ChoiceFormat` provides an example pattern in the class description, > but beyond that it does not specify