Re: RFR: 5066247: Refine the spec of equals() and hashCode() for j.text.Format classes [v7]

2023-09-29 Thread Joe Darcy
On Thu, 28 Sep 2023 20:39:29 GMT, Justin Lu wrote: >> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8315720) >> which refines the spec of `equals()` and `hashCode()` in `java.text.Format` >> related classes. >> >> The current spec for most of these methods is either "_Ov

Re: RFR: 5066247: Refine the spec of equals() and hashCode() for j.text.Format classes [v7]

2023-09-28 Thread Justin Lu
> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8315720) > which refines the spec of `equals()` and `hashCode()` in `java.text.Format` > related classes. > > The current spec for most of these methods is either "_Overrides > _" or are incomplete/wrong (i.e. see `ChoiceFor

Re: RFR: 5066247: Refine the spec of equals() and hashCode() for j.text.Format classes [v6]

2023-09-13 Thread Justin Lu
> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8315720) > which refines the spec of `equals()` and `hashCode()` in `java.text.Format` > related classes. > > The current spec for most of these methods is either "_Overrides > _" or are incomplete/wrong (i.e. see `ChoiceFor

Re: RFR: 5066247: Refine the spec of equals() and hashCode() for j.text.Format classes [v5]

2023-09-13 Thread Justin Lu
> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8315720) > which refines the spec of `equals()` and `hashCode()` in `java.text.Format` > related classes. > > The current spec for most of these methods is either "_Overrides > _" or are incomplete/wrong (i.e. see `ChoiceFor

Re: RFR: 5066247: Refine the spec of equals() and hashCode() for j.text.Format classes [v4]

2023-09-06 Thread Naoto Sato
On Wed, 6 Sep 2023 20:52:10 GMT, Justin Lu wrote: >> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8315720) >> which refines the spec of `equals()` and `hashCode()` in `java.text.Format` >> related classes. >> >> The current spec for most of these methods is either "_Ove

Re: RFR: 5066247: Refine the spec of equals() and hashCode() for j.text.Format classes [v4]

2023-09-06 Thread Justin Lu
> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8315720) > which refines the spec of `equals()` and `hashCode()` in `java.text.Format` > related classes. > > The current spec for most of these methods is either "_Overrides > _" or are incomplete/wrong (i.e. see `ChoiceFor

Re: RFR: 5066247: Refine the spec of equals() and hashCode() for j.text.Format classes [v3]

2023-09-05 Thread Justin Lu
On Fri, 1 Sep 2023 22:26:00 GMT, Justin Lu wrote: >> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8315720) >> which refines the spec of `equals()` and `hashCode()` in `java.text.Format` >> related classes. >> >> The current spec for most of these methods is either "_Ove

Re: RFR: 5066247: Refine the spec of equals() and hashCode() for j.text.Format classes [v3]

2023-09-01 Thread Naoto Sato
On Fri, 1 Sep 2023 22:26:00 GMT, Justin Lu wrote: >> Please review this PR which refines the spec of `equals()` and `hashCode()` >> in `java.text.Format` related classes. >> >> The current spec for most of these methods is either "_Overrides >> _" or are incomplete/wrong (i.e. see `ChoiceForm

Re: RFR: 5066247: Refine the spec of equals() and hashCode() for j.text.Format classes [v3]

2023-09-01 Thread Justin Lu
> Please review this PR which refines the spec of `equals()` and `hashCode()` > in `java.text.Format` related classes. > > The current spec for most of these methods is either "_Overrides > _" or are incomplete/wrong (i.e. see `ChoiceFormat`). > > This fix adjusts the spec to provide a consist

Re: RFR: 5066247: Refine the spec of equals() and hashCode() for j.text.Format classes [v2]

2023-09-01 Thread Naoto Sato
On Fri, 1 Sep 2023 19:56:53 GMT, Justin Lu wrote: >> Please review this PR which refines the spec of `equals()` and `hashCode()` >> in `java.text.Format` related classes. >> >> The current spec for most of these methods is either "_Overrides >> _" or are incomplete/wrong (i.e. see `ChoiceForm

Re: RFR: 5066247: Refine the spec of equals() and hashCode() for j.text.Format classes [v2]

2023-09-01 Thread Justin Lu
> Please review this PR which refines the spec of `equals()` and `hashCode()` > in `java.text.Format` related classes. > > The current spec for most of these methods is either "_Overrides > _" or are incomplete/wrong (i.e. see `ChoiceFormat`). > > This fix adjusts the spec to provide a consist

Re: RFR: 5066247: Refine the spec of equals() and hashCode() for j.text.Format classes

2023-08-31 Thread Joe Darcy
On Mon, 28 Aug 2023 21:24:18 GMT, Justin Lu wrote: > Please review this PR which refines the spec of `equals()` and `hashCode()` > in `java.text.Format` related classes. > > The current spec for most of these methods is either "_Overrides > _" or are incomplete/wrong (i.e. see `ChoiceFormat`)

Re: RFR: 5066247: Refine the spec of equals() and hashCode() for j.text.Format classes

2023-08-29 Thread Naoto Sato
On Mon, 28 Aug 2023 21:24:18 GMT, Justin Lu wrote: > Please review this PR which refines the spec of `equals()` and `hashCode()` > in `java.text.Format` related classes. > > The current spec for most of these methods is either "_Overrides > _" or are incomplete/wrong (i.e. see `ChoiceFormat`)

RFR: 5066247: Refine the spec of equals() and hashCode() for j.text.Format classes

2023-08-28 Thread Justin Lu
Please review this PR which refines the spec of `equals()` and `hashCode()` in `java.text.Format` related classes. The current spec for most of these methods is either "_Overrides _" or are incomplete/wrong (i.e. see `ChoiceFormat`). This fix adjusts the spec to provide a consistent definition