On Fri, 16 Dec 2022 18:22:24 GMT, Adam Sotona wrote:
>> **This pull request is not intended for immediate integration to JDK
>> mainline.**
>>
>> This is root pull request with Classfile API implementation, tests and
>> benchmarks initial drop into JDK.
>>
>> Following pull requests consolida
On Mon, 7 Nov 2022 16:28:19 GMT, Adam Sotona wrote:
>> So this will be removed later on in one of the follow up "chicken" PRs?
>
> It will be removed in this PR later, this specific workaround is not intended
> to fall into JDK.
> The CompileInterimLangtools patch represents a way how to make th
> **This pull request is not intended for immediate integration to JDK
> mainline.**
>
> This is root pull request with Classfile API implementation, tests and
> benchmarks initial drop into JDK.
>
> Following pull requests consolidating JDK class files parsing, generating,
> and transforming
> **This pull request is not intended for immediate integration to JDK
> mainline.**
>
> This is root pull request with Classfile API implementation, tests and
> benchmarks initial drop into JDK.
>
> Following pull requests consolidating JDK class files parsing, generating,
> and transforming
> **This pull request is not intended for immediate integration to JDK
> mainline.**
>
> This is root pull request with Classfile API implementation, tests and
> benchmarks initial drop into JDK.
>
> Following pull requests consolidating JDK class files parsing, generating,
> and transforming
> **This pull request is not intended for immediate integration to JDK
> mainline.**
>
> This is root pull request with Classfile API implementation, tests and
> benchmarks initial drop into JDK.
>
> Following pull requests consolidating JDK class files parsing, generating,
> and transforming
> **This pull request is not intended for immediate integration to JDK
> mainline.**
>
> This is root pull request with Classfile API implementation, tests and
> benchmarks initial drop into JDK.
>
> Following pull requests consolidating JDK class files parsing, generating,
> and transforming
On Sun, 27 Nov 2022 01:38:01 GMT, Erik Gahlin wrote:
>> Is the practice of naming the directory `snippets` well-established or
>> mandated? Otherwise I think a name like `snippet-files` (akin to
>> `doc-files`) would be much better, since it indicates that is not a java
>> package name. (These
> **This pull request is not intended for immediate integration to JDK
> mainline.**
>
> This is root pull request with Classfile API implementation, tests and
> benchmarks initial drop into JDK.
>
> Following pull requests consolidating JDK class files parsing, generating,
> and transforming
On Sat, 26 Nov 2022 18:42:39 GMT, Magnus Ihse Bursie wrote:
>> Unfortunately I found only two use cases of external snippets in JDK. One is
>> explicitly excluding the snippets package and the other does not care, so
>> the snippets are included.
>
> Is the practice of naming the directory `sni
On Fri, 25 Nov 2022 15:18:09 GMT, Adam Sotona wrote:
>> I'll fix it, thanks.
>
> Unfortunately I found only two use cases of external snippets in JDK. One is
> explicitly excluding the snippets package and the other does not care, so the
> snippets are included.
Is the practice of naming the d
On Mon, 7 Nov 2022 13:01:41 GMT, Adam Sotona wrote:
>> make/modules/java.base/Java.gmk line 37:
>>
>>> 35:
>>> 36: EXCLUDES += java/lang/doc-files
>>> 37: EXCLUDES += jdk/classfile/snippets
>>
>> I don't like hard-coded excludes like this. Is this the first real-world
>> example of snippets i
12 matches
Mail list logo
