kus KARG
Sent: Sunday, May 18, 2025 10:09 AM
To: core-libs-dev@openjdk.org
Subject: Re: RFC: 8356679: Using CharSequence::getChars internally
Roger,
thank you for your comments.
Following your advice I have splitted the larger work of JDK-8356679
into sub tasks.
I would like to start
Sorry, the posting below was cross-posted by accident.
-Markus
Am 18.05.2025 um 17:09 schrieb Markus KARG:
Roger,
thank you for your comments.
Following your advice I have splitted the larger work of JDK-8356679
into sub tasks.
I would like to start with a first PR implementing the *found
Roger,
thank you for your comments.
Following your advice I have splitted the larger work of JDK-8356679
into sub tasks.
I would like to start with a first PR implementing the *foundational*
work, i. e. optimizing Writer::append for efficiency (JDK-8357183). For
convenience, attached below
Hi Markus,
Starting out with the common case is a good idea for the first PR.
I much prefer a PR with a single goal and that comes to a conclusion and
does not add new features or changes after the PR is submitted.
I tend to lose interest in PRs with lots of churn, it means I have to
re-review
Many of the modified classes derive from a common super class and share
one needed common change (which is one of the points which are easy to
see once you see all of those classes in a single PR, but hard to
explain in plaint-text pre-PR mailing list threads), so at least those
need to be disc
Hi Markus,
A main point was to avoid trying to do everything at once.
The PR comments become hard to follow and intermingled and it takes
longer to get agreement because of the thrash in the PR.
Roger
On 5/13/25 5:05 AM, Markus KARG wrote:
Thank you, Roger.
Actually the method helps in the
Thank you, Roger.
Actually the method helps in the "toString()" variants, too, as in some
places we could *get rid* of "toString()" (which is more work than
"just" a buffer due to the added compression complexity).
In fact, I already took the time to rewrite *all* of them while waiting
for t
Hi Markus,
On the surface, its looks constructive.
I suspect that many of these cases will turn into discussions about the
right/best/better way to buffer the characters.
The getChars method only helps when extracting to a char array, many of
the current implementations create strings as the in
Dear Core Libs Team,
I am hereby requesting comments on JDK-8356679.
I would like to invest some time and set up a PR implementing Chen
Liangs's proposal laid out in
https://bugs.openjdk.org/browse/JDK-8356679. For your convenience, the
text of that JBS is copied below. According to the Devel
