Integrated: 8357681: Fixed the DigitList::toString method causing incorrect results during debugging

2025-05-28 Thread Shaojin Wen
t has now been integrated. Changeset: b7f0f480 Author:Shaojin Wen URL: https://git.openjdk.org/jdk/commit/b7f0f480cefb7295bbd5f8830458b69baf2eaff6 Stats: 6 lines in 1 file changed: 0 ins; 5 del; 1 mod 8357681: Fixed the DigitList::toString method causing incorrect results during

Re: RFR: 8357681: Fixed the DigitList::toString method causing incorrect results during debugging

2025-05-27 Thread Roger Riggs
On Tue, 27 May 2025 19:44:55 GMT, Shaojin Wen wrote: > To test this concurrency problem, we need to build a concurrent competition > test, which is not a simple task, so I did not add it. The label `noreg-hard` would be appropriate to indicate a test was not created due to difficulty. That lab

Re: RFR: 8357681: Fixed the DigitList::toString method causing incorrect results during debugging

2025-05-27 Thread Shaojin Wen
On Tue, 27 May 2025 19:31:44 GMT, Volkan Yazici wrote: > _Nit:_ Would it be an overkill to add a test (verifying `toString` doesn't > spoil the content) to avoid falling on the same slippery slope (i.e., _"Let > me optimize this by reusing the `SB`!"_) again? The original code that calls getSt

Re: RFR: 8357681: Fixed the DigitList::toString method causing incorrect results during debugging

2025-05-27 Thread Shaojin Wen
On Tue, 27 May 2025 17:11:41 GMT, Johannes Döbler wrote: >> When debugging getLong/getDouble/getDecimal of DigitList, the debugger will >> call the DigitList::toString method. At this time, DigitList::toString will >> modify tempBuilder, which will cause incorrect results. > > src/java.base/sha

Re: RFR: 8357681: Fixed the DigitList::toString method causing incorrect results during debugging

2025-05-27 Thread Volkan Yazici
On Sun, 18 May 2025 11:11:32 GMT, Shaojin Wen wrote: > When debugging getLong/getDouble/getDecimal of DigitList, the debugger will > call the DigitList::toString method. At this time, DigitList::toString will > modify tempBuilder, which will cause incorrect results. _Nit:_ Would it be an overk

Re: RFR: 8357681: Fixed the DigitList::toString method causing incorrect results during debugging

2025-05-27 Thread Naoto Sato
On Sun, 18 May 2025 11:11:32 GMT, Shaojin Wen wrote: > When debugging getLong/getDouble/getDecimal of DigitList, the debugger will > call the DigitList::toString method. At this time, DigitList::toString will > modify tempBuilder, which will cause incorrect results. LGTM - Marked

Re: RFR: 8357681: Fixed the DigitList::toString method causing incorrect results during debugging

2025-05-27 Thread Johannes Döbler
On Sun, 18 May 2025 11:11:32 GMT, Shaojin Wen wrote: > When debugging getLong/getDouble/getDecimal of DigitList, the debugger will > call the DigitList::toString method. At this time, DigitList::toString will > modify tempBuilder, which will cause incorrect results. src/java.base/share/classes

Re: RFR: 8357681: Fixed the DigitList::toString method causing incorrect results during debugging

2025-05-27 Thread Justin Lu
On Sun, 18 May 2025 11:11:32 GMT, Shaojin Wen wrote: > When debugging getLong/getDouble/getDecimal of DigitList, the debugger will > call the DigitList::toString method. At this time, DigitList::toString will > modify tempBuilder, which will cause incorrect results. Change looks good to me, si

Re: RFR: 8357681: Fixed the DigitList::toString method causing incorrect results during debugging

2025-05-26 Thread Chen Liang
On Sun, 18 May 2025 11:11:32 GMT, Shaojin Wen wrote: > When debugging getLong/getDouble/getDecimal of DigitList, the debugger will > call the DigitList::toString method. At this time, DigitList::toString will > modify tempBuilder, which will cause incorrect results. This is a formatting-relate

Re: RFR: 8357681: Fixed the DigitList::toString method causing incorrect results during debugging

2025-05-23 Thread Chen Liang
On Sun, 18 May 2025 11:11:32 GMT, Shaojin Wen wrote: > When debugging getLong/getDouble/getDecimal of DigitList, the debugger will > call the DigitList::toString method. At this time, DigitList::toString will > modify tempBuilder, which will cause incorrect results. This change looks reasonabl

RFR: 8357681: Fixed the DigitList::toString method causing incorrect results during debugging

2025-05-23 Thread Shaojin Wen
When debugging getLong/getDouble/getDecimal of DigitList, the debugger will call the DigitList::toString method. At this time, DigitList::toString will modify tempBuilder, which will cause incorrect results. - Commit messages: - minimal change - remove tempBuilder Changes: https:

Re: DigitList::toString method causing incorrect results during debugging

2025-05-23 Thread Chen Liang
bject: DigitList::toString method causing incorrect results during debugging When debugging getLong/getDouble/getDecimal of java.text.DigitList, the debugger will call the DigitList::toString method. At this time, DigitList::toString will modify tempBuilder, which will cause incorrect results. - Shaojin Wen

DigitList::toString method causing incorrect results during debugging

2025-05-23 Thread wenshao
When debugging getLong/getDouble/getDecimal of java.text.DigitList, the debugger will call the DigitList::toString method. At this time, DigitList::toString will modify tempBuilder, which will cause incorrect results. - Shaojin Wen