Re: Copyright update tedium

2024-12-10 Thread Archie Cobbs
Hi Thomas, On Tue, Dec 10, 2024 at 4:45 AM Thomas Stüfe wrote: > Note that we have a script for that; see > make/scripts/update_copyright_year.sh . I use it a lot. Sonia recently > enhanced it. It even has an option to update copyrights for foreign > companies. > Awesome - thanks for the pointe

Re: Copyright update tedium

2024-12-10 Thread Thomas Stüfe
Hi Archie, Note that we have a script for that; see make/scripts/update_copyright_year.sh . I use it a lot. Sonia recently enhanced it. It even has an option to update copyrights for foreign companies. Calling it from the source root usually works well, it only still struggles with large merge co

Re: Copyright update tedium

2024-12-10 Thread Magnus Ihse Bursie
On 2024-12-09 21:39, Joseph D. Darcy wrote: FWIW, when I've thought about the topic of copyright and licenses before, I think there are several aspects that can be separated. One is a syntactic-only check, as the in-flight Skara PR may provide. I think having a syntactic-only check is Skara i

Re: Copyright update tedium

2024-12-09 Thread Joseph D. Darcy
FWIW, when I've thought about the topic of copyright and licenses before, I think there are several aspects that can be separated. One is a syntactic-only check, as the in-flight Skara PR may provide. I think having a syntactic-only check is Skara is reasonable. A semantic check is "does file

Re: Copyright update tedium

2024-12-09 Thread Archie Cobbs
OK thanks. Apologies for getting confused, I'm not familiar with the skara code so I'm not always sure what I'm looking at. I personally think Skara shouldn't do that, but it is a topic that might be > worth discussing for a future Enhancement. I think it's a good idea, but only to the extent th

Re: Copyright update tedium

2024-12-09 Thread Kevin Rushforth
No, The Skara PR in question isn't proposing to do this. Rather it is checking that _if_ the Copyright header is updated, it is syntactically correct. It would be an item for further discussion to have Skara actually get into the business of whether the copyright header should be updated and

Re: Copyright update tedium

2024-12-09 Thread Archie Cobbs
Bleh, ignore my comment. I didn't realize the PR#1702 you referenced is already proposing doing this! -Archie On Mon, Dec 9, 2024 at 10:45 AM Archie Cobbs wrote: > Thanks for working on this... something of a thankless task :) > > I'm sure you've considered this but I'll ask anyway. Would it ma

Re: Copyright update tedium

2024-12-09 Thread Archie Cobbs
Thanks for working on this... something of a thankless task :) I'm sure you've considered this but I'll ask anyway. Would it make (more or less) sense to try and enforce the policy on the front-end? By that I mean adding another checkbox requirement to skara's handling of PR's: "🔲 Change must upd

Re: Copyright update tedium

2024-12-09 Thread Magnus Ihse Bursie
I felt responsibility for the .github files, and wanted to check if there were more build system files needed updating. So I ran a more comprehensive script, and discovered a *lot* more files that needed updating. Like a thousand or so... I have opened a series of issues starting at https://b

Copyright update tedium

2024-12-03 Thread Archie Cobbs
Dumb question... It seems like the thing with updating copyright years in source files could be better automated. At least, couldn't there be a test that fails if you forget? FWIW my little updater script says that these files still need to be updated to 2024: .github/actions/config/action.yml .